From 141e1cf64845c0f1dd5f7eb1ff67767e41228307 Mon Sep 17 00:00:00 2001 From: dannyrb Date: Mon, 24 Feb 2020 11:20:10 -0500 Subject: [PATCH] chore: note regarding reactivity --- platform/viewer/src/connectedComponents/ToolbarRow.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/viewer/src/connectedComponents/ToolbarRow.js b/platform/viewer/src/connectedComponents/ToolbarRow.js index b012e6eb0..2dca5835f 100644 --- a/platform/viewer/src/connectedComponents/ToolbarRow.js +++ b/platform/viewer/src/connectedComponents/ToolbarRow.js @@ -71,9 +71,9 @@ class ToolbarRow extends Component { const hasActiveContext = this.props.activeContexts.some(actx => contexts.includes(actx) ); - // TODO: what should `isDisabled` receive? - // studies? activeViewport? + // It's a bit beefy to pass studies; probably only need to be reactive on `studyInstanceUIDs` and activeViewport? + // Note: This does not cleanly handle `studies` prop updating with panel open const isDisabled = menuOption.isDisabled(this.props.studies); if (hasActiveContext && !isDisabled) {