refactor(tests): update viewport page object usage to async and update all effected tests (#5927)

This commit is contained in:
Ghadeer Albattarni authored and GitHub committed 2026-03-27 16:37:42 -04:00
1 parent 485f0d75d9
commit 2a728b244c
46 files changed
+240 -181

No files matched your search

+7 -4
View File
@@ -95,7 +95,8 @@ test('checks if measurement item can be relabeled through the context menu on th
// Right click and click rename
await page.waitForTimeout(200); // small delay for context menu
await viewportPageObject.active.nthAnnotation(0).contextMenu.open();
const activeViewport = await viewportPageObject.active;
await activeViewport.nthAnnotation(0).contextMenu.open();
await page.waitForTimeout(200); // small delay for context menu
const addLabelButton = DOMOverlayPageObject.viewport.annotationContextMenu.addLabel;
@@ -117,7 +118,8 @@ test('checks if image would jump when clicked on a measurement item', async ({
rightPanelPageObject,
viewportPageObject,
}) => {
const viewportInfoBottomRight = viewportPageObject.active.overlayText.bottomRight.instanceNumber;
const activeViewport = await viewportPageObject.active;
const viewportInfoBottomRight = activeViewport.overlayText.bottomRight.instanceNumber;
// Image loads on slice 1, confirm on slice 1 then add measurement
await expect(viewportInfoBottomRight).toContainText('1/', { timeout: 10000 });
@@ -198,7 +200,8 @@ test('checks if measurement item can be deleted through the context menu on the
// Right click and click rename
await page.waitForTimeout(200); // small delay for context menu
await viewportPageObject.active.nthAnnotation(0).contextMenu.open();
const activeViewport = await viewportPageObject.active;
await activeViewport.nthAnnotation(0).contextMenu.open();
await page.waitForTimeout(200); // small delay for context menu
const deleteButton = DOMOverlayPageObject.viewport.annotationContextMenu.delete;
@@ -207,6 +210,6 @@ test('checks if measurement item can be deleted through the context menu on the
// Open measurement panel and confirm measurement is gone
await rightPanelPageObject.measurementsPanel.select();
await expect(viewportPageObject.active.nthAnnotation(0).locator).toBeHidden();
await expect(activeViewport.nthAnnotation(0).locator).toBeHidden();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(0);
});