From 2ec4692eaf2349e21b141a2c0b5b104ee10f7a28 Mon Sep 17 00:00:00 2001 From: Billuc <45941626+Billuc@users.noreply.github.com> Date: Thu, 17 Oct 2024 15:49:53 +0200 Subject: [PATCH] fix(createReport): early return on cancel in prompt (#4243) Co-authored-by: Luc Billaud --- extensions/cornerstone-dicom-seg/src/commandsModule.ts | 2 +- extensions/default/src/Actions/createReportAsync.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/cornerstone-dicom-seg/src/commandsModule.ts b/extensions/cornerstone-dicom-seg/src/commandsModule.ts index 5aeac96d2..e4c74ea07 100644 --- a/extensions/cornerstone-dicom-seg/src/commandsModule.ts +++ b/extensions/cornerstone-dicom-seg/src/commandsModule.ts @@ -339,7 +339,7 @@ const commandsModule = ({ extensionManager, }); - if (promptResult.action !== 1 && promptResult.value) { + if (promptResult.action !== 1 && !promptResult.value) { return; } diff --git a/extensions/default/src/Actions/createReportAsync.tsx b/extensions/default/src/Actions/createReportAsync.tsx index 360894437..44d7c7af2 100644 --- a/extensions/default/src/Actions/createReportAsync.tsx +++ b/extensions/default/src/Actions/createReportAsync.tsx @@ -21,6 +21,8 @@ async function createReportAsync({ try { const naturalizedReport = await getReport(); + if (!naturalizedReport) return; + // The "Mode" route listens for DicomMetadataStore changes // When a new instance is added, it listens and // automatically calls makeDisplaySets