From 42cfce60f58d502762ece660b6c3d1a75c2df5c4 Mon Sep 17 00:00:00 2001 From: Danny Brown Date: Wed, 4 Dec 2019 16:25:52 -0500 Subject: [PATCH] docs: simplify PR checklist; add UX stories requirement --- .../pull_request_template.md | 25 +++++-------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index d74eb364c..7ddb1e172 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,23 +1,10 @@ -### Request Checklist +### PR Checklist -- [] Brief description of changes -- [] Links to any relevant issues -- [] Required status checks are passing -- [] `@mention` a maintainer to request a review - -#### Special - -> If this PR is not on a branch for this repo, it is "untrusted" and does not -> have access to env vars. Reviewers can kick off a trusted docker deploy by: -> -> 1. Verifying there are no malicious changes to CI build -> 2. Using the [git-push-fork-to-upstream-branch][script] script -> 3. Executing the manual approval step in the CI workflow - -- [] Request docker publish of PR - -_Want to improve this process? Consider PR'ing the ability for reviewers to add -a label to trigger this process._ +- [ ] Brief description of changes +- [ ] Links to any relevant issues +- [ ] Required status checks are passing +- [ ] UX Stories if changes impact the user's experience +- [ ] `@mention` a maintainer to request a review