Disable canvas if not active (#1890)

This commit is contained in:
Igor Octaviano 2020-07-10 16:52:17 -03:00 committed by GitHub
parent 8b1a6b2acb
commit 4985fbf5a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 15 deletions

View File

@ -41,9 +41,9 @@ function ViewportPane({
} }
}; };
const onInteractionHandler = () => { const onInteractionHandler = (event) => {
onInteraction();
focus(); focus();
onInteraction(event);
}; };
const refHandler = element => { const refHandler = element => {
@ -101,7 +101,7 @@ ViewportPane.propTypes = {
onDoubleClick: PropTypes.func, onDoubleClick: PropTypes.func,
}; };
const noop = () => {}; const noop = () => { };
ViewportPane.defaultProps = { ViewportPane.defaultProps = {
onInteraction: noop, onInteraction: noop,

View File

@ -7,6 +7,7 @@ import { ViewportGrid, ViewportPane, useViewportGrid } from '@ohif/ui';
import EmptyViewport from './EmptyViewport'; import EmptyViewport from './EmptyViewport';
import { classes } from '@ohif/core'; import { classes } from '@ohif/core';
const { ImageSet } = classes; const { ImageSet } = classes;
import classNames from 'classnames';
function ViewerViewportGrid(props) { function ViewerViewportGrid(props) {
const { servicesManager, viewportComponents, dataSource } = props; const { servicesManager, viewportComponents, dataSource } = props;
@ -15,10 +16,6 @@ function ViewerViewportGrid(props) {
viewportGridService, viewportGridService,
] = useViewportGrid(); ] = useViewportGrid();
const setActiveViewportIndex = index => {
viewportGridService.setActiveViewportIndex(index);
};
// TODO -> Need some way of selecting which displaySets hit the viewports. // TODO -> Need some way of selecting which displaySets hit the viewports.
const { DisplaySetService } = servicesManager.services; const { DisplaySetService } = servicesManager.services;
@ -148,6 +145,7 @@ function ViewerViewportGrid(props) {
for (let i = 0; i < numViewportPanes; i++) { for (let i = 0; i < numViewportPanes; i++) {
const viewportIndex = i; const viewportIndex = i;
const isActive = activeViewportIndex === viewportIndex;
const paneMetadata = viewports[i] || {}; const paneMetadata = viewports[i] || {};
const { displaySetInstanceUID } = paneMetadata; const { displaySetInstanceUID } = paneMetadata;
@ -159,8 +157,15 @@ function ViewerViewportGrid(props) {
viewportComponents viewportComponents
); );
const onInterationHandler = () => { const onInterationHandler = (event) => {
setActiveViewportIndex(viewportIndex); if (isActive) return;
if (event) {
event.preventDefault();
event.stopPropagation();
}
viewportGridService.setActiveViewportIndex(viewportIndex);
}; };
// TEMP -> Double click disabled for now // TEMP -> Double click disabled for now
@ -173,13 +178,15 @@ function ViewerViewportGrid(props) {
acceptDropsFor="displayset" acceptDropsFor="displayset"
onDrop={onDropHandler.bind(null, viewportIndex)} onDrop={onDropHandler.bind(null, viewportIndex)}
onInteraction={onInterationHandler} onInteraction={onInterationHandler}
isActive={activeViewportIndex === viewportIndex} isActive={isActive}
> >
<div className={classNames('h-full w-full flex flex-col align-center', { 'pointer-events-none': !isActive })}>
<ViewportComponent <ViewportComponent
displaySet={displaySet} displaySet={displaySet}
viewportIndex={viewportIndex} viewportIndex={viewportIndex}
dataSource={dataSource} dataSource={dataSource}
/> />
</div>
</ViewportPane> </ViewportPane>
); );
} }