From 4ae848761d91988586eeca5df7dd1f0ffadfe6d4 Mon Sep 17 00:00:00 2001 From: Danny Brown Date: Thu, 1 Oct 2020 22:08:51 -0400 Subject: [PATCH] fix: swallow update-image error for "clicking annotation arrows"; as doing _nothing_ if the image isn't loaded yet is perfectly okay (#2076) --- .../src/_shared/setCornerstoneMeasurementActive.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/extensions/measurement-tracking/src/_shared/setCornerstoneMeasurementActive.js b/extensions/measurement-tracking/src/_shared/setCornerstoneMeasurementActive.js index 79279b111..efa243878 100644 --- a/extensions/measurement-tracking/src/_shared/setCornerstoneMeasurementActive.js +++ b/extensions/measurement-tracking/src/_shared/setCornerstoneMeasurementActive.js @@ -27,6 +27,13 @@ export default function setMeasurementActive(measurement) { const enabledElements = cornerstoneTools.store.state.enabledElements; enabledElements.forEach(element => { - cornerstone.updateImage(element); + try { + cornerstone.updateImage(element); + } catch (ex) { + // https://github.com/cornerstonejs/cornerstone/blob/master/src/updateImage.js#L16 + // This fails if enabledElement.image is undefined and we have no layers + // Instead of throwing, it should _probably_ do nothing. + // We'll just swallow the exception + } }); }