TrizTech/ohif-viewer
17
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: validation for Percentage of Max SUV input field in TMTV module (#5417)

Browse Source 
Co-authored-by: Joe Boccanfuso <joe.boccanfuso@radicalimaging.com>
This commit is contained in:
devin-ai-integration[bot]andJoe Boccanfuso authored and GitHub committed 2025-10-07 14:29:07 -04:00
1 parent c05698c5ec
commit 5040c947d2
3 files changed
+78 -39
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/TMTVCSVReport.spec.ts
-1
View File
@@ -2,7 +2,6 @@ import { test, expect } from 'playwright-test-coverage';
import { visitStudy, simulateNormalizedClickOnElement } from './utils/index';
import { viewportLocator } from './utils/locators';
import { downloadAsString } from './utils/download';
import toArray from 'extensions/dicom-microscopy/src/utils/toArray';
test('should create and download the TMTV CSV report correctly', async ({ page }) => {
const studyInstanceUID = '1.2.840.113619.2.290.3.3767434740.226.1600859119.501';
tests/TMTVSUV.spec.ts
+58
View File
@@ -0,0 +1,58 @@
import { test, expect } from 'playwright-test-coverage';
import { visitStudy, simulateNormalizedClickOnElement } from './utils/index';
import { viewportLocator } from './utils/locators';
import { downloadAsString } from './utils/download';
test('should restrict the percentage of max SUV to be between 0 and 1', async ({ page }) => {
const studyInstanceUID = '1.2.840.113619.2.290.3.3767434740.226.1600859119.501';
const mode = 'tmtv';
await visitStudy(page, studyInstanceUID, mode, 10000);
await viewportLocator({ viewportId: 'ptAXIAL', page }).click();
await page.getByTestId('addSegmentation').click();
await page.getByTestId('RectangleROIStartEndThreshold-btn').click();
await page.getByTestId('percentage-of-max-suv-input').fill('0');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0');
await page.getByTestId('percentage-of-max-suv-input').fill('0.27');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.27');
await page.getByTestId('percentage-of-max-suv-input').fill('0.9467');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.9467');
await page.getByTestId('percentage-of-max-suv-input').fill('.');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.');
await page.getByTestId('percentage-of-max-suv-input').fill('1');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('1');
await page.getByTestId('percentage-of-max-suv-input').fill('1.1');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('1');
await page.getByTestId('percentage-of-max-suv-input').fill('1806');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('1');
await page.getByTestId('percentage-of-max-suv-input').fill('');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('');
// Add some valid input for the tests that follow. Note that when invalid input is
// entered the previous valid input is retained.
await page.getByTestId('percentage-of-max-suv-input').fill('0.275');
await page.getByTestId('percentage-of-max-suv-input').fill('9');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.275');
await page.getByTestId('percentage-of-max-suv-input').fill('-678');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.275');
await page.getByTestId('percentage-of-max-suv-input').fill('+');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.275');
await page.getByTestId('percentage-of-max-suv-input').fill('-');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.275');
await page.getByTestId('percentage-of-max-suv-input').fill('e');
expect(await page.getByTestId('percentage-of-max-suv-input').inputValue()).toBe('0.275');
});