From 5036615e003bce849daf85edfb54008b29d54b18 Mon Sep 17 00:00:00 2001 From: Danny Brown Date: Mon, 30 Dec 2019 14:53:39 -0500 Subject: [PATCH 1/2] chore: throw our error if we encounter one (no swallow) (#1337) --- .../studies/services/wado/retrieveMetadataLoader.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/platform/core/src/studies/services/wado/retrieveMetadataLoader.js b/platform/core/src/studies/services/wado/retrieveMetadataLoader.js index 6c695d3b9..4763f4bb0 100644 --- a/platform/core/src/studies/services/wado/retrieveMetadataLoader.js +++ b/platform/core/src/studies/services/wado/retrieveMetadataLoader.js @@ -40,7 +40,9 @@ export default class RetrieveMetadataLoader { if (result && result.length) { break; // closes iterator in case data is retrieved successfully } - } catch (e) { } + } catch (e) { + throw e; + } } if (loaders.next().done && !result) { @@ -51,8 +53,8 @@ export default class RetrieveMetadataLoader { } // Methods to be overwrite - async configLoad() { } - async preLoad() { } - async load(preLoadData) { } - async posLoad(loadData) { } + async configLoad() {} + async preLoad() {} + async load(preLoadData) {} + async posLoad(loadData) {} } From be995f93b66bfba6f614506436cbc9d6a4b6e69d Mon Sep 17 00:00:00 2001 From: ohif-bot Date: Mon, 30 Dec 2019 20:01:54 +0000 Subject: [PATCH 2/2] chore(release): publish [skip ci] - @ohif/extension-vtk@1.2.4 - @ohif/core@2.3.1 - @ohif/viewer@3.3.4 --- extensions/vtk/CHANGELOG.md | 8 ++++++++ extensions/vtk/package.json | 4 ++-- platform/core/CHANGELOG.md | 11 +++++++++++ platform/core/package.json | 2 +- platform/viewer/CHANGELOG.md | 8 ++++++++ platform/viewer/package.json | 6 +++--- 6 files changed, 33 insertions(+), 6 deletions(-) diff --git a/extensions/vtk/CHANGELOG.md b/extensions/vtk/CHANGELOG.md index c11d0873f..046f750e6 100644 --- a/extensions/vtk/CHANGELOG.md +++ b/extensions/vtk/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [1.2.4](https://github.com/OHIF/Viewers/compare/@ohif/extension-vtk@1.2.3...@ohif/extension-vtk@1.2.4) (2019-12-30) + +**Note:** Version bump only for package @ohif/extension-vtk + + + + + ## [1.2.3](https://github.com/OHIF/Viewers/compare/@ohif/extension-vtk@1.2.2...@ohif/extension-vtk@1.2.3) (2019-12-20) diff --git a/extensions/vtk/package.json b/extensions/vtk/package.json index e715096ea..2785e3e0f 100644 --- a/extensions/vtk/package.json +++ b/extensions/vtk/package.json @@ -1,6 +1,6 @@ { "name": "@ohif/extension-vtk", - "version": "1.2.3", + "version": "1.2.4", "description": "OHIF extension for VTK.js", "author": "OHIF", "license": "MIT", @@ -52,7 +52,7 @@ "react-vtkjs-viewport": "^0.3.9" }, "devDependencies": { - "@ohif/core": "^2.3.0", + "@ohif/core": "^2.3.1", "@ohif/ui": "^1.1.7", "cornerstone-tools": "^4.9.0", "cornerstone-wado-image-loader": "^3.0.0", diff --git a/platform/core/CHANGELOG.md b/platform/core/CHANGELOG.md index 218ab3de2..fa4ce0c02 100644 --- a/platform/core/CHANGELOG.md +++ b/platform/core/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [2.3.1](https://github.com/OHIF/Viewers/compare/@ohif/core@2.3.0...@ohif/core@2.3.1) (2019-12-30) + + +### Bug Fixes + +* 🐛 1241: Make Plugin switch part of ToolbarModule ([#1322](https://github.com/OHIF/Viewers/issues/1322)) ([6540e36](https://github.com/OHIF/Viewers/commit/6540e36818944ac2eccc696186366ae495b33a04)), closes [#1241](https://github.com/OHIF/Viewers/issues/1241) + + + + + # [2.3.0](https://github.com/OHIF/Viewers/compare/@ohif/core@2.2.1...@ohif/core@2.3.0) (2019-12-20) diff --git a/platform/core/package.json b/platform/core/package.json index fb37ce3b8..9c86c0728 100644 --- a/platform/core/package.json +++ b/platform/core/package.json @@ -1,6 +1,6 @@ { "name": "@ohif/core", - "version": "2.3.0", + "version": "2.3.1", "description": "Generic business logic for web-based medical imaging applications", "author": "OHIF Core Team", "license": "MIT", diff --git a/platform/viewer/CHANGELOG.md b/platform/viewer/CHANGELOG.md index 33cb04b57..62ba4e929 100644 --- a/platform/viewer/CHANGELOG.md +++ b/platform/viewer/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [3.3.4](https://github.com/OHIF/Viewers/compare/@ohif/viewer@3.3.3...@ohif/viewer@3.3.4) (2019-12-30) + +**Note:** Version bump only for package @ohif/viewer + + + + + ## [3.3.3](https://github.com/OHIF/Viewers/compare/@ohif/viewer@3.3.2...@ohif/viewer@3.3.3) (2019-12-20) diff --git a/platform/viewer/package.json b/platform/viewer/package.json index 504608e9d..4373b06be 100644 --- a/platform/viewer/package.json +++ b/platform/viewer/package.json @@ -1,6 +1,6 @@ { "name": "@ohif/viewer", - "version": "3.3.3", + "version": "3.3.4", "description": "OHIF Viewer", "author": "OHIF Contributors", "license": "MIT", @@ -45,12 +45,12 @@ }, "dependencies": { "@babel/runtime": "^7.5.5", - "@ohif/core": "^2.3.0", + "@ohif/core": "^2.3.1", "@ohif/extension-cornerstone": "^2.2.1", "@ohif/extension-dicom-html": "^1.1.0", "@ohif/extension-dicom-microscopy": "^0.50.6", "@ohif/extension-dicom-pdf": "^1.0.1", - "@ohif/extension-vtk": "^1.2.3", + "@ohif/extension-vtk": "^1.2.4", "@ohif/i18n": "^0.52.4", "@ohif/ui": "^1.1.7", "@tanem/react-nprogress": "^1.1.25",