fix: ohif tests to run with cornerstone 3d 5.0 (#6043)
* chore(tests): Update multiple screenshot test images for various specs * feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts * fix(DICOMSRDisplayTool): Improve actor presence check in viewport * chore(tests): Update multiple screenshot assets for various specs * chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability * chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs * test: update progressive loading screenshots * jest 30 test fixes for compatibility with pnpm cs3d * Use correct setDisplaySets instead of setDataId * fix: Naming change for LegacyVolumeViewport3D * Update to allow tolerance for contour tests * update * fix * refactor: Replace instanceof checks with utility functions for viewport type validation * fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully * bun lock * fix: Install cs3d with pnpm instead of bun * Update node version for playwright * Update to v5.0.0 of cs3d * fix: Build dependency * audit * Change to a web await retry assert * Fix timing related test failures * fix: Freehand close --------- Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This commit is contained in:
1 parent
a27f779f0b
commit
6dd150d401
172 files changed
+3081
-1866
No files matched your search
@@ -59,12 +59,25 @@ test('rectangle and freehand at identical coordinates should yield comparable ar
|
||||
// ANNOTATION_COMPLETED). Ending at the start point would enter interactive close-
|
||||
// preview mode and suppress the completion event; ending further away
|
||||
// would draw a diagonal that distorts the rectangular shape.
|
||||
//
|
||||
// The closing gap must be a fixed number of canvas pixels, not a normalized
|
||||
// fraction: cs3d's close-proximity threshold is in pixels, so a fractional gap
|
||||
// (0.01 × height) grew past the threshold on taller CI viewports and the
|
||||
// contour never auto-closed (intermittent "no cachedStats"). Derive it from the
|
||||
// viewport bbox so the gap is viewport-size-independent.
|
||||
const CLOSE_GAP_PX = 6;
|
||||
const viewportBox = await activeViewport.pane.boundingBox();
|
||||
if (!viewportBox) {
|
||||
throw new Error('Active viewport bounding box not found');
|
||||
}
|
||||
const closeY = 0.3 + CLOSE_GAP_PX / viewportBox.height;
|
||||
|
||||
const corners = [
|
||||
{ x: 0.3, y: 0.3 },
|
||||
{ x: 0.55, y: 0.3 },
|
||||
{ x: 0.55, y: 0.55 },
|
||||
{ x: 0.3, y: 0.55 },
|
||||
{ x: 0.3, y: 0.31 },
|
||||
{ x: 0.3, y: closeY },
|
||||
];
|
||||
const [topLeft, , bottomRight] = corners;
|
||||
|
||||
|
||||
Reference in new issue
Block a user