fix: ohif tests to run with cornerstone 3d 5.0 (#6043)

* chore(tests): Update multiple screenshot test images for various specs

* feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts

* fix(DICOMSRDisplayTool): Improve actor presence check in viewport

* chore(tests): Update multiple screenshot assets for various specs

* chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability

* chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs

* test: update progressive loading screenshots

* jest 30 test fixes for compatibility with pnpm cs3d

* Use correct setDisplaySets instead of setDataId

* fix: Naming change for LegacyVolumeViewport3D

* Update to allow tolerance for contour tests

* update

* fix

* refactor: Replace instanceof checks with utility functions for viewport type validation

* fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully

* bun lock

* fix: Install cs3d with pnpm instead of bun

* Update node version for playwright

* Update to v5.0.0 of cs3d

* fix: Build dependency

* audit

* Change to a web await retry assert

* Fix timing related test failures

* fix: Freehand close

---------

Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This commit is contained in:
AlirezaandBill Wallace authored and GitHub committed 2026-06-09 20:25:14 -04:00
1 parent a27f779f0b
commit 6dd150d401
172 files changed
+3081 -1866

No files matched your search

+8 -8
View File
@@ -168,14 +168,14 @@ test('checks if measurement item can be deleted under Measurements panel', async
// Open measurement panel, confirm 3 measurements
await rightPanelPageObject.measurementsPanel.select();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(3);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(3);
// Delete from measurement
await rightPanelPageObject.measurementsPanel.panel.nthMeasurement(0).actions.delete();
await page.waitForTimeout(200);
// Confirm one measurement is gone
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(2);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(2);
// Delete all measurements via main Measurement Panel delete button and untrack
await rightPanelPageObject.measurementsPanel.panel.deleteAll();
@@ -189,7 +189,7 @@ test('checks if measurement item can be deleted under Measurements panel', async
// Check dialog closed and measurements gone
await expect(DOMOverlayPageObject.dialog.title).toBeHidden();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(0);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(0);
const measurementsPanel = rightPanelPageObject.measurementsPanel.panel.locator;
await expect(measurementsPanel).toContainText('No tracked measurements');
@@ -219,7 +219,7 @@ test('checks if measurement item can be deleted through the context menu on the
// Open measurement panel and confirm measurement is gone
await rightPanelPageObject.measurementsPanel.select();
await expect(activeViewport.nthAnnotation(0).locator).toBeHidden();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(0);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(0);
});
test('checks that undo after delete-all restores measurements as tracked', async ({
@@ -243,13 +243,13 @@ test('checks that undo after delete-all restores measurements as tracked', async
});
await rightPanelPageObject.measurementsPanel.select();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(2);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(2);
await rightPanelPageObject.measurementsPanel.panel.deleteAll();
await expect(DOMOverlayPageObject.dialog.title).toHaveText('Untrack Study');
await DOMOverlayPageObject.dialog.confirmation.confirm.click();
await expect(DOMOverlayPageObject.dialog.title).toBeHidden();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(0);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(0);
await mainToolbarPageObject.undo.click();
@@ -326,14 +326,14 @@ test.describe('simplified tracking mode', () => {
});
await rightPanelPageObject.measurementsPanel.select();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(2);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(2);
await rightPanelPageObject.measurementsPanel.panel.deleteAll();
await expect(DOMOverlayPageObject.dialog.title).toHaveText('Untrack Study');
await DOMOverlayPageObject.dialog.confirmation.confirm.click();
await expect(DOMOverlayPageObject.dialog.title).toBeHidden();
expect(await rightPanelPageObject.measurementsPanel.panel.getMeasurementCount()).toBe(0);
await expect(rightPanelPageObject.measurementsPanel.panel.rows).toHaveCount(0);
await mainToolbarPageObject.undo.click();