fix: ohif tests to run with cornerstone 3d 5.0 (#6043)

* chore(tests): Update multiple screenshot test images for various specs

* feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts

* fix(DICOMSRDisplayTool): Improve actor presence check in viewport

* chore(tests): Update multiple screenshot assets for various specs

* chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability

* chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs

* test: update progressive loading screenshots

* jest 30 test fixes for compatibility with pnpm cs3d

* Use correct setDisplaySets instead of setDataId

* fix: Naming change for LegacyVolumeViewport3D

* Update to allow tolerance for contour tests

* update

* fix

* refactor: Replace instanceof checks with utility functions for viewport type validation

* fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully

* bun lock

* fix: Install cs3d with pnpm instead of bun

* Update node version for playwright

* Update to v5.0.0 of cs3d

* fix: Build dependency

* audit

* Change to a web await retry assert

* Fix timing related test failures

* fix: Freehand close

---------

Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This commit is contained in:
AlirezaandBill Wallace authored and GitHub committed 2026-06-09 20:25:14 -04:00
1 parent a27f779f0b
commit 6dd150d401
172 files changed
+3081 -1866

No files matched your search

+13
View File
@@ -5,6 +5,7 @@ import {
screenShotPaths,
test,
visitStudy,
waitForPaintToSettle,
waitForViewportsRendered,
waitForViewportRenderCycle,
expect,
@@ -40,6 +41,12 @@ test.describe('3D four up SEG hydration', async () => {
await leftPanelPageObject.loadSeriesByDescription('SEG');
await viewportRenderCycle;
await expect(DOMOverlayPageObject.viewport.segmentationHydration.locator).toBeVisible({
timeout: 60000,
});
await waitForViewportsRendered(page, { timeout: 60000 });
await page.waitForTimeout(3000);
await waitForPaintToSettle(page);
await checkForScreenshot(
page,
@@ -57,6 +64,12 @@ test.describe('3D four up SEG hydration', async () => {
// Wait until all viewports have finished rendering
await viewportRenderCycle;
// 3D volume rendering keeps streaming refined geometry after the load
// status flips; give the GPU a window to present the final frame before
// screenshotting.
await waitForViewportsRendered(page, { timeout: 180000 });
await page.waitForTimeout(3000);
await waitForPaintToSettle(page);
await checkForScreenshot({
page,