fix: ohif tests to run with cornerstone 3d 5.0 (#6043)

* chore(tests): Update multiple screenshot test images for various specs

* feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts

* fix(DICOMSRDisplayTool): Improve actor presence check in viewport

* chore(tests): Update multiple screenshot assets for various specs

* chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability

* chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs

* test: update progressive loading screenshots

* jest 30 test fixes for compatibility with pnpm cs3d

* Use correct setDisplaySets instead of setDataId

* fix: Naming change for LegacyVolumeViewport3D

* Update to allow tolerance for contour tests

* update

* fix

* refactor: Replace instanceof checks with utility functions for viewport type validation

* fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully

* bun lock

* fix: Install cs3d with pnpm instead of bun

* Update node version for playwright

* Update to v5.0.0 of cs3d

* fix: Build dependency

* audit

* Change to a web await retry assert

* Fix timing related test failures

* fix: Freehand close

---------

Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This commit is contained in:
AlirezaandBill Wallace authored and GitHub committed 2026-06-09 20:25:14 -04:00
1 parent a27f779f0b
commit 6dd150d401
172 files changed
+3081 -1866

No files matched your search

+22 -3
View File
@@ -1,5 +1,13 @@
import { Locator } from '@playwright/test';
import { checkForScreenshot, expect, screenShotPaths, test, visitStudy } from './utils';
import {
checkForScreenshot,
expect,
screenShotPaths,
test,
visitStudy,
waitForPaintToSettle, waitForViewportRenderCycle,
waitForViewportsRendered,
} from './utils';
async function expectNonEmptyDetailLines(lines: Locator) {
const lineCount = await lines.count();
@@ -27,7 +35,7 @@ test.beforeEach(async ({ page }) => {
}
});
});
test.describe.configure({ retries: 1 });
test('should hydrate SCOORD3D probe measurements correctly', async ({
page,
DOMOverlayPageObject,
@@ -90,8 +98,12 @@ test('should hydrate SCOORD3D probe measurements correctly', async ({
// Click the hydrate button to load the SCOORD3D probe measurements
await DOMOverlayPageObject.viewport.segmentationHydration.yes.click();
// Wait for hydration to complete and rendering to stabilize
// Wait for hydration to complete and rendering to stabilize. SCOORD3D
// hydration can swap the displayed series (referenced vs. current volume),
// so we must wait for the new image set to render before screenshotting.
await waitForViewportsRendered(page);
await page.waitForTimeout(3000);
await waitForPaintToSettle(page);
// Take screenshot after hydration showing the probe measurements - use viewport locator
await checkForScreenshot(
@@ -129,9 +141,16 @@ test('should hydrate SCOORD3D probe measurements correctly', async ({
viewport.render();
}
});
await waitForViewportsRendered(page, { waitVolumeLoad: false });
// Click on a data row to jump to the measurement
const jumpRenderCycle = waitForViewportRenderCycle(page, {
renderedTimeout: 30000,
waitVolumeLoad: false,
});
await rightPanelPageObject.measurementsPanel.panel.nthMeasurement(0).click();
await jumpRenderCycle;
await waitForPaintToSettle(page);
// Take screenshot showing the jump to measurement functionality - use viewport locator
await checkForScreenshot(