fix: ohif tests to run with cornerstone 3d 5.0 (#6043)

* chore(tests): Update multiple screenshot test images for various specs

* feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts

* fix(DICOMSRDisplayTool): Improve actor presence check in viewport

* chore(tests): Update multiple screenshot assets for various specs

* chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability

* chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs

* test: update progressive loading screenshots

* jest 30 test fixes for compatibility with pnpm cs3d

* Use correct setDisplaySets instead of setDataId

* fix: Naming change for LegacyVolumeViewport3D

* Update to allow tolerance for contour tests

* update

* fix

* refactor: Replace instanceof checks with utility functions for viewport type validation

* fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully

* bun lock

* fix: Install cs3d with pnpm instead of bun

* Update node version for playwright

* Update to v5.0.0 of cs3d

* fix: Build dependency

* audit

* Change to a web await retry assert

* Fix timing related test failures

* fix: Freehand close

---------

Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
This commit is contained in:
AlirezaandBill Wallace authored and GitHub committed 2026-06-09 20:25:14 -04:00
1 parent a27f779f0b
commit 6dd150d401
172 files changed
+3081 -1866

No files matched your search

+9 -4
View File
@@ -7,6 +7,8 @@ import {
screenShotPaths,
test,
visitStudy,
waitForPaintToSettle,
waitForViewportsRendered,
} from './utils';
async function expectNonEmptyDetailLines(lines: Locator) {
@@ -53,10 +55,13 @@ test('should hydrate SCOORD rectangle measurements correctly', async ({
// Double-click on the study browser thumbnail to load the SR
await leftPanelPageObject.loadSeriesByModality('SR');
await page.waitForTimeout(2000);
// Wait for the SR to load and stabilize before taking screenshot
await page.waitForTimeout(1000);
// The DICOMSRDisplayTool only draws the SCOORD rectangle once the
// underlying image has been rendered (it bails out when the viewport
// has no actors). Wait for the image to render before checking the
// overlay, otherwise the screenshot captures a blank canvas.
await waitForViewportsRendered(page);
await page.waitForTimeout(3000);
await waitForPaintToSettle(page);
const activeViewport = await viewportPageObject.active;