fix(DICOM PDF and Video): fixes for local DICOM load and remote data sources (#3374)

* fix(DICOM PDF and Video)
- added retrieve.directURL for local DICOM load data source; it returns a data URL
- fixed various checks for video using transfer syntaxes and SOP class UID with number of frames
- added call to 'rendered' endpoint for those data sources that support it; others get BulkDataURI

* Added DOC (PDF) and OT (for video in particular) to list of non-image thumbnail modalities.

* Fixed broken e2e tests.
This commit is contained in:
Joe Boccanfuso authored and GitHub committed 2023-05-10 12:42:48 -04:00
1 parent 0eda151418
commit 8eaa1877fd
12 files changed
+59 -20

No files matched your search

@@ -18,7 +18,7 @@ const ThumbnailNoImage = ({
isActive,
}) => {
const [collectedProps, drag, dragPreview] = useDrag({
type: "displayset",
type: 'displayset',
item: { ...dragData },
canDrag: function(monitor) {
return Object.keys(dragData).length !== 0;
@@ -39,6 +39,7 @@ const ThumbnailNoImage = ({
onDoubleClick={onDoubleClick}
role="button"
tabIndex="0"
data-cy={`study-browser-thumbnail-no-image`}
>
<div ref={drag}>
<div className="flex flex-col flex-1">
@@ -6,7 +6,7 @@ describe('OHIF PDF Display', function() {
});
it('checks if series thumbnails are being displayed', function() {
cy.get('[data-cy="study-browser-thumbnail"]')
cy.get('[data-cy="study-browser-thumbnail-no-image"]')
.its('length')
.should('be.gt', 0);
});
@@ -5,13 +5,15 @@ describe('OHIF Video Display', function() {
});
it('checks if series thumbnails are being displayed', function() {
cy.get('[data-cy="study-browser-thumbnail"]')
cy.get('[data-cy="study-browser-thumbnail-no-image"]')
.its('length')
.should('be.gt', 1);
});
it('performs double-click to load thumbnail in active viewport', () => {
cy.get('[data-cy="study-browser-thumbnail"]:nth-child(2)').dblclick();
cy.get(
'[data-cy="study-browser-thumbnail-no-image"]:nth-child(2)'
).dblclick();
//const expectedText = 'Ser: 3';
//cy.get('@viewportInfoBottomLeft').should('contains.text', expectedText);
@@ -32,6 +32,7 @@ window.config = {
auth: 'admin:admin',
},
dicomUploadEnabled: true,
singlepart: 'pdf,video',
},
},
{
@@ -21,6 +21,10 @@ const DICOMFileLoader = new (class extends FileLoader {
dicomData.meta
);
dataset.AvailableTransferSyntaxUID =
dataset.AvailableTransferSyntaxUID ||
dataset._meta.TransferSyntaxUID?.Value?.[0];
return dataset;
}
})();