From c91b6dddd8888d82747e8094112c3d079766cadf Mon Sep 17 00:00:00 2001 From: dannyrb Date: Tue, 10 Dec 2019 22:17:21 -0500 Subject: [PATCH 1/2] ci: optional visual test step --- .circleci/config.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 06dc83443..36aedabc2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -367,6 +367,31 @@ workflows: requires: - UNIT_TESTS + PR_OPTIONAL_VISUAL_TESTS: + jobs: + - AWAIT_APPROVAL: + type: approval + # Update hub.docker.org + - cypress/run: + name: 'E2E: PWA' + executor: cypress/browsers-chrome76 + pre-steps: + - run: 'rm -rf ~/.yarn && npm i -g yarn && yarn -v && yarn global + add wait-on' # Use yarn latest + yarn: true + store_artifacts: false + working_directory: platform/viewer + build: npx cross-env QUICK_BUILD=true yarn run build + # start server --> verify running --> percy + chrome + cypress + command: yarn run test:e2e:dist + cache-key: 'yarn-packages-{{ checksum "yarn.lock" }}' + no-workspace: true # Don't persist workspace + post-steps: + - store_artifacts: + path: platform/viewer/cypress/screenshots + requires: + - AWAIT_APPROVAL + PR_OPTIONAL_DOCKER_PUBLISH: jobs: # https://circleci.com/docs/2.0/workflows/#holding-a-workflow-for-a-manual-approval From e3c119489af1fd0ce29dc387141850bd42e7757f Mon Sep 17 00:00:00 2001 From: dannyrb Date: Tue, 10 Dec 2019 23:07:54 -0500 Subject: [PATCH 2/2] cI: Better job name for percy --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 36aedabc2..1d377e2c4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -373,7 +373,7 @@ workflows: type: approval # Update hub.docker.org - cypress/run: - name: 'E2E: PWA' + name: 'Generate Percy Snapshots' executor: cypress/browsers-chrome76 pre-steps: - run: 'rm -rf ~/.yarn && npm i -g yarn && yarn -v && yarn global