[OHIF 284] - JumpToMeasurement + prevent layout change on scroll Prevent layout change on scroll (#1889)

* No more setting on debounce, jumpToMeasurement service set up.

* Fix bug causing a race condition sometimes if you click super fast.

* Optimise rendering of Tracking viewport slightly.

* element => targetElement

* Remove complete TODO

* Respond to reviewer comments.

* Fix e2e workflow.

* Fix regression that removed highlighting on jump to.

* Make sure jump to works from panel as well as viewport.

* Fix typo and remove debugger.

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>

platform/core/package.json

@@ -38,7 +38,7 @@
   "dependencies": {
     "@babel/runtime": "7.7.6",
     "ajv": "^6.10.0",
-    "dcmjs": "0.16.0",
+    "dcmjs": "0.16.1",
     "dicomweb-client": "^0.6.0",
     "immer": "6.0.2",
     "isomorphic-base64": "^1.0.2",

platform/core/src/services/DisplaySetService/DisplaySetService.js

@@ -46,6 +46,20 @@ export default class DisplaySetService {
     );
   };
 
+  getDisplaySetForSOPInstanceUID(SOPInstanceUID, SeriesInstanceUID) {
+    const displaySets = SeriesInstanceUID
+      ? this.getDisplaySetsForSeries(SeriesInstanceUID)
+      : this.getDisplaySetCache();
+
+    const displaySet = displaySets.find(ds => {
+      return (
+        ds.images && ds.images.some(i => i.SOPInstanceUID === SOPInstanceUID)
+      );
+    });
+
+    return displaySet;
+  }
+
   /**
    * @param {string} displaySetInstanceUID
    * @returns {object} displaySet

platform/core/src/services/MeasurementService/MeasurementService.js

@@ -53,6 +53,7 @@ const EVENTS = {
   MEASUREMENT_ADDED: 'event::measurement_added',
   MEASUREMENT_REMOVED: 'event::measurement_removed',
   MEASUREMENTS_CLEARED: 'event::measurements_cleared',
+  JUMP_TO_MEASUREMENT: 'event:jump_to_measurement',
 };
 
 const VALUE_TYPES = {
@@ -70,6 +71,7 @@ class MeasurementService {
     this.mappings = {};
     this.measurements = {};
     this.listeners = {};
+    this._jumpToMeasurementCache = {};
     Object.defineProperty(this, 'EVENTS', {
       value: EVENTS,
       writable: false,
@@ -498,6 +500,40 @@ class MeasurementService {
     this._broadcastChange(this.EVENTS.MEASUREMENTS_CLEARED);
   }
 
+  jumpToMeasurement(viewportIndex, id) {
+    const measurement = this.measurements[id];
+
+    if (!measurement) {
+      log.warn(`No id provided, or unable to find measurement by id.`);
+      return;
+    }
+
+    this._addJumpToMeasurement(viewportIndex, id);
+
+    const eventName = this.EVENTS.JUMP_TO_MEASUREMENT;
+
+    const hasListeners = Object.keys(this.listeners).length > 0;
+    const hasCallbacks = Array.isArray(this.listeners[eventName]);
+
+    if (hasListeners && hasCallbacks) {
+      this.listeners[eventName].forEach(listener => {
+        listener.callback({ viewportIndex, measurement });
+      });
+    }
+  }
+
+  _addJumpToMeasurement(viewportIndex, id) {
+    this._jumpToMeasurementCache[viewportIndex] = id;
+  }
+
+  getJumpToMeasurement(viewportIndex) {
+    return this._jumpToMeasurementCache[viewportIndex];
+  }
+
+  removeJumpToMeasurement(viewportIndex) {
+    delete this._jumpToMeasurementCache[viewportIndex];
+  }
+
   _getMappingByMeasurementSource(measurementId, definition) {
     const measurement = this.getMeasurement(measurementId);
     if (this._isValidSource(measurement.source)) {