From c3c132d268d108f62e9c881e7c01e8e8e0db49fd Mon Sep 17 00:00:00 2001 From: Joe Boccanfuso <109477394+jbocce@users.noreply.github.com> Date: Wed, 5 Jul 2023 08:43:01 -0400 Subject: [PATCH] fix(tracked-measurement): SR viewports disable jump to measurement (#3518) --- .../src/viewports/OHIFCornerstoneSRViewport.tsx | 1 + .../src/Viewport/OHIFCornerstoneViewport.tsx | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx b/extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx index 8d56f400d..3eb2dfe58 100644 --- a/extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx +++ b/extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx @@ -225,6 +225,7 @@ function OHIFCornerstoneSRViewport(props) { }} onElementEnabled={onElementEnabled} initialImageIndex={initialImageIndex} + isJumpToMeasurementDisabled={true} > ); }, [activeImageDisplaySetData, viewportIndex, measurementSelected]); diff --git a/extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx b/extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx index a94cc0fc6..850a31307 100644 --- a/extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx +++ b/extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx @@ -119,6 +119,7 @@ const OHIFCornerstoneViewport = React.memo(props => { servicesManager, onElementEnabled, onElementDisabled, + isJumpToMeasurementDisabled, // Note: you SHOULD NOT use the initialImageIdOrIndex for manipulation // of the imageData in the OHIFCornerstoneViewport. This prop is used // to set the initial state of the viewport's first image to render @@ -454,6 +455,10 @@ const OHIFCornerstoneViewport = React.memo(props => { * the cache for jumping to see if there is any jump queued, then we jump to the correct slice. */ useEffect(() => { + if (isJumpToMeasurementDisabled) { + return; + } + const unsubscribeFromJumpToMeasurementEvents = _subscribeToJumpToMeasurementEvents( measurementService, displaySetService, @@ -716,6 +721,10 @@ function _jumpToMeasurement( // Component displayName OHIFCornerstoneViewport.displayName = 'OHIFCornerstoneViewport'; +OHIFCornerstoneViewport.defaultProps = { + isJumpToMeasurementDisabled: false, +}; + OHIFCornerstoneViewport.propTypes = { viewportIndex: PropTypes.number.isRequired, displaySets: PropTypes.array.isRequired, @@ -724,6 +733,7 @@ OHIFCornerstoneViewport.propTypes = { displaySetOptions: PropTypes.arrayOf(PropTypes.any), servicesManager: PropTypes.object.isRequired, onElementEnabled: PropTypes.func, + isJumpToMeasurementDisabled: PropTypes.bool, // Note: you SHOULD NOT use the initialImageIdOrIndex for manipulation // of the imageData in the OHIFCornerstoneViewport. This prop is used // to set the initial state of the viewport's first image to render