fix(dicom-tag-browser): Prevent long series names from overlapping - OHIF-2406 (#5809)

This commit is contained in:
Ghadeer Albattarni authored and GitHub committed 2026-02-17 16:56:00 -05:00
1 parent f668848230
commit cca1a8683b
6 files changed
+140 -5

No files matched your search

+6
View File
@@ -1,4 +1,5 @@
import { Locator, Page } from '@playwright/test';
import { DicomTagBrowserPageObject } from './DicomTagBrowserPageObject';
export class DOMOverlayPageObject {
readonly page: Page;
@@ -46,6 +47,11 @@ export class DOMOverlayPageObject {
},
};
},
get dicomTagBrowser() {
return new DicomTagBrowserPageObject(page);
},
title: page.locator('[role="dialog"] h2'),
};
}
+43
View File
@@ -0,0 +1,43 @@
import { Page } from '@playwright/test';
export class DicomTagBrowserPageObject {
readonly page: Page;
constructor(page: Page) {
this.page = page;
}
async waitVisible() {
const locator = this.page.locator('[role="dialog"]').filter({
has: this.page.getByTestId('dicom-tag-series-select-trigger'),
});
await locator.waitFor({ state: 'visible' });
}
get seriesSelect() {
const page = this.page;
const trigger = page.getByTestId('dicom-tag-series-select-trigger');
const value = page.getByTestId('dicom-tag-series-select-value');
const options = page.getByRole('option');
return {
trigger,
value,
options,
async click() {
await trigger.click();
},
async selectOption(index) {
await this.click();
const optionText = await options.nth(index).innerText();
const selectedText = optionText.split('\n')[0].trim();
await options.nth(index).click();
return selectedText;
},
};
}
}
+2
View File
@@ -4,6 +4,7 @@ import { LeftPanelPageObject } from './LeftPanelPageObject';
import { RightPanelPageObject } from './RightPanelPageObject';
import { ViewportPageObject } from './ViewportPageObject';
import { NotFoundStudyPageObject } from './NotFoundStudyPageObject';
import { DicomTagBrowserPageObject } from './DicomTagBrowserPageObject';
export {
DOMOverlayPageObject,
@@ -12,4 +13,5 @@ export {
RightPanelPageObject,
ViewportPageObject,
NotFoundStudyPageObject,
DicomTagBrowserPageObject,
};