replaced REACT_APP_CONFIG with APP_CONFIG
This commit is contained in:
parent
38ea92d2a3
commit
d46cccc652
@ -27,4 +27,4 @@ mv platform/viewer/dist/* .netlify/www/pwa -v
|
|||||||
echo 'Nothing left to see here. Go home, folks.'
|
echo 'Nothing left to see here. Go home, folks.'
|
||||||
|
|
||||||
# Build using react-scripts
|
# Build using react-scripts
|
||||||
# npx cross-env PUBLIC_URL=/demo REACT_APP_CONFIG=config/netlify.js react-scripts --max_old_space_size=4096 build
|
# npx cross-env PUBLIC_URL=/demo APP_CONFIG=config/netlify.js react-scripts --max_old_space_size=4096 build
|
||||||
|
|||||||
@ -53,7 +53,7 @@ Images can even be transcoded on the fly if this is desired.
|
|||||||
```bash
|
```bash
|
||||||
cd OHIFViewer
|
cd OHIFViewer
|
||||||
yarn install
|
yarn install
|
||||||
REACT_APP_CONFIG=config/google.js yarn run dev
|
APP_CONFIG=config/google.js yarn run dev
|
||||||
```
|
```
|
||||||
|
|
||||||
## Running via Docker
|
## Running via Docker
|
||||||
|
|||||||
@ -72,9 +72,9 @@ how to configure the project for your own imaging archive below.
|
|||||||
|
|
||||||
The configuration for our project is in the `/public/config` directory. Our
|
The configuration for our project is in the `/public/config` directory. Our
|
||||||
build process knows which configuration file to use based on the
|
build process knows which configuration file to use based on the
|
||||||
`REACT_APP_CONFIG` environment variable. By default, its value is
|
`APP_CONFIG` environment variable. By default, its value is
|
||||||
[`default.js`](https://github.com/OHIF/Viewers/blob/react/public/config/default.js).
|
[`default.js`](https://github.com/OHIF/Viewers/blob/react/public/config/default.js).
|
||||||
When we build, the `%REACT_APP_CONFIG%` value in
|
When we build, the `%APP_CONFIG%` value in
|
||||||
our[`/public/index.html`](https://github.com/OHIF/Viewers/blob/react/public/index.html#L12-L15)
|
our[`/public/index.html`](https://github.com/OHIF/Viewers/blob/react/public/index.html#L12-L15)
|
||||||
file is substituted for the correct configuration file's name. This sets
|
file is substituted for the correct configuration file's name. This sets
|
||||||
the`window.config` equal to our configuration file's value.
|
the`window.config` equal to our configuration file's value.
|
||||||
@ -108,13 +108,13 @@ window.config = {
|
|||||||
```
|
```
|
||||||
|
|
||||||
You can also create a new config file and specify its path relative to the build
|
You can also create a new config file and specify its path relative to the build
|
||||||
output's root by setting the `REACT_APP_CONFIG` environment variable. You can
|
output's root by setting the `APP_CONFIG` environment variable. You can
|
||||||
set the value of this environment variable a few different ways:
|
set the value of this environment variable a few different ways:
|
||||||
|
|
||||||
- [Add a temporary environment variable in your shell](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-temporary-environment-variables-in-your-shell)
|
- [Add a temporary environment variable in your shell](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-temporary-environment-variables-in-your-shell)
|
||||||
- [Add environment specific variables in `.env` file(s)](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-development-environment-variables-in-env)
|
- [Add environment specific variables in `.env` file(s)](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-development-environment-variables-in-env)
|
||||||
- Using the `cross-env` package in an npm script:
|
- Using the `cross-env` package in an npm script:
|
||||||
- `"build": "cross-env REACT_APP_CONFIG=config/my-config.js react-scripts build"`
|
- `"build": "cross-env APP_CONFIG=config/my-config.js react-scripts build"`
|
||||||
|
|
||||||
After updating the configuration, `yarn run build:web` to generate updated build
|
After updating the configuration, `yarn run build:web` to generate updated build
|
||||||
output.
|
output.
|
||||||
|
|||||||
@ -124,10 +124,10 @@ likely want to update:
|
|||||||
The OHIF Viewer's configuration is imported from a static `.js` file and made
|
The OHIF Viewer's configuration is imported from a static `.js` file and made
|
||||||
available globally at `window.config`. The configuration we use is set to a
|
available globally at `window.config`. The configuration we use is set to a
|
||||||
specific file when we build the viewer, and determined by the env variable:
|
specific file when we build the viewer, and determined by the env variable:
|
||||||
`REACT_APP_CONFIG`. You can see where we set its value in the `dockerfile` for
|
`APP_CONFIG`. You can see where we set its value in the `dockerfile` for
|
||||||
this solution:
|
this solution:
|
||||||
|
|
||||||
`ENV REACT_APP_CONFIG=config/docker_openresty-orthanc.js`
|
`ENV APP_CONFIG=config/docker_openresty-orthanc.js`
|
||||||
|
|
||||||
You can find the configuration we're using here:
|
You can find the configuration we're using here:
|
||||||
`/public/config/docker_openresty-orthanc.js`
|
`/public/config/docker_openresty-orthanc.js`
|
||||||
|
|||||||
@ -125,10 +125,10 @@ likely want to update:
|
|||||||
The OHIF Viewer's configuration is imported from a static `.js` file and made
|
The OHIF Viewer's configuration is imported from a static `.js` file and made
|
||||||
available globally at `window.config`. The configuration we use is set to a
|
available globally at `window.config`. The configuration we use is set to a
|
||||||
specific file when we build the viewer, and determined by the env variable:
|
specific file when we build the viewer, and determined by the env variable:
|
||||||
`REACT_APP_CONFIG`. You can see where we set its value in the `dockerfile` for
|
`APP_CONFIG`. You can see where we set its value in the `dockerfile` for
|
||||||
this solution:
|
this solution:
|
||||||
|
|
||||||
`ENV REACT_APP_CONFIG=config/docker_openresty-orthanc-keycloak.js`
|
`ENV APP_CONFIG=config/docker_openresty-orthanc-keycloak.js`
|
||||||
|
|
||||||
You can find the configuration we're using here:
|
You can find the configuration we're using here:
|
||||||
`/public/config/docker_openresty-orthanc-keycloak.js`
|
`/public/config/docker_openresty-orthanc-keycloak.js`
|
||||||
|
|||||||
@ -8,9 +8,9 @@
|
|||||||
|
|
||||||
The configuration for our project is in the `/public/config` directory. Our
|
The configuration for our project is in the `/public/config` directory. Our
|
||||||
build process knows which configuration file to use based on the
|
build process knows which configuration file to use based on the
|
||||||
`REACT_APP_CONFIG` environment variable. By default, its value is
|
`APP_CONFIG` environment variable. By default, its value is
|
||||||
[`default.js`](https://github.com/OHIF/Viewers/blob/react/public/config/default.js).
|
[`default.js`](https://github.com/OHIF/Viewers/blob/react/public/config/default.js).
|
||||||
When we build, the `%REACT_APP_CONFIG%` value in
|
When we build, the `%APP_CONFIG%` value in
|
||||||
our[`/public/index.html`](https://github.com/OHIF/Viewers/blob/react/public/index.html#L12-L15)
|
our[`/public/index.html`](https://github.com/OHIF/Viewers/blob/react/public/index.html#L12-L15)
|
||||||
file is substituted for the correct configuration file's name. This sets the
|
file is substituted for the correct configuration file's name. This sets the
|
||||||
`window.config` equal to our configuration file's value.
|
`window.config` equal to our configuration file's value.
|
||||||
@ -44,13 +44,13 @@ window.config = {
|
|||||||
```
|
```
|
||||||
|
|
||||||
You can also create a new config file and specify its path relative to the build
|
You can also create a new config file and specify its path relative to the build
|
||||||
output's root by setting the `REACT_APP_CONFIG` environment variable. You can
|
output's root by setting the `APP_CONFIG` environment variable. You can
|
||||||
set the value of this environment variable a few different ways:
|
set the value of this environment variable a few different ways:
|
||||||
|
|
||||||
- [Add a temporary environment variable in your shell](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-temporary-environment-variables-in-your-shell)
|
- [Add a temporary environment variable in your shell](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-temporary-environment-variables-in-your-shell)
|
||||||
- [Add environment specific variables in `.env` file(s)](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-development-environment-variables-in-env)
|
- [Add environment specific variables in `.env` file(s)](https://facebook.github.io/create-react-app/docs/adding-custom-environment-variables#adding-development-environment-variables-in-env)
|
||||||
- Using the `cross-env` package in an npm script:
|
- Using the `cross-env` package in an npm script:
|
||||||
- `"build": "cross-env REACT_APP_CONFIG=config/my-config.js react-scripts build"`
|
- `"build": "cross-env APP_CONFIG=config/my-config.js react-scripts build"`
|
||||||
|
|
||||||
After updating the configuration, `yarn run build:web` to generate updated build
|
After updating the configuration, `yarn run build:web` to generate updated build
|
||||||
output.
|
output.
|
||||||
|
|||||||
@ -87,16 +87,16 @@ is running the `dev:orthanc` script in our project's `package.json`. That script
|
|||||||
is:
|
is:
|
||||||
|
|
||||||
```js
|
```js
|
||||||
cross-env PORT=5000 REACT_APP_CONFIG=config/docker_nginx-orthanc.js react-scripts start
|
cross-env PORT=5000 APP_CONFIG=config/docker_nginx-orthanc.js react-scripts start
|
||||||
```
|
```
|
||||||
|
|
||||||
- `cross-env` sets two environment variables
|
- `cross-env` sets two environment variables
|
||||||
- PORT: 5000
|
- PORT: 5000
|
||||||
- REACT_APP_CONFIG: `config/docker_nginx-orthanc.js`
|
- APP_CONFIG: `config/docker_nginx-orthanc.js`
|
||||||
- `react-scripts` runs it's `start` script. This is [the de-facto
|
- `react-scripts` runs it's `start` script. This is [the de-facto
|
||||||
way][cra-start] to run a "Create React App" in development mode.
|
way][cra-start] to run a "Create React App" in development mode.
|
||||||
|
|
||||||
The `REACT_APP_CONFIG` value tells our app which file to load on to
|
The `APP_CONFIG` value tells our app which file to load on to
|
||||||
`window.config`. By default, our app uses the file at
|
`window.config`. By default, our app uses the file at
|
||||||
`<project-root>/public/config/default.js`. Here is what that configuration looks
|
`<project-root>/public/config/default.js`. Here is what that configuration looks
|
||||||
like:
|
like:
|
||||||
|
|||||||
@ -69,7 +69,7 @@ services:
|
|||||||
# - orthanc
|
# - orthanc
|
||||||
environment:
|
environment:
|
||||||
- NODE_ENV=production
|
- NODE_ENV=production
|
||||||
- REACT_APP_CONFIG=config/local_dcm4chee
|
- APP_CONFIG=config/local_dcm4chee
|
||||||
restart: always
|
restart: always
|
||||||
networks:
|
networks:
|
||||||
- dcm4che_default
|
- dcm4che_default
|
||||||
|
|||||||
@ -28,7 +28,7 @@ FROM node:11.2.0-slim as builder
|
|||||||
RUN mkdir /usr/src/app
|
RUN mkdir /usr/src/app
|
||||||
WORKDIR /usr/src/app
|
WORKDIR /usr/src/app
|
||||||
|
|
||||||
ENV REACT_APP_CONFIG=config/docker_openresty-orthanc-keycloak.js
|
ENV APP_CONFIG=config/docker_openresty-orthanc-keycloak.js
|
||||||
ENV PATH /usr/src/app/node_modules/.bin:$PATH
|
ENV PATH /usr/src/app/node_modules/.bin:$PATH
|
||||||
|
|
||||||
COPY package.json /usr/src/app/package.json
|
COPY package.json /usr/src/app/package.json
|
||||||
|
|||||||
@ -28,7 +28,7 @@ FROM node:11.2.0-slim as builder
|
|||||||
RUN mkdir /usr/src/app
|
RUN mkdir /usr/src/app
|
||||||
WORKDIR /usr/src/app
|
WORKDIR /usr/src/app
|
||||||
|
|
||||||
ENV REACT_APP_CONFIG=config/docker_openresty-orthanc.js
|
ENV APP_CONFIG=config/docker_openresty-orthanc.js
|
||||||
ENV PATH /usr/src/app/node_modules/.bin:$PATH
|
ENV PATH /usr/src/app/node_modules/.bin:$PATH
|
||||||
|
|
||||||
COPY package.json /usr/src/app/package.json
|
COPY package.json /usr/src/app/package.json
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user