feat: make hanging protocol work on displaySets instead of series (#2837)

* feat(HP): Apply HP to display sets, fix race condition

* fix: displaySetService no event not needed (#2912)

* fix various styles and renamings

* feat: refactored hp service

* fix: use HP service event for viewport grid

* remove unnecessary doc

* fix test

* apply review comment

* fix: segmentation creation

Co-authored-by: Alireza <ar.sedghi@gmail.com>

extensions/default/src/DicomWebDataSource/index.js

@@ -473,12 +473,13 @@ function createDicomWebApi(dicomWebConfig, UserAuthenticationService) {
 
       DicomMetadataStore.addSeriesMetadata(seriesSummaryMetadata, madeInClient);
 
-      const numberOfSeries = seriesPromises.length;
-      seriesPromises.forEach(async (seriesPromise, index) => {
-        const instances = await seriesPromise;
-        storeInstances(instances);
-        if (index === numberOfSeries - 1) setSuccessFlag();
-      });
+      const seriesDeliveredPromises = seriesPromises.map(promise =>
+        promise.then(instances => {
+          storeInstances(instances);
+        })
+      );
+      await Promise.all(seriesDeliveredPromises);
+      setSuccessFlag();
     },
     deleteStudyMetadataPromise,
     getImageIdsForDisplaySet(displaySet) {

extensions/default/src/getHangingProtocolModule.js

@@ -23,7 +23,9 @@ const defaultProtocol = {
       displaySets: [
         {
           id: 'displaySet',
+          // Unused currently
           imageMatchingRules: [],
+          // Matches displaysets, NOT series
           seriesMatchingRules: [],
           studyMatchingRules: [],
         },