TrizTech/ohif-viewer
15
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: fix dev-server script (#811)

Browse Source 
* ci: test docs-publish

* Require unit tests for dry run

* ci: Make sure our docs publish is executable

* Try to correct path issue

* Try repo prefix

* Try as yarn command

* Need a workspace to attach to from previous step

* Add before we call our bash script

* See if we can enforce commands being available -- or just install locally?

* Try again

* Try SSH

* Include username in gh https url

* Note regarding failure on PR branches

* Remove docs publish from PR workflow

* chore: ability to specify an alternative html-template at build time

* chore: add command to build demo PWA website output

* chore: remove unused CI code

* Testing GCP capabilities

* syntax

* Naming

* naming

* chore: WebPack output progress that we care about

* chore: Only publish the app config we care about

* PWA should publish source map

* Unused index.html file

* chore: Remove unused copy-webpack-plugin ignore

* Don't generate source map until we resolve memory issue

* ci: attempt to publish with GCP bucket deploy

* Update dev config to use new template loccations and env vars
This commit is contained in:
Danny Brown 2019-08-27 15:19:23 -04:00 committed by GitHub
parent 619d363243
commit ec4e2ef1a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
platform/viewer/.webpack/all.dev.js
View File

@ -19,6 +19,7 @@ const DIST_DIR = path.join(__dirname, '../dist');
const PUBLIC_DIR = path.join(__dirname, '../public'); const PUBLIC_DIR = path.join(__dirname, '../public');
const ASSET_PATH = process.env.ASSET_PATH || '/'; const ASSET_PATH = process.env.ASSET_PATH || '/';
// Env Vars // Env Vars
const HTML_TEMPLATE = process.env.HTML_TEMPLATE || 'index.html';
const PUBLIC_URL = process.env.PUBLIC_URL || ''; const PUBLIC_URL = process.env.PUBLIC_URL || '';
const APP_CONFIG = process.env.APP_CONFIG || 'config/default.js'; const APP_CONFIG = process.env.APP_CONFIG || 'config/default.js';
@ -42,16 +43,21 @@ module.exports = (env, argv) => {
to: DIST_DIR, to: DIST_DIR,
toType: 'dir', toType: 'dir',
// Ignore our HtmlWebpackPlugin template file // Ignore our HtmlWebpackPlugin template file
ignore: ['index.html', '.DS_Store'], // Ignore our configuration files
ignore: ['config/*', 'html-templates/*', '.DS_Store'],
},
// Copy over and rename our target app config file
{
from: `${PUBLIC_DIR}/${APP_CONFIG}`,
to: `${DIST_DIR}/app-config.js`,
}, },
]), ]),
// Generate "index.html" w/ correct includes/imports // Generate "index.html" w/ correct includes/imports
new HtmlWebpackPlugin({ new HtmlWebpackPlugin({
template: `${PUBLIC_DIR}/index.html`, template: `${PUBLIC_DIR}/html-templates/${HTML_TEMPLATE}`,
filename: 'index.html', filename: 'index.html',
templateParameters: { templateParameters: {
PUBLIC_URL: PUBLIC_URL, PUBLIC_URL: PUBLIC_URL,
APP_CONFIG: APP_CONFIG,
}, },
}), }),
], ],