feat: enhanced error handling ui (#3021)
* feat: better error handling * better error handling * try to fix netlify build * remove new line
This commit is contained in:
1 parent
83ea228d86
commit
eddd510a35
8 files changed
+73
-39
No files matched your search
@@ -8,14 +8,6 @@ import { utils } from '@ohif/core';
|
||||
|
||||
const { downloadCSVReport } = utils;
|
||||
|
||||
// tools with measurements to display inside the panel
|
||||
const MEASUREMENT_TOOLS = [
|
||||
'EllipticalROI',
|
||||
'RectangleROI',
|
||||
'Length',
|
||||
'Bidirectional',
|
||||
];
|
||||
|
||||
export default function PanelMeasurementTable({
|
||||
servicesManager,
|
||||
commandsManager,
|
||||
@@ -185,12 +177,8 @@ PanelMeasurementTable.propTypes = {
|
||||
|
||||
function _getMappedMeasurements(MeasurementService) {
|
||||
const measurements = MeasurementService.getMeasurements();
|
||||
// filter out measurements whose toolName is not in MEASUREMENT_TOOLS
|
||||
const measurementTools = measurements.filter(measurement =>
|
||||
MEASUREMENT_TOOLS.includes(measurement.toolName)
|
||||
);
|
||||
|
||||
const mappedMeasurements = measurementTools.map((m, index) =>
|
||||
const mappedMeasurements = measurements.map((m, index) =>
|
||||
_mapMeasurementToDisplay(m, index, MeasurementService.VALUE_TYPES)
|
||||
);
|
||||
|
||||
|
||||
@@ -122,10 +122,29 @@ function ViewerLayout({
|
||||
};
|
||||
}, []);
|
||||
|
||||
const getPanelData = id => {
|
||||
const getComponent = id => {
|
||||
const entry = extensionManager.getModuleEntry(id);
|
||||
// TODO, not sure why sidepanel content has to be JSX, and not a children prop?
|
||||
const content = entry.component;
|
||||
|
||||
if (!entry) {
|
||||
throw new Error(
|
||||
`${id} is not a valid entry for an extension module, please check your configuration or make sure the extension is registered.`
|
||||
);
|
||||
}
|
||||
|
||||
let content;
|
||||
if (entry && entry.component) {
|
||||
content = entry.component;
|
||||
} else {
|
||||
throw new Error(
|
||||
`No component found from extension ${id}. Check the reference string to the extension in your Mode configuration`
|
||||
);
|
||||
}
|
||||
|
||||
return { entry, content };
|
||||
};
|
||||
|
||||
const getPanelData = id => {
|
||||
const { content, entry } = getComponent(id);
|
||||
|
||||
return {
|
||||
iconName: entry.iconName,
|
||||
@@ -156,7 +175,7 @@ function ViewerLayout({
|
||||
}, [HangingProtocolService]);
|
||||
|
||||
const getViewportComponentData = viewportComponent => {
|
||||
const entry = extensionManager.getModuleEntry(viewportComponent.namespace);
|
||||
const { entry } = getComponent(viewportComponent.namespace);
|
||||
|
||||
return {
|
||||
component: entry.component,
|
||||
|
||||
Reference in new issue
Block a user