TrizTech/ohif-viewer
15
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rendering): Fix palette color LUT conversion causing black images (#5509)

Browse Source 
The palette color LUT was incorrectly handling 16 bit entries, and didn't work for both array buffers and typed arrays.
This commit is contained in:
Ibrahim 2025-10-20 13:07:39 -04:00 committed by GitHub
parent 66e6d73ad6
commit ffd9ec3273
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
platform/core/src/utils/metadataProvider/fetchPaletteColorLookupTableData.js
View File

@ -30,18 +30,15 @@ function _getPaletteColor(paletteColorLookupTableData, lutDescriptor) {
} }
const arrayBufferToPaletteColorLUT = arraybuffer => { const arrayBufferToPaletteColorLUT = arraybuffer => {
// Handle both ArrayBuffer and TypedArray inputs
const buffer = arraybuffer.buffer || arraybuffer;
const data = bits === 16 ? new Uint16Array(buffer) : new Uint8Array(buffer);
const lut = []; const lut = [];
if (bits === 16) {
let j = 0;
for (let i = 0; i < numLutEntries; i++) { for (let i = 0; i < numLutEntries; i++) {
lut[i] = (arraybuffer[j++] + arraybuffer[j++]) << 8; lut[i] = data[i];
}
} else {
for (let i = 0; i < numLutEntries; i++) {
lut[i] = arraybuffer[i];
}
} }
return lut; return lut;
}; };
@ -51,10 +48,10 @@ function _getPaletteColor(paletteColorLookupTableData, lutDescriptor) {
if (paletteColorLookupTableData.InlineBinary) { if (paletteColorLookupTableData.InlineBinary) {
try { try {
const arraybuffer = Uint8Array.from(atob(paletteColorLookupTableData.InlineBinary), c => const uint8Array = Uint8Array.from(atob(paletteColorLookupTableData.InlineBinary), c =>
c.charCodeAt(0) c.charCodeAt(0)
); );
return (paletteColorLookupTableData.palette = arrayBufferToPaletteColorLUT(arraybuffer)); return (paletteColorLookupTableData.palette = arrayBufferToPaletteColorLUT(uint8Array));
} catch (e) { } catch (e) {
console.log("Couldn't decode", paletteColorLookupTableData.InlineBinary, e); console.log("Couldn't decode", paletteColorLookupTableData.InlineBinary, e);
return undefined; return undefined;