Bill WallaceandClaude Opus 4.8
3dd5c70cb2
* Add customization URL parameter * fix: Preserve should be customizeable * Update customizations docs * fix: Overlay items on patient name * Add customization test * Fix resolve to absolute path * fix: Warn on no data in load * Remove unused customization stuff * fix: PR comments * Update stored parameters to only use an array for mulitples * Remove requires ohif.* special call out * Remove strict mode * PR comments * Document segmentation examples * Add three examples as requested * PR comments * lock * Remove old customizatoin export * fix: Ordering issues on customization loads * fix: Use correct default for dev builds app config * Fixes for conflicts * chore: restore pnpm-lock.yaml to match master The lockfile diff was incidental peer-descriptor churn and carried no functional dependency change. It tripped the CircleCI security-audit gate (which only runs when pnpm-lock.yaml is in the PR diff), surfacing a pre-existing critical `decompress` transitive vuln that also exists on master. Restoring master's lockfile removes the audit trigger. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ci): restore json5 lockfile entry; ignore unfixable decompress GHSA The previous commit restored pnpm-lock.yaml from master, which dropped the json5@2.2.3 entry that platform/core legitimately depends on (JSONC parsing for the customization feature). That broke `--frozen-lockfile` install (ERR_PNPM_OUTDATED_LOCKFILE). This restores the correct lockfile. Because the lockfile must change (json5), the CircleCI security-audit gate runs and previously failed on a critical `decompress` <=4.2.1 zip-slip advisory. This is a pre-existing transitive vuln (present on master too) with no published patch — decompress's latest release is 4.2.1, so no version bump/override can resolve it. It reaches the tree only via @itk-wasm/dam, a build/data-asset extraction tool under @cornerstonejs/labelmap-interpolation. Add GHSA-mp2f-45pm-3cg9 to the existing pnpm-workspace.yaml auditConfig ignoreGhsas accepted-risk list, matching how the repo already exempts other build-tooling advisories. `pnpm audit --audit-level high` now passes locally (1 critical ignored, 0 high). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(e2e): fix visitStudy URL encoding that broke mpr2 study load The visitStudy rewrite (added for the ?customization= option) built the URL with new URLSearchParams({ StudyInstanceUIDs: studyInstanceUID }), which percent-encodes the value. mpr2.spec.ts embeds an extra param in the UID string ('<uid>&hangingprotocolid=mpr'), so the & and = were encoded and the whole thing collapsed into one invalid StudyInstanceUIDs value -> the study could not be found ('studies are not available'), the viewer never rendered, and the side-panel-header-right click timed out. Restore master's raw concatenation for StudyInstanceUIDs (so embedded params survive as separate query params) while still appending the customization option separately. Only mpr2 embeds & in the UID, matching the single failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * PR comments --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
57 lines
1.6 KiB
JSON
57 lines
1.6 KiB
JSON
// Example URL-loaded customization: veterinaryOverlay
|
|
//
|
|
// Demonstrates a runtime-loaded customization that overrides the default
|
|
// viewport overlay with a veterinary-style demographics layout. Loaded via
|
|
// `?customization=veterinaryOverlay` (see CustomizationService URL handling).
|
|
//
|
|
// Uses the same `global`-at-top-level shape as the cornerstone overlay samples
|
|
// and `inheritsFrom: 'ohif.overlayItem'` on each row, matching
|
|
// extensions/cornerstone/.../viewportOverlayCustomization.tsx.
|
|
{
|
|
"global": {
|
|
"viewportOverlay.topLeft": {
|
|
"$set": [
|
|
{
|
|
"id": "PatientName",
|
|
"inheritsFrom": "ohif.overlayItem",
|
|
"attribute": "PatientName",
|
|
"label": "Patient",
|
|
"title": "Patient name"
|
|
},
|
|
{
|
|
"id": "PatientID",
|
|
"inheritsFrom": "ohif.overlayItem",
|
|
"attribute": "PatientID",
|
|
"label": "ID",
|
|
"title": "Patient ID"
|
|
},
|
|
{
|
|
"id": "StudyDate",
|
|
"inheritsFrom": "ohif.overlayItem",
|
|
"attribute": "StudyDate",
|
|
"label": "Date",
|
|
"title": "Study date"
|
|
}
|
|
]
|
|
},
|
|
"viewportOverlay.topRight": {
|
|
"$set": [
|
|
{
|
|
"id": "PatientSpecies",
|
|
"inheritsFrom": "ohif.overlayItem",
|
|
"attribute": "PatientSpecies",
|
|
"label": "Species",
|
|
"title": "Patient species"
|
|
},
|
|
{
|
|
"id": "PatientBreed",
|
|
"inheritsFrom": "ohif.overlayItem",
|
|
"attribute": "PatientBreed",
|
|
"label": "Breed",
|
|
"title": "Patient breed"
|
|
}
|
|
]
|
|
}
|
|
}
|
|
}
|