othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CR Update: Improve ohifmodal proptypes

Browse Source
This commit is contained in:
Igor 2019-11-14 11:42:25 -03:00
parent 95c18b4986
commit 08fdb10f6d
2 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
platform/ui/src/components/ohifModal/OHIFModal.js
View File

@ -54,7 +54,12 @@ OHIFModal.propTypes = {
onHide: PropTypes.func,
footer: PropTypes.node,
header: PropTypes.node,
children: PropTypes.node,
children: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.object,
PropTypes.func,
]).isRequired,
};
export default OHIFModal;

19
platform/ui/src/utils/ModalProvider.js
View File

@ -40,10 +40,9 @@ const ModalProvider = ({ children, modal: Modal, service }) => {
*
* @returns void
*/
const show = useCallback((component, props = {}) => {
setOptions(Object.assign({}, options, props, { component }));
console.log(component, props);
});
const show = useCallback((component, props = {}) =>
setOptions(Object.assign({}, options, props, { component }))
);
/**
* Hide the modal and set its properties to default.
@ -80,8 +79,16 @@ const ModalProvider = ({ children, modal: Modal, service }) => {
};
ModalProvider.propTypes = {
children: PropTypes.node.isRequired,
modal: PropTypes.node.isRequired,
children: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.func,
]).isRequired,
modal: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.func,
]).isRequired,
service: PropTypes.shape({
setServiceImplementation: PropTypes.func,
}).isRequired,