CR Update: Improve ohifmodal proptypes

This commit is contained in:
Igor 2019-11-14 11:42:25 -03:00
parent 95c18b4986
commit 08fdb10f6d
2 changed files with 19 additions and 7 deletions

View File

@ -54,7 +54,12 @@ OHIFModal.propTypes = {
onHide: PropTypes.func, onHide: PropTypes.func,
footer: PropTypes.node, footer: PropTypes.node,
header: PropTypes.node, header: PropTypes.node,
children: PropTypes.node, children: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.object,
PropTypes.func,
]).isRequired,
}; };
export default OHIFModal; export default OHIFModal;

View File

@ -40,10 +40,9 @@ const ModalProvider = ({ children, modal: Modal, service }) => {
* *
* @returns void * @returns void
*/ */
const show = useCallback((component, props = {}) => { const show = useCallback((component, props = {}) =>
setOptions(Object.assign({}, options, props, { component })); setOptions(Object.assign({}, options, props, { component }))
console.log(component, props); );
});
/** /**
* Hide the modal and set its properties to default. * Hide the modal and set its properties to default.
@ -80,8 +79,16 @@ const ModalProvider = ({ children, modal: Modal, service }) => {
}; };
ModalProvider.propTypes = { ModalProvider.propTypes = {
children: PropTypes.node.isRequired, children: PropTypes.oneOfType([
modal: PropTypes.node.isRequired, PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.func,
]).isRequired,
modal: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.node),
PropTypes.node,
PropTypes.func,
]).isRequired,
service: PropTypes.shape({ service: PropTypes.shape({
setServiceImplementation: PropTypes.func, setServiceImplementation: PropTypes.func,
}).isRequired, }).isRequired,