From 28ac391c52d5b3c7f4ec8b99506527879d5b5f82 Mon Sep 17 00:00:00 2001
From: Bruno Alves de Faria <brunoalvesdefaria@gmail.com>
Date: Mon, 23 Jan 2017 20:04:42 -0200
Subject: [PATCH] LT-55: Exposing grouping measurements method in OHIF
 namespace

---
 .../measurementTableHeaderRow.html            |  4 +-
 .../measurementTableHeaderRow.js              | 34 +++----
 .../measurementTableView.html                 | 25 ++---
 .../measurementTableView.js                   | 99 ++-----------------
 .../lib/getMeasurementsGroupedByNumber.js     | 91 +++++++++++++++++
 .../ohif-measurements/client/lib/index.js     |  1 +
 6 files changed, 125 insertions(+), 129 deletions(-)
 create mode 100644 Packages/ohif-measurements/client/lib/getMeasurementsGroupedByNumber.js

diff --git a/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.html b/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.html
index 9cdc53d7e..213aff3c3 100644
--- a/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.html
+++ b/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.html
@@ -7,9 +7,9 @@
                 </svg>
             </div>
         {{/if}}
-        <div class="type">{{measurementType.name}}</div>
+        <div class="type">{{toolGroup.name}}</div>
         <div class="max {{#if gt numberOfMeasurements maxNumMeasurements}}warning{{/if}}">
-            {{#if and maxNumMeasurements (eq measurementType.id 'targets')}}
+            {{#if and maxNumMeasurements (eq toolGroup.id 'targets')}}
                 <p class="maxNumMeasurements">Max {{maxNumMeasurements}}</p>
             {{/if}}
         </div>
diff --git a/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.js b/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.js
index deaff5c2c..a710c87f8 100644
--- a/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.js
+++ b/Packages/ohif-measurements/client/components/measurementTable/measurementTableHeaderRow/measurementTableHeaderRow.js
@@ -3,37 +3,30 @@ import { OHIF } from 'meteor/ohif:core';
 
 Template.measurementTableHeaderRow.helpers({
     numberOfMeasurements() {
-        const instance = Template.instance();
-        if (!instance.data.measurements) {
-            return;
-        }
-
-        return instance.data.measurements.length;
+        const { measurementRows } = Template.instance().data;
+        return measurementRows.length ? measurementRows.length : null;
     },
 
     maxNumMeasurements() {
-        const instance = Template.instance();
-        if (!instance.data.conformanceCriteria) {
-            return;
-        }
+        const { conformanceCriteria } = Template.instance().data;
+        if (!conformanceCriteria) return;
 
-        return instance.data.conformanceCriteria.maxTargets.get();
+        return conformanceCriteria.maxTargets.get();
     },
 
     anyUnmarkedLesionsLeft() {
         // Skip New Lesions section
         const instance = Template.instance();
-        if (!instance.data.measurements) {
+        const { toolGroup, measurementRows, timepointApi, measurementApi } = instance.data;
+        if (!measurementRows) {
             return;
         }
 
-        const measurementType = instance.data.measurementType;
         const config = OHIF.measurements.MeasurementApi.getConfiguration();
-        if (measurementType.id === config.newMeasurementTool.id) {
+        if (toolGroup.id === config.newMeasurementTool.id) {
             return;
         }
 
-        const timepointApi = instance.data.timepointApi;
         const current = timepointApi.current();
         const prior = timepointApi.prior();
         if (!prior) {
@@ -42,11 +35,10 @@ Template.measurementTableHeaderRow.helpers({
 
         const currentFilter = { timepointId: current.timepointId };
         const priorFilter = { timepointId: prior.timepointId };
-        const measurementTypeId = measurementType.id;
+        const toolGroupId = toolGroup.id;
 
-        const measurementApi = instance.data.measurementApi;
-        const numCurrent = measurementApi.fetch(measurementTypeId, currentFilter).length;
-        const numPrior = measurementApi.fetch(measurementTypeId, priorFilter).length;
+        const numCurrent = measurementApi.fetch(toolGroupId, currentFilter).length;
+        const numPrior = measurementApi.fetch(toolGroupId, priorFilter).length;
         const remaining = Math.max(numPrior - numCurrent, 0);
         return remaining > 0;
     }
@@ -54,7 +46,7 @@ Template.measurementTableHeaderRow.helpers({
 
 Template.measurementTableHeaderRow.events({
     'click .js-setTool'(event, instance) {
-        const measurementType = instance.data.measurementType;
-        toolManager.setActiveTool(measurementType.cornerstoneToolType);
+        const { toolGroup } = instance.data;
+        toolManager.setActiveTool(toolGroup.childTools[0].cornerstoneToolType);
     }
 });
diff --git a/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.html b/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.html
index ead606434..b5e990d5b 100644
--- a/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.html
+++ b/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.html
@@ -1,22 +1,13 @@
 <template name="measurementTableView">
     <div class="measurementTableView scrollArea">
-        {{#let config=measurementConfiguration}}
-            {{#each toolGroup in config.measurementTools}}
-                {{#if shallDisplayGroup toolGroup.id}}
-                    {{#let collection=(groupByMeasurementNumber toolGroup.id)}}
-                        {{>measurementTableHeaderRow
-                            measurementType=toolGroup
-                            measurements=collection
-                            currentTimepointId=currentTimepointId
-                            timepointApi=timepointApi
-                            measurementApi=measurementApi
-                            conformanceCriteria=conformanceCriteria}}
-
-                        {{#each entry in collection}}
-                            {{>measurementTableRow (clone this rowItem=entry)}}
-                        {{/each}}
-                    {{/let}}
-                {{/if}}
+        {{#let config=measurementConfiguration measurementGroups=getMeasurementsGroupedByNumber}}
+            {{#each measurementGroup in measurementGroups}}
+                {{>measurementTableHeaderRow (clone this
+                    toolGroup=measurementGroup.toolGroup
+                    measurementRows=measurementGroup.measurementRows)}}
+                {{#each rowItem in measurementGroup.measurementRows}}
+                    {{>measurementTableRow (clone this rowItem=rowItem)}}
+                {{/each}}
             {{/each}}
 
             {{#if config.newMeasurementTool}}
diff --git a/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.js b/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.js
index 51c883ec7..e06235aa8 100644
--- a/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.js
+++ b/Packages/ohif-measurements/client/components/measurementTable/measurementTableView/measurementTableView.js
@@ -2,34 +2,6 @@ import { Template } from 'meteor/templating';
 import { _ } from 'meteor/underscore';
 import { OHIF } from 'meteor/ohif:core';
 
-OHIF.measurements.getLocation = collection => {
-    for (let i = 0; i < collection.length; i++) {
-        if (collection[i].location) {
-            return collection[i].location;
-        }
-    }
-};
-
-Template.measurementTableView.onCreated(() => {
-    const instance = Template.instance();
-    const measurementApi = instance.data.measurementApi;
-    const configuration = OHIF.measurements.MeasurementApi.getConfiguration();
-
-    instance.displayToolGroupMap = {};
-    instance.displayToolList = [];
-    configuration.measurementTools.forEach(toolGroup => {
-        instance.displayToolGroupMap[toolGroup.id] = false;
-        toolGroup.childTools.forEach(tool => {
-            const willDisplay = !!(tool.options && tool.options.measurementTable && tool.options.measurementTable.displayFunction);
-            if (willDisplay) {
-                instance.displayToolList.push(tool.id);
-                instance.displayToolGroupMap[toolGroup.id] = true;
-            }
-        });
-    });
-});
-
-
 Template.measurementTableView.helpers({
     getNewMeasurementType(tool) {
         // TODO: Check Conformance criteria here.
@@ -42,56 +14,9 @@ Template.measurementTableView.helpers({
         };
     },
 
-    shallDisplayGroup(toolGroupId) {
-        const instance = Template.instance();
-        return instance.displayToolGroupMap[toolGroupId];
-    },
-
-    groupByMeasurementNumber(measurementTypeId) {
-        const instance = Template.instance();
-        const measurementApi = instance.data.measurementApi;
-        const timepointApi = instance.data.timepointApi;
-        const baseline = timepointApi.baseline();
-        if (!measurementApi || !timepointApi || !baseline) {
-            return;
-        }
-
-        // Retrieve all the data for this Measurement type (e.g. 'targets')
-        // which was recorded at baseline.
-        const atBaseline = measurementApi.fetch(measurementTypeId, {
-            timepointId: baseline.timepointId
-        });
-
-        // Obtain a list of the Measurement Numbers from the
-        // measurements which have baseline data
-        const numbers = atBaseline.map(m => m.measurementNumber);
-
-        // Retrieve all the data for this Measurement type which
-        // match the Measurement Numbers obtained above
-        const data = measurementApi.fetch(measurementTypeId, {
-            toolId: {
-                $in: instance.displayToolList
-            },
-            measurementNumber: {
-                $in: numbers
-            }
-        });
-
-        // Group the Measurements by Measurement Number
-        const groupObject = _.groupBy(data, entry => entry.measurementNumber);
-
-        // Reformat the data for display in the table
-        return Object.keys(groupObject).map(key => {
-            const anEntry = groupObject[key][0];
-
-            return {
-                measurementTypeId: measurementTypeId,
-                measurementNumber: key,
-                location: OHIF.measurements.getLocation(groupObject[key]),
-                responseStatus: false, // TODO: Get the latest timepoint and determine the response status
-                entries: groupObject[key]
-            };
-        });
+    getMeasurementsGroupedByNumber() {
+        const { measurementApi, timepointApi } = Template.instance().data;
+        return OHIF.measurements.getMeasurementsGroupedByNumber(measurementApi, timepointApi);
     },
 
     newMeasurements(measurementType) {
@@ -135,16 +60,12 @@ Template.measurementTableView.helpers({
         const groupObject = _.groupBy(data, entry => entry.measurementNumber);
 
         // Reformat the data for display in the table
-        return Object.keys(groupObject).map(key => {
-            const anEntry = groupObject[key][0];
-
-            return {
-                measurementTypeId: measurementTypeId,
-                measurementNumber: key,
-                location: OHIF.measurements.getLocation(groupObject[key]),
-                responseStatus: false, // TODO: Get the latest timepoint and determine the response status
-                entries: groupObject[key]
-            };
-        });
+        return Object.keys(groupObject).map(key => ({
+            measurementTypeId: measurementTypeId,
+            measurementNumber: key,
+            location: OHIF.measurements.getLocation(groupObject[key]),
+            responseStatus: false, // TODO: Get the latest timepoint and determine the response status
+            entries: groupObject[key]
+        }));
     }
 });
diff --git a/Packages/ohif-measurements/client/lib/getMeasurementsGroupedByNumber.js b/Packages/ohif-measurements/client/lib/getMeasurementsGroupedByNumber.js
new file mode 100644
index 000000000..c0becbc9a
--- /dev/null
+++ b/Packages/ohif-measurements/client/lib/getMeasurementsGroupedByNumber.js
@@ -0,0 +1,91 @@
+import { OHIF } from 'meteor/ohif:core';
+import { _ } from 'meteor/underscore';
+
+// TODO: change this to a const after refactoring newMeasurements code on measurementTableView.js
+OHIF.measurements.getLocation = collection => {
+    for (let i = 0; i < collection.length; i++) {
+        if (collection[i].location) {
+            return collection[i].location;
+        }
+    }
+};
+
+/**
+ * Group all measurements by its tool group and measurement number.
+ *
+ * @param measurementApi
+ * @param timepointApi
+ * @returns {*} A list containing each toolGroup and an array containing the measurement rows
+ */
+OHIF.measurements.getMeasurementsGroupedByNumber = (measurementApi, timepointApi) => {
+    const getPath = OHIF.utils.ObjectPath.get;
+    const configuration = OHIF.measurements.MeasurementApi.getConfiguration();
+
+    if (!measurementApi || !timepointApi || !configuration) return;
+
+    // Check which tools are going to be displayed
+    const displayToolGroupMap = {};
+    const displayToolList = [];
+    configuration.measurementTools.forEach(toolGroup => {
+        displayToolGroupMap[toolGroup.id] = false;
+        toolGroup.childTools.forEach(tool => {
+            const willDisplay = !!getPath(tool, 'options.measurementTable.displayFunction');
+            if (willDisplay) {
+                displayToolList.push(tool.id);
+                displayToolGroupMap[toolGroup.id] = true;
+            }
+        });
+    });
+
+    // Create the result object
+    const groupedMeasurements = [];
+
+    const baseline = timepointApi.baseline();
+    if (!baseline) return;
+
+    configuration.measurementTools.forEach(toolGroup => {
+        // Skip this tool group if it should not be displayed
+        if (!displayToolGroupMap[toolGroup.id]) return;
+
+        // Retrieve all the data for this Measurement type (e.g. 'targets')
+        // which was recorded at baseline.
+        const atBaseline = measurementApi.fetch(toolGroup.id, {
+            timepointId: baseline.timepointId
+        });
+
+        // Obtain a list of the Measurement Numbers from the
+        // measurements which have baseline data
+        const numbers = atBaseline.map(m => m.measurementNumber);
+
+        // Retrieve all the data for this Measurement type which
+        // match the Measurement Numbers obtained above
+        const data = measurementApi.fetch(toolGroup.id, {
+            toolId: {
+                $in: displayToolList
+            },
+            measurementNumber: {
+                $in: numbers
+            }
+        });
+
+        // Group the Measurements by Measurement Number
+        const groupObject = _.groupBy(data, entry => entry.measurementNumber);
+
+        // Reformat the data for display in the table
+        const measurementRows = Object.keys(groupObject).map(key => ({
+            measurementTypeId: toolGroup.id,
+            measurementNumber: key,
+            location: OHIF.measurements.getLocation(groupObject[key]),
+            responseStatus: false, // TODO: Get the latest timepoint and determine the response status
+            entries: groupObject[key]
+        }));
+
+        // Add the group to the result
+        groupedMeasurements.push({
+            toolGroup,
+            measurementRows
+        });
+    });
+
+    return groupedMeasurements;
+};
diff --git a/Packages/ohif-measurements/client/lib/index.js b/Packages/ohif-measurements/client/lib/index.js
index d8d271e3a..5bf5d7c92 100644
--- a/Packages/ohif-measurements/client/lib/index.js
+++ b/Packages/ohif-measurements/client/lib/index.js
@@ -2,6 +2,7 @@ import './jumpToRowItem.js';
 import './activateMeasurements.js';
 import './deactivateAllToolData.js';
 import './exportPdf.js';
+import './getMeasurementsGroupedByNumber.js';
 import './getTimepointName.js';
 import './hangingProtocolCustomizations.js';
 import './MeasurementHandlers.js';