othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #496 from dannyrb/fix/codesandbox-embedded

Browse Source 
Fix codesandbox link
This commit is contained in:
Danny Brown 2019-05-28 10:09:11 -04:00 committed by GitHub
commit 3125cd6417
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/latest/deployment/index.md
View File

@ -24,8 +24,7 @@ add a powerful medical imaging viewer to an existing web page using only a few
include tags. include tags.
- Read more about it here: [Embedded Viewer](./recipes/embedded-viewer.md) - Read more about it here: [Embedded Viewer](./recipes/embedded-viewer.md)
- And check out our - And check out our [live demo on CodeSandbox][code-sandbox]
[live demo on CodeSandbox](https://codesandbox.io/s/lrjoo3znxm)
{% include "./_embedded-viewer-diagram.md" %} {% include "./_embedded-viewer-diagram.md" %}
@ -207,4 +206,5 @@ Please feel free to suggest or contribute your own recipes.
[host-static-assets]: https://www.netlify.com/blog/2016/05/18/9-reasons-your-site-should-be-static/ [host-static-assets]: https://www.netlify.com/blog/2016/05/18/9-reasons-your-site-should-be-static/
[cors]: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS [cors]: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS
[code-flows]: https://medium.com/@darutk/diagrams-of-all-the-openid-connect-flows-6968e3990660 [code-flows]: https://medium.com/@darutk/diagrams-of-all-the-openid-connect-flows-6968e3990660
[code-sandbox]: https://codesandbox.io/s/ohif-viewer-script-tag-usage-b3st9
<!-- prettier-ignore-end --> <!-- prettier-ignore-end -->

9
docs/latest/deployment/recipes/embedded-viewer.md
View File

@ -92,10 +92,9 @@ ReactDOM.render(app, document.getElementById('ohif-viewer-target'))
> I'm having trouble getting this to work. Where can I go for help? > I'm having trouble getting this to work. Where can I go for help?
First, check out this fully functional First, check out this fully functional [CodeSandbox][code-sandbox] example. If
[CodeSandbox](https://codesandbox.io/s/ohif-viewer-script-tag-usage-b3st9) you're still having trouble, feel free to search or GitHub issues. Can't find
example. If you're still having trouble, feel free to search or GitHub issues. anything related your problem? Create a new one.
Can't find anything related your problem? Create a new one.
> When I include bootstrap, other styles on my page no longer work correctly. > When I include bootstrap, other styles on my page no longer work correctly.
> What can I do? > What can I do?
@ -108,3 +107,5 @@ Have that working? Good. Now `embed` that new page using an
This should produce the expected result while also protecting your page from any This should produce the expected result while also protecting your page from any
globally defined styles/scripts. globally defined styles/scripts.
[code-sandbox]: https://codesandbox.io/s/ohif-viewer-script-tag-usage-b3st9