othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: Try workaround for percy snapshot (#1084)

Browse Source
This commit is contained in:
Danny Brown 2019-10-24 15:54:06 -04:00 committed by GitHub
parent 97786b808c
commit 3a12138134
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 34 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
platform/viewer/cypress/integration/common/OHIFStandaloneViewer.spec.js
View File

@ -5,7 +5,7 @@ describe('OHIFStandaloneViewer', () => {
it('loads route with at least 2 rows', () => { it('loads route with at least 2 rows', () => {
cy.screenshot(); cy.screenshot();
cy.percySnapshot(); cy.percyCanvasSnapshot('Study List');
cy.get('#studyListData tr') cy.get('#studyListData tr')
.its('length') .its('length')

2
platform/viewer/cypress/integration/common/OHIFStudyViewer.spec.js
View File

@ -12,7 +12,7 @@ describe('OHIF Study Viewer Page', () => {
it('checks if series thumbnails are being displayed', () => { it('checks if series thumbnails are being displayed', () => {
cy.screenshot(); cy.screenshot();
cy.percySnapshot(); cy.percyCanvasSnapshot('Series Thumbnails');
cy.get('[data-cy="thumbnail-list"]') cy.get('[data-cy="thumbnail-list"]')
.its('length') .its('length')

2
platform/viewer/cypress/integration/pwa/OHIFExtensionMicroscopy.spec.js
View File

@ -22,6 +22,6 @@ describe('OHIF Microscopy Extension', () => {
cy.wait(3000); //Waiting for image to render before taking the snapshot cy.wait(3000); //Waiting for image to render before taking the snapshot
cy.screenshot(); cy.screenshot();
cy.percySnapshot(); cy.percyCanvasSnapshot('Microscopy Extension');
}); });
}); });

2
platform/viewer/cypress/integration/pwa/OHIFExtensionPDF.spec.js
View File

@ -21,6 +21,6 @@ describe('OHIF PDF Extension', () => {
.should('be.eq', 1); .should('be.eq', 1);
cy.screenshot(); cy.screenshot();
cy.percySnapshot(); cy.percyCanvasSnapshot('PDF Extension');
}); });
}); });

2
platform/viewer/cypress/integration/pwa/OHIFExtensionVTK.spec.js
View File

@ -29,7 +29,7 @@ describe('OHIF VTK Extension', () => {
it('checks if VTK buttons are displayed on the toolbar', () => { it('checks if VTK buttons are displayed on the toolbar', () => {
cy.screenshot(); cy.screenshot();
cy.percySnapshot(); cy.percyCanvasSnapshot('VTK Extension');
cy.get('@crosshairsBtn') cy.get('@crosshairsBtn')
.should('be.visible') .should('be.visible')

29
platform/viewer/cypress/support/commands.js
View File

@ -306,3 +306,32 @@ Cypress.Commands.add('isInViewport', element => {
} }
}); });
}); });
/**
* Percy.io Canvas screenshot workaround
*
*/
Cypress.Commands.add('percyCanvasSnapshot', (name, options = {}) => {
function convertCanvas(document) {
document
.querySelectorAll('canvas')
.forEach(selector => canvasToImage(selector));
}
function canvasToImage(selectorOrEl) {
let canvas =
typeof selectorOrEl === 'object'
? selectorOrEl
: document.querySelector(selectorOrEl);
let image = document.createElement('img');
let canvasImageBase64 = canvas.toDataURL();
image.src = canvasImageBase64;
image.style = 'max-width: 100%';
canvas.setAttribute('data-percy-modified', true);
canvas.parentElement.appendChild(image);
canvas.style = 'display: none';
}
cy.percySnapshot(name, { ...options, domTransformation: convertCanvas });
});