othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

useCallback to avoid redeclaring functions

Browse Source
This commit is contained in:
Rodrigo Antinarelli 2020-06-25 14:08:09 -03:00
parent 547e11d877
commit 3dc4cf6cea
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/default/src/ViewerLayout/Header.jsx
View File

@ -1,4 +1,4 @@
import React from 'react'; import React, { useCallback } from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
// TODO: This may fail if package is split from PWA build // TODO: This may fail if package is split from PWA build
@ -11,7 +11,8 @@ function Header({ children }) {
const history = useHistory(); const history = useHistory();
const { show } = useModal(); const { show } = useModal();
const showAboutModal = () => { // TODO: IT SHOULD BE REFACTORED WHEN THE MODAL CONTENT IS DEFINED
const showAboutModal = useCallback(() => {
const modalComponent = () => ( const modalComponent = () => (
<div>{t('AboutModal:OHIF Viewer - About')}</div> <div>{t('AboutModal:OHIF Viewer - About')}</div>
); );
@ -19,9 +20,10 @@ function Header({ children }) {
title: t('AboutModal:OHIF Viewer - About'), title: t('AboutModal:OHIF Viewer - About'),
content: modalComponent, content: modalComponent,
}); });
}; }, [show, t]);
const showPreferencesModal = () => { // TODO: IT SHOULD BE REFACTORED WHEN THE MODAL CONTENT IS DEFINED
const showPreferencesModal = useCallback(() => {
const modalComponent = () => ( const modalComponent = () => (
<div>{t('UserPreferencesModal:User Preferences')}</div> <div>{t('UserPreferencesModal:User Preferences')}</div>
); );
@ -29,18 +31,7 @@ function Header({ children }) {
title: t('UserPreferencesModal:User Preferences'), title: t('UserPreferencesModal:User Preferences'),
content: modalComponent, content: modalComponent,
}); });
}; }, [show, t]);
// const dropdownContent = [
// {
// name: 'Soft tissue',
// value: '400/40',
// },
// { name: 'Lung', value: '1500 / -600' },
// { name: 'Liver', value: '150 / 90' },
// { name: 'Bone', value: '2500 / 480' },
// { name: 'Brain', value: '80 / 40' },
// ]
return ( return (
<NavBar className="justify-between border-b-4 border-black"> <NavBar className="justify-between border-b-4 border-black">