From 4926a9532c89011ef932fad1dbae643806e780a8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pedro=20K=C3=B6hler?= <pedrokohlerbh@gmail.com>
Date: Fri, 11 Apr 2025 13:41:04 -0300
Subject: [PATCH] feat: expose scroll thumbnail into view (#4941)

---
 extensions/default/src/commandsModule.ts | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/extensions/default/src/commandsModule.ts b/extensions/default/src/commandsModule.ts
index c32c8cb9a..668c321f1 100644
--- a/extensions/default/src/commandsModule.ts
+++ b/extensions/default/src/commandsModule.ts
@@ -536,7 +536,11 @@ const commandsModule = ({
       const { activeViewportId, viewports } = viewportGridService.getState();
 
       const activeViewport = viewports.get(activeViewportId);
-      const activeDisplaySetInstanceUID = activeViewport.displaySetInstanceUIDs[0];
+      const activeDisplaySetInstanceUID = activeViewport?.displaySetInstanceUIDs?.[0];
+
+      if (!activeDisplaySetInstanceUID) {
+        return;
+      }
 
       const thumbnailList = document.querySelector('#ohif-thumbnail-list');
 
@@ -544,24 +548,12 @@ const commandsModule = ({
         return;
       }
 
-      const thumbnailListBounds = thumbnailList.getBoundingClientRect();
-
       const thumbnail = document.querySelector(`#thumbnail-${activeDisplaySetInstanceUID}`);
 
       if (!thumbnail) {
         return;
       }
 
-      const thumbnailBounds = thumbnail.getBoundingClientRect();
-
-      // This only handles a vertical thumbnail list.
-      if (
-        thumbnailBounds.top >= thumbnailListBounds.top &&
-        thumbnailBounds.top <= thumbnailListBounds.bottom
-      ) {
-        return;
-      }
-
       thumbnail.scrollIntoView({ behavior: 'smooth' });
     },
 
@@ -651,6 +643,7 @@ const commandsModule = ({
     toggleOneUp: actions.toggleOneUp,
     openDICOMTagViewer: actions.openDICOMTagViewer,
     updateViewportDisplaySet: actions.updateViewportDisplaySet,
+    scrollActiveThumbnailIntoView: actions.scrollActiveThumbnailIntoView,
   };
 
   return {