From 522d2aa764c2dbdb6ed22e7877201b0fb108f07d Mon Sep 17 00:00:00 2001
From: Joe Boccanfuso <109477394+jbocce@users.noreply.github.com>
Date: Tue, 15 Jul 2025 20:09:23 -0400
Subject: [PATCH] fix(TMTV): The TMTV CSV file now has the correct name and
 contents (#5215)

---
 .../PanelROIThresholdExport.tsx               |  1 +
 extensions/tmtv/src/commandsModule.ts         |  4 +-
 .../src/utils/createAndDownloadTMTVReport.js  | 16 ++++++-
 .../SegmentationTable/AddSegmentationRow.tsx  |  1 +
 tests/MPRThenRTOverlayNoHydration.spec.ts     |  3 +-
 tests/MPRThenSEGOverlayNoHydration.spec.ts    |  3 +-
 tests/TMTVCSVReport.spec.ts                   | 45 +++++++++++++++++++
 tests/utils/download.ts                       | 15 +++++++
 tests/utils/locators.ts                       | 11 +++++
 9 files changed, 94 insertions(+), 5 deletions(-)
 create mode 100644 tests/TMTVCSVReport.spec.ts
 create mode 100644 tests/utils/download.ts
 create mode 100644 tests/utils/locators.ts

diff --git a/extensions/tmtv/src/Panels/PanelROIThresholdSegmentation/PanelROIThresholdExport.tsx b/extensions/tmtv/src/Panels/PanelROIThresholdSegmentation/PanelROIThresholdExport.tsx
index cf5e0fd6b..50ff5b6f6 100644
--- a/extensions/tmtv/src/Panels/PanelROIThresholdSegmentation/PanelROIThresholdExport.tsx
+++ b/extensions/tmtv/src/Panels/PanelROIThresholdSegmentation/PanelROIThresholdExport.tsx
@@ -78,6 +78,7 @@ export default function PanelRoiThresholdSegmentation() {
           </div>
           <div className="flex items-center">
             <Button
+              dataCY="exportTmtvCsvReport"
               size="sm"
               variant="ghost"
               className="text-blue-500"
diff --git a/extensions/tmtv/src/commandsModule.ts b/extensions/tmtv/src/commandsModule.ts
index 186390f71..3ddbab2ac 100644
--- a/extensions/tmtv/src/commandsModule.ts
+++ b/extensions/tmtv/src/commandsModule.ts
@@ -362,7 +362,9 @@ const commandsModule = ({ servicesManager, commandsManager, extensionManager }:
         }
 
         const referencedVolume =
-          csTools.utilities.segmentation.getReferenceVolumeForSegmentationVolume(segmentationId);
+          csTools.utilities.segmentation.getReferenceVolumeForSegmentationVolume(
+            labelmapVolume.volumeId
+          );
 
         if (!referencedVolume) {
           report[id] = segReport;
diff --git a/extensions/tmtv/src/utils/createAndDownloadTMTVReport.js b/extensions/tmtv/src/utils/createAndDownloadTMTVReport.js
index 615d384fe..8ef216945 100644
--- a/extensions/tmtv/src/utils/createAndDownloadTMTVReport.js
+++ b/extensions/tmtv/src/utils/createAndDownloadTMTVReport.js
@@ -1,14 +1,26 @@
 export default function createAndDownloadTMTVReport(segReport, additionalReportRows, options = {}) {
   const firstReport = segReport[Object.keys(segReport)[0]];
   const columns = Object.keys(firstReport);
-  const csv = [columns.join(',')];
+  const csv = [
+    columns
+      .map(column =>
+        column.toLowerCase().startsWith('namedstats_') ? column.substring(11) : column
+      )
+      .join(','),
+  ];
 
   Object.values(segReport).forEach(segmentation => {
     const row = [];
     columns.forEach(column => {
       // if it is array then we need to replace , with space to avoid csv parsing error
       row.push(
-        Array.isArray(segmentation[column]) ? segmentation[column].join(' ') : segmentation[column]
+        segmentation[column] && typeof segmentation[column] === 'object'
+          ? Array.isArray(segmentation[column])
+            ? segmentation[column].join(' ')
+            : segmentation[column].value && Array.isArray(segmentation[column].value)
+              ? segmentation[column].value.join(' ')
+              : (segmentation[column].value ?? segmentation[column])
+          : segmentation[column]
       );
     });
     csv.push(row.join(','));
diff --git a/platform/ui-next/src/components/SegmentationTable/AddSegmentationRow.tsx b/platform/ui-next/src/components/SegmentationTable/AddSegmentationRow.tsx
index ea6d213f0..f04f2c0ae 100644
--- a/platform/ui-next/src/components/SegmentationTable/AddSegmentationRow.tsx
+++ b/platform/ui-next/src/components/SegmentationTable/AddSegmentationRow.tsx
@@ -23,6 +23,7 @@ export const AddSegmentationRow: React.FC<{ children?: React.ReactNode }> = ({
 
   return (
     <div
+      data-cy="addSegmentation"
       className={`group ${disabled ? 'pointer-events-none cursor-not-allowed opacity-70' : ''}`}
       onClick={() => !disabled && onSegmentationAdd('')}
     >
diff --git a/tests/MPRThenRTOverlayNoHydration.spec.ts b/tests/MPRThenRTOverlayNoHydration.spec.ts
index 261836e3c..40dc2dd5b 100644
--- a/tests/MPRThenRTOverlayNoHydration.spec.ts
+++ b/tests/MPRThenRTOverlayNoHydration.spec.ts
@@ -1,6 +1,7 @@
 import { test } from 'playwright-test-coverage';
 import { visitStudy, checkForScreenshot, screenShotPaths } from './utils';
 import { assertNumberOfModalityLoadBadges } from './utils/assertions';
+import { viewportLocator } from './utils/locators';
 
 test.beforeEach(async ({ page }) => {
   const studyInstanceUID = '1.3.6.1.4.1.5962.99.1.2968617883.1314880426.1493322302363.3.0';
@@ -24,7 +25,7 @@ test('should launch MPR with unhydrated RTSTRUCT chosen from the data overlay me
   );
 
   // Hover over the middle/sagittal viewport so that the data overlay menu is available.
-  await page.locator('css=div[data-viewportid="mpr-sagittal"]').hover();
+  await viewportLocator({ viewportId: 'mpr-sagittal', page }).hover();
   await page.getByTestId('dataOverlayMenu-mpr-sagittal-btn').click();
   await page.getByTestId('AddSegmentationDataOverlay-mpr-sagittal').click();
   await page.getByText('SELECT A SEGMENTATION').click();
diff --git a/tests/MPRThenSEGOverlayNoHydration.spec.ts b/tests/MPRThenSEGOverlayNoHydration.spec.ts
index edaecd1d5..e7e0e2420 100644
--- a/tests/MPRThenSEGOverlayNoHydration.spec.ts
+++ b/tests/MPRThenSEGOverlayNoHydration.spec.ts
@@ -1,6 +1,7 @@
 import { test } from 'playwright-test-coverage';
 import { visitStudy, checkForScreenshot, screenShotPaths } from './utils';
 import { assertNumberOfModalityLoadBadges } from './utils/assertions';
+import { viewportLocator } from './utils/locators';
 
 test.beforeEach(async ({ page }) => {
   const studyInstanceUID = '1.3.12.2.1107.5.2.32.35162.30000015050317233592200000046';
@@ -25,7 +26,7 @@ test('should launch MPR with unhydrated SEG chosen from the data overlay menu',
   );
 
   // Hover over the middle/sagittal viewport so that the data overlay menu is available.
-  await page.locator('css=div[data-viewportid="mpr-sagittal"]').hover();
+  await viewportLocator({ viewportId: 'mpr-sagittal', page }).hover();
   await page.getByTestId('dataOverlayMenu-mpr-sagittal-btn').click();
   await page.getByTestId('AddSegmentationDataOverlay-mpr-sagittal').click();
   await page.getByText('SELECT A SEGMENTATION').click();
diff --git a/tests/TMTVCSVReport.spec.ts b/tests/TMTVCSVReport.spec.ts
new file mode 100644
index 000000000..3b7701e8e
--- /dev/null
+++ b/tests/TMTVCSVReport.spec.ts
@@ -0,0 +1,45 @@
+import { test, expect } from 'playwright-test-coverage';
+import { visitStudy, simulateNormalizedClickOnElement } from './utils/index';
+import { viewportLocator } from './utils/locators';
+import { downloadAsString } from './utils/download';
+
+test('should create and download the TMTV CSV report correctly', async ({ page }) => {
+  const studyInstanceUID = '1.2.840.113619.2.290.3.3767434740.226.1600859119.501';
+  const mode = 'tmtv';
+  await visitStudy(page, studyInstanceUID, mode, 10000);
+
+  await page.getByTestId('addSegmentation').click();
+  await page.getByTestId('Brush-btn').click();
+
+  await simulateNormalizedClickOnElement({
+    locator: viewportLocator({ viewportId: 'ctAXIAL', page }),
+    normalizedPoint: { x: 0.5, y: 0.5 },
+  });
+
+  await page.waitForTimeout(5000);
+
+  const downloadPromise = page.waitForEvent('download');
+  await page.getByTestId('exportTmtvCsvReport').click();
+  const download = await downloadPromise;
+
+  expect(download.suggestedFilename(), 'Not the correct file name for the TMTV CSV report.').toBe(
+    '202009231_tmtv.csv'
+  );
+
+  const tmtvCSVReportContent = await downloadAsString(download);
+
+  expect(
+    tmtvCSVReportContent,
+    'Expected the file to start with specific column/value headers'
+  ).toMatch(
+    /^id,label,min,max,mean,stdDev,median,skewness,kurtosis,count,maxLPS,minLPS,center,volume,peakValue,peakLPS,lesionGlycolysis,PatientID,PatientName,StudyInstanceUID,SeriesInstanceUID,StudyDate/
+  );
+  expect(tmtvCSVReportContent, 'Expected the patient name to be present').toContain(
+    'Water Phantom'
+  );
+  expect(tmtvCSVReportContent).toContain('Patient ID,202009231');
+  expect(tmtvCSVReportContent).toContain('Study Date,20200923');
+  expect(tmtvCSVReportContent, 'Expected no objects to be output.').not.toContain(
+    '[object Object]'
+  );
+});
diff --git a/tests/utils/download.ts b/tests/utils/download.ts
new file mode 100644
index 000000000..1bc09897c
--- /dev/null
+++ b/tests/utils/download.ts
@@ -0,0 +1,15 @@
+import { Readable } from 'stream';
+
+const _streamToString = async (stream: Readable) => {
+  return new Promise((resolve, reject) => {
+    const chunks = [];
+    stream.on('data', chunk => chunks.push(chunk));
+    stream.on('error', err => reject(err));
+    stream.on('end', () => resolve(Buffer.concat(chunks).toString('utf8')));
+  });
+};
+
+export const downloadAsString = async download => {
+  const stream = await download.createReadStream();
+  return _streamToString(stream);
+};
diff --git a/tests/utils/locators.ts b/tests/utils/locators.ts
new file mode 100644
index 000000000..58cb29cbe
--- /dev/null
+++ b/tests/utils/locators.ts
@@ -0,0 +1,11 @@
+import { Locator, Page } from '@playwright/test';
+
+export const viewportLocator = ({
+  page,
+  viewportId,
+}: {
+  page: Page;
+  viewportId: string;
+}): Locator => {
+  return page.locator(`css=div[data-viewportid="${viewportId}"]`);
+};