othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(touch): For viewport interactions use onPointerDown. (#4572)

Browse Source
This commit is contained in:
Joe Boccanfuso 2024-12-05 20:57:34 -05:00 committed by GitHub
parent ee9593a7e0
commit 6160718fd2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
platform/app/cypress/integration/customization/OHIFDoubleClick.spec.js
View File

@ -18,12 +18,7 @@ describe('OHIF Double Click', () => {
// For whatever reason, with Cypress tests, we have to activate the // For whatever reason, with Cypress tests, we have to activate the
// viewport we are double clicking first. // viewport we are double clicking first.
cy.get('[data-cy="viewport-pane"]') cy.get('[data-cy="viewport-pane"]').eq(i).trigger('click', 'center', {
.eq(i)
.trigger('mousedown', 'center', {
force: true,
})
.trigger('mouseup', 'center', {
force: true, force: true,
}); });

4
platform/ui/src/components/ViewportPane/ViewportPane.tsx
View File

@ -58,7 +58,9 @@ function ViewportPane({
// onInteractionHandler... // onInteractionHandler...
// https://reactjs.org/docs/events.html#mouse-events // https://reactjs.org/docs/events.html#mouse-events
// https://stackoverflow.com/questions/8378243/catch-scrolling-event-on-overflowhidden-element // https://stackoverflow.com/questions/8378243/catch-scrolling-event-on-overflowhidden-element
onMouseDown={onInteractionHandler} // Use onPointerDown so that for the config property activateViewportBeforeInteraction===false,
// a touch drag will activate the viewport as well as apply the tool selected.
onPointerDown={onInteractionHandler}
onDoubleClick={onDoubleClick} onDoubleClick={onDoubleClick}
onClick={onInteractionHandler} onClick={onInteractionHandler}
onScroll={onInteractionHandler} onScroll={onInteractionHandler}