othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

doc: add netlify doc link to contribing.md

Browse Source 
Also update to use this pull request as the referenced example.
This commit is contained in:
Steve Pieper 2018-07-23 18:34:37 -04:00
parent eea430f2e8
commit 701277f2c0
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
docs/contributing.md
View File

@ -19,9 +19,14 @@ We will provide feedback on your pull requests as soon as possible. Following th
OHIF uses [netlify](netlify.com) so that pull requests are autogenerated and available for testing.
For example, [this url](https://deploy-preview-235--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json) allows you to test [pull request 235](https://github.com/OHIF/Viewers/pull/235) using data pulled from Amazon S3.
For example, [this url](https://deploy-preview-237--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json) allows you to test [pull request 237, the request that created this FAQ entry,](https://github.com/OHIF/Viewers/pull/237) using data pulled from Amazon S3.
Replacing the number 235 in the link below with your pull request number should let you test it as well and you can use this link for discussions on github without requiring reviewers to download and build your branch.
Replacing the number 237 in the link below with your pull request number should let you test it as well and you can use this link for discussions on github without requiring reviewers to download and build your branch.
```
https://deploy-preview-235--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json
https://deploy-preview-237--ohif.netlify.com/viewer/?url=https://s3.eu-central-1.amazonaws.com/ohif-viewer/sampleDICOM.json
```
If you have made a documentation change, a link like this will let you preview the gitbook generated by the pull request:
```
https://deploy-preview-237--ohif.netlify.com/contributing.html
```