From 7849699a0d02267868844ccc10e61814cf7fbcbe Mon Sep 17 00:00:00 2001 From: frmdstryr Date: Fri, 13 Jul 2018 09:38:15 -0400 Subject: [PATCH] Fix importStudies dialog when import fails (#223) If an import happens to fail the dialog promise never resolves. This is because `numberOfStudiesFailed` is incremented on error but `numberOfStudiesImported` is not, so the branch to resolve or reject is never taken. --- Packages/ohif-study-list/client/lib/importStudies.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packages/ohif-study-list/client/lib/importStudies.js b/Packages/ohif-study-list/client/lib/importStudies.js index bf807c666..4e034ac4c 100644 --- a/Packages/ohif-study-list/client/lib/importStudies.js +++ b/Packages/ohif-study-list/client/lib/importStudies.js @@ -104,7 +104,7 @@ const importStudiesInternal = (studiesToImport, dialog) => { const { numberOfStudiesImported, numberOfStudiesFailed } = studyImportStatus; dialog.update(numberOfStudiesImported); - if (numberOfStudiesImported === numberOfStudies) { + if ((numberOfStudiesImported + numberOfStudiesFailed) === numberOfStudies) { // The entire import operation is completed, so remove the study import status item Meteor.call('removeStudyImportStatus', studyImportStatus._id);