othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(segmentation): segment bidirectional tool error and show toast notification when no segment is drawn (#5861)

Browse Source
This commit is contained in:
Ghadeer Albattarni 2026-03-04 15:22:10 -05:00 committed by GitHub
parent 6db0bc2d4c
commit 7e10830d58
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 36 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
extensions/cornerstone/src/commandsModule.ts
View File

@ -398,12 +398,31 @@ function commandsModule({
const { segmentationId: targetId, segmentIndex: targetIndex } = targetSegmentation;
// Check if the segment has voxels before computing bidirectional measurement
const uniqueSegmentIndices = cstUtils.segmentation.getUniqueSegmentIndices(targetId);
const hasVoxels = uniqueSegmentIndices.includes(targetIndex);
if (!hasVoxels) {
uiNotificationService.show({
title: i18n.t('SegmentationPanel:Segment Bidirectional'),
message: i18n.t(
'SegmentationPanel:Draw a segment before using bidirectional measurement'
),
type: 'warning',
});
return;
}
// Get bidirectional measurement data
const bidirectionalData = await cstUtils.segmentation.getSegmentLargestBidirectional({
segmentationId: targetId,
segmentIndices: [targetIndex],
});
if (!bidirectionalData.length) {
return;
}
const activeViewportId = viewportGridService.getActiveViewportId();
// Process each bidirectional measurement

7
platform/i18n/src/locales/en-US/SegmentationPanel.json
View File

@ -42,8 +42,7 @@
"Export": "Export",
"CSV Report": "CSV Report",
"DICOM SEG": "DICOM SEG",
"DICOM RTSS": "DICOM RTSS"
,
"DICOM RTSS": "DICOM RTSS",
"Fill contour holes": "Fill contour holes",
"Fill Holes": "Fill Holes",
"Remove Small Contours": "Remove Small Contours",
@ -63,5 +62,7 @@
"New segment name": "New segment name",
"No segmentations available": "No segmentations available",
"Not available on the current viewport": "Not available on the current viewport",
"Add segment to enable this tool": "Add segment to enable this tool"
"Add segment to enable this tool": "Add segment to enable this tool",
"Segment Bidirectional": "Segment Bidirectional",
"Draw a segment before using bidirectional measurement": "Draw a segment before using bidirectional measurement"
}

4
platform/i18n/src/locales/test-LNG/SegmentationPanel.json
View File

@ -62,5 +62,7 @@
"New segment name": "Test New segment name",
"No segmentations available": "Test No segmentations available",
"Not available on the current viewport": "Test Not available on the current viewport",
"Add segment to enable this tool": "Test Add segment to enable this tool"
"Add segment to enable this tool": "Test Add segment to enable this tool",
"Segment Bidirectional": "Test Segment Bidirectional",
"Draw a segment before using bidirectional measurement": "Test Draw a segment before using bidirectional measurement"
}

10
tests/pages/RightPanelPageObject.ts
View File

@ -246,6 +246,16 @@ export class RightPanelPageObject {
},
};
},
get segmentBidirectional() {
const button = page.getByTestId('SegmentBidirectional');
return {
button,
click: async () => {
await button.click();
},
};
},
};
}