othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore: clarify how props are added

Browse Source
This commit is contained in:
dannyrb 2020-02-24 11:28:35 -05:00
parent 298da03e2f
commit 85fed49eb1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
platform/viewer/src/connectedComponents/ToolbarRow.js
View File

@ -29,6 +29,9 @@ class ToolbarRow extends Component {
activeContexts: PropTypes.arrayOf(PropTypes.string).isRequired, activeContexts: PropTypes.arrayOf(PropTypes.string).isRequired,
studies: PropTypes.array, studies: PropTypes.array,
t: PropTypes.func.isRequired, t: PropTypes.func.isRequired,
// NOTE: withDialog, withModal HOCs
dialog: PropTypes.any,
modal: PropTypes.any,
}; };
static defaultProps = { static defaultProps = {
@ -91,9 +94,6 @@ class ToolbarRow extends Component {
}); });
}); });
// });
// });
// TODO: This should come from extensions, instead of being baked in // TODO: This should come from extensions, instead of being baked in
this.buttonGroups.right.unshift({ this.buttonGroups.right.unshift({
value: 'studies', value: 'studies',
@ -237,6 +237,10 @@ function _getButtonComponents(toolbarButtons, activeButtons) {
} }
/** /**
* TODO: DEPRECATE
* This is used exclusively in `extensions/cornerstone/src`
* We have better ways with new UI Services to trigger "builtin" behaviors
*
* A handy way for us to handle different button types. IE. firing commands for * A handy way for us to handle different button types. IE. firing commands for
* buttons, or initiation built in behavior. * buttons, or initiation built in behavior.
* *
@ -288,7 +292,7 @@ function _getVisibleToolbarButtons() {
function _handleBuiltIn(button) { function _handleBuiltIn(button) {
/* TODO: Keep cine button active until its unselected. */ /* TODO: Keep cine button active until its unselected. */
const { dialog, modal, t } = this.props; const { dialog, t } = this.props;
const { dialogId } = this.state; const { dialogId } = this.state;
const { id, options } = button; const { id, options } = button;