othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix eventListener

Browse Source
This commit is contained in:
Rodrigo Antinarelli 2020-06-23 23:40:35 -03:00
parent 9dbbc709f4
commit 9745f06c4c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
platform/ui/src/components/Dropdown/Dropdown.jsx
View File

@ -10,7 +10,7 @@ const Dropdown = ({ titleElement, title, list }) => {
const renderTitleElement = () => { const renderTitleElement = () => {
if (titleElement) { if (titleElement) {
return titleElement; return <>{titleElement}</>;
} }
return ( return (
@ -74,10 +74,10 @@ const Dropdown = ({ titleElement, title, list }) => {
useEffect(() => { useEffect(() => {
document.addEventListener('click', handleClick); document.addEventListener('click', handleClick);
return () => { if (!open) {
document.removeEventListener('click', handleClick); document.removeEventListener('click', handleClick);
}; }
}, []); }, [open]);
return ( return (
<div data-cy="dropdown" ref={element} className="relative"> <div data-cy="dropdown" ref={element} className="relative">
@ -92,12 +92,12 @@ const Dropdown = ({ titleElement, title, list }) => {
Dropdown.propTypes = { Dropdown.propTypes = {
titleElement: PropTypes.node, titleElement: PropTypes.node,
title: PropTypes.string.isRequired, title: PropTypes.string,
/** Items to render in the select's drop down */ /** Items to render in the select's drop down */
list: PropTypes.arrayOf( list: PropTypes.arrayOf(
PropTypes.shape({ PropTypes.shape({
title: PropTypes.string.isRequired, title: PropTypes.string.isRequired,
icon: PropTypes.object, icon: PropTypes.string,
onClick: PropTypes.func, onClick: PropTypes.func,
link: PropTypes.string, link: PropTypes.string,
}) })