From 9a2691a71fe3723bb05cbd148968b64e5d0fa951 Mon Sep 17 00:00:00 2001 From: Dan Rukas Date: Thu, 12 Feb 2026 08:48:05 -0500 Subject: [PATCH] fix(colors): Replaces legacy colors with ui-next colors (#5351) * Update playwright screenshots and fix broken tests. --------- Co-authored-by: Joe Boccanfuso --- .../LogicalContourOperationsOptions.tsx | 2 +- .../OHIFCornerstoneSRTextViewport.tsx | 2 +- .../src/panels/DynamicDataPanel.tsx | 2 +- .../src/panels/WorkflowPanel.tsx | 2 +- .../ViewportImageSliceLoadingIndicator.tsx | 4 +-- .../AccordionGroup/AccordionGroup.tsx | 4 +-- .../DicomUpload/DicomUploadProgress.tsx | 2 +- .../DicomUpload/DicomUploadProgressItem.tsx | 2 +- .../ModalityLoadBadge/ModalityLoadBadge.tsx | 4 +-- .../ViewportOrientationMenu.tsx | 2 +- .../src/panels/PanelMeasurement.tsx | 2 +- .../DataSourceConfigurationComponent.tsx | 2 +- .../DataSourceConfigurationModalComponent.tsx | 19 ++++++---- .../src/DicomTagBrowser/DicomTagBrowser.tsx | 4 +-- .../src/DicomTagBrowser/DicomTagTable.tsx | 14 ++++---- .../default/src/Panels/DataSourceSelector.tsx | 4 +-- .../StudyBrowser/PanelStudyBrowserHeader.tsx | 2 +- .../HeaderPatientInfo/HeaderPatientInfo.tsx | 6 ++-- .../default/src/ViewerLayout/ViewerHeader.tsx | 4 +-- extensions/default/src/utils/Toolbox.tsx | 2 +- .../ViewportOverlay/ViewportOverlay.css | 4 +-- .../src/components/ViewportOverlay/index.tsx | 8 ++--- extensions/dicom-microscopy/src/index.tsx | 4 +-- .../viewports/OHIFCornerstonePdfViewport.tsx | 6 ++-- extensions/tmtv/src/Panels/PanelPetSUV.tsx | 2 +- .../PanelROIThresholdExport.tsx | 3 +- .../ROIThresholdConfiguration.tsx | 2 +- .../src/panels/MultiLabelInput.tsx | 4 +-- .../src/panels/USAnnotationPanel.tsx | 33 +++++++++--------- platform/app/src/routes/Debug.tsx | 4 +-- platform/app/src/routes/index.tsx | 6 ++-- platform/ui-next/src/assets/styles.css | 4 +-- .../ui-next/src/components/Button/Button.tsx | 4 +-- .../src/components/DataRow/DataRow.tsx | 2 +- .../src/components/DateRange/DateRange.tsx | 8 ++--- .../ui-next/src/components/Dialog/Dialog.tsx | 2 +- .../DisplaySetMessageListTooltip.tsx | 4 +-- .../ui-next/src/components/Header/Header.tsx | 6 ++-- .../InvestigationalUseDialog.tsx | 11 +++--- .../LayoutSelector/LayoutSelector.tsx | 4 +-- .../src/components/LineChart/LineChart.tsx | 2 +- .../LoadingIndicatorProgress.tsx | 2 +- .../LoadingIndicatorTotalPercent.tsx | 6 ++-- .../MeasurementTable/MeasurementTable.tsx | 8 ++--- .../ui-next/src/components/NavBar/NavBar.tsx | 2 +- .../components/OHIFDialogs/PresetDialog.tsx | 2 +- .../src/components/OHIFPanels/WindowLevel.tsx | 2 +- .../src/components/OHIFToolbox/ToolboxUI.tsx | 2 +- .../src/components/Onboarding/Onboarding.css | 2 +- .../components/PanelSection/PanelSection.tsx | 2 +- .../ProgressDropdown/ProgressDiscreteBar.tsx | 4 +-- .../ProgressDropdown/ProgressDropdown.tsx | 21 +++++------ .../ProgressDropdown/ProgressItem.tsx | 2 +- .../ProgressDropdown/ProgressItemDetail.tsx | 4 +-- .../ProgressLoadingBar/ProgressLoadingBar.tsx | 4 +-- .../SegmentationTable/AddSegmentationRow.tsx | 2 +- .../SegmentationTable/SegmentStatistics.tsx | 2 +- .../SegmentationCollapsed.tsx | 2 +- .../SegmentationExpanded.tsx | 2 +- .../SegmentationSegments.tsx | 2 +- .../SegmentationTableConfig.tsx | 2 +- .../src/components/SidePanel/SidePanel.tsx | 21 ++++++----- .../components/StudyBrowser/StudyBrowser.tsx | 4 +-- .../StudyBrowserSort/StudyBrowserSort.tsx | 8 ++--- .../StudyBrowserViewOptions.tsx | 4 +-- .../src/components/StudyItem/StudyItem.tsx | 2 +- .../src/components/Thumbnail/Thumbnail.tsx | 20 +++++------ .../ThumbnailList/ThumbnailList.tsx | 4 +-- .../src/components/ToolButton/ToolButton.tsx | 2 +- .../src/components/Tooltip/Tooltip.tsx | 2 +- .../src/components/Viewport/PatientInfo.tsx | 4 +-- .../Viewport/ViewportActionArrows.tsx | 2 +- .../components/Viewport/ViewportActionBar.tsx | 10 +++--- .../Viewport/ViewportActionButton.tsx | 2 +- .../src/components/Viewport/ViewportPane.tsx | 2 +- .../ViewportDialog/ViewportDialog.tsx | 2 +- platform/ui-next/src/tailwind.css | 6 ++-- .../ui-next/src/utils/getToggledClassName.tsx | 4 +-- tests/SRHydrationThenReload.spec.ts | 19 +++++----- .../dicomTagBrowserDisplayedCorrectly.png | Bin 137672 -> 137431 bytes .../scrollBarRenderedProperly.png | Bin 999 -> 997 bytes .../mprPostSEGOverlayNoHydration.png | Bin 277024 -> 287429 bytes .../rtNoHydrationPreMpr.png | Bin 100760 -> 98525 bytes .../segDataOverlayNoHydrationPostMpr.png | Bin 277029 -> 287565 bytes .../srAfterHydration.png | Bin 425351 -> 0 bytes .../srAfterReload.png | Bin 429102 -> 0 bytes tests/utils/screenShotPaths.ts | 4 --- 87 files changed, 201 insertions(+), 204 deletions(-) delete mode 100644 tests/screenshots/chromium/SRHydrationThenReload.spec.ts/srAfterHydration.png delete mode 100644 tests/screenshots/chromium/SRHydrationThenReload.spec.ts/srAfterReload.png diff --git a/extensions/cornerstone-dicom-seg/src/components/LogicalContourOperationsOptions.tsx b/extensions/cornerstone-dicom-seg/src/components/LogicalContourOperationsOptions.tsx index 8f3e625bb..e0abd2ede 100644 --- a/extensions/cornerstone-dicom-seg/src/components/LogicalContourOperationsOptions.tsx +++ b/extensions/cornerstone-dicom-seg/src/components/LogicalContourOperationsOptions.tsx @@ -189,7 +189,7 @@ function LogicalContourOperationOptions() {
{t(operation.label)}
-
+
diff --git a/extensions/cornerstone-dicom-sr/src/components/OHIFCornerstoneSRTextViewport.tsx b/extensions/cornerstone-dicom-sr/src/components/OHIFCornerstoneSRTextViewport.tsx index 78d4929b7..6fd05e2ff 100644 --- a/extensions/cornerstone-dicom-sr/src/components/OHIFCornerstoneSRTextViewport.tsx +++ b/extensions/cornerstone-dicom-sr/src/components/OHIFCornerstoneSRTextViewport.tsx @@ -9,7 +9,7 @@ function OHIFCornerstoneSRTextViewport(props: withAppTypes) { const instance = displaySet.instances[0]; return ( -
+
{/* The root level is always a container */} diff --git a/extensions/cornerstone-dynamic-volume/src/panels/DynamicDataPanel.tsx b/extensions/cornerstone-dynamic-volume/src/panels/DynamicDataPanel.tsx index f3f7a4db9..09e52f920 100644 --- a/extensions/cornerstone-dynamic-volume/src/panels/DynamicDataPanel.tsx +++ b/extensions/cornerstone-dynamic-volume/src/panels/DynamicDataPanel.tsx @@ -5,7 +5,7 @@ function DynamicDataPanel({ servicesManager, commandsManager, tab }: withAppType return ( <>
Workflow
diff --git a/extensions/cornerstone/src/Viewport/Overlays/ViewportImageSliceLoadingIndicator.tsx b/extensions/cornerstone/src/Viewport/Overlays/ViewportImageSliceLoadingIndicator.tsx index 429fea2cb..bb86a0df5 100644 --- a/extensions/cornerstone/src/Viewport/Overlays/ViewportImageSliceLoadingIndicator.tsx +++ b/extensions/cornerstone/src/Viewport/Overlays/ViewportImageSliceLoadingIndicator.tsx @@ -51,7 +51,7 @@ function ViewportImageSliceLoadingIndicator({ viewportData, element }) { <>
-

+

Error Loading Image

An error has occurred.

{error}

@@ -68,7 +68,7 @@ function ViewportImageSliceLoadingIndicator({ viewportData, element }) { // interacting with the mouse, since scrolling should propagate to the viewport underneath
-

Loading...

+

Loading...

); diff --git a/extensions/cornerstone/src/components/AccordionGroup/AccordionGroup.tsx b/extensions/cornerstone/src/components/AccordionGroup/AccordionGroup.tsx index d91ba8834..7c7443231 100644 --- a/extensions/cornerstone/src/components/AccordionGroup/AccordionGroup.tsx +++ b/extensions/cornerstone/src/components/AccordionGroup/AccordionGroup.tsx @@ -91,14 +91,14 @@ function DefaultAccordion(props) { return null; } - if (Boolean(asChild)) { + if (asChild) { return React.cloneElement(props.children, props); } return ( {[...groups.entries()].map(([key, group]) => { diff --git a/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgress.tsx b/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgress.tsx index dd3f4d441..3fc1b0118 100644 --- a/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgress.tsx +++ b/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgress.tsx @@ -276,7 +276,7 @@ function DicomUploadProgress({ const getNumCompletedAndTimeRemainingComponent = (): ReactElement => { return ( -
+
{numFilesCompleted === dicomFileUploaderArr.length ? ( <> {`${dicomFileUploaderArr.length} ${ diff --git a/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgressItem.tsx b/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgressItem.tsx index 4ff3d0078..0ebcff89a 100644 --- a/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgressItem.tsx +++ b/extensions/cornerstone/src/components/DicomUpload/DicomUploadProgressItem.tsx @@ -75,7 +75,7 @@ const DicomUploadProgressItem = memo(
{getStatusIcon()}
-
+
{dicomFileUploader.getFileName()}
diff --git a/extensions/cornerstone/src/components/ModalityLoadBadge/ModalityLoadBadge.tsx b/extensions/cornerstone/src/components/ModalityLoadBadge/ModalityLoadBadge.tsx index 1b51409c5..d8b2fd475 100644 --- a/extensions/cornerstone/src/components/ModalityLoadBadge/ModalityLoadBadge.tsx +++ b/extensions/cornerstone/src/components/ModalityLoadBadge/ModalityLoadBadge.tsx @@ -122,9 +122,9 @@ function ModalityLoadBadge({ viewportId }: { viewportId: string }) { return (
-
+
{statusInfo.type}
diff --git a/extensions/cornerstone/src/components/ViewportOrientationMenu/ViewportOrientationMenu.tsx b/extensions/cornerstone/src/components/ViewportOrientationMenu/ViewportOrientationMenu.tsx index 56dac15b5..8452b7841 100644 --- a/extensions/cornerstone/src/components/ViewportOrientationMenu/ViewportOrientationMenu.tsx +++ b/extensions/cornerstone/src/components/ViewportOrientationMenu/ViewportOrientationMenu.tsx @@ -203,7 +203,7 @@ function ViewportOrientationMenu({
Acquisition
{/* Divider */} -
+