diff --git a/.circleci/config.yml b/.circleci/config.yml index 410cd92dc..4f33734e3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -505,7 +505,7 @@ workflows: - HOLD_FOR_APPROVAL - DOCKER_RELEASE_PUBLISH: requires: - - NPM_PUBLISH + - HOLD_FOR_APPROVAL ### # Unit and E2E tests have already run for PR_CHECKS diff --git a/extensions/cornerstone-dynamic-volume/src/panels/PanelGenerateImage.tsx b/extensions/cornerstone-dynamic-volume/src/panels/PanelGenerateImage.tsx index 163b55eba..8afe95e88 100644 --- a/extensions/cornerstone-dynamic-volume/src/panels/PanelGenerateImage.tsx +++ b/extensions/cornerstone-dynamic-volume/src/panels/PanelGenerateImage.tsx @@ -256,6 +256,9 @@ async function createComputedVolume(dynamicVolumeId, computedVolumeId) { if (!cache.getVolume(computedVolumeId)) { const computedVolume = await volumeLoader.createAndCacheDerivedVolume(dynamicVolumeId, { volumeId: computedVolumeId, + targetBuffer: { + type: 'Float32Array', + }, }); return computedVolume; } diff --git a/platform/ui/src/components/WindowLevel/WindowLevel.tsx b/platform/ui/src/components/WindowLevel/WindowLevel.tsx index 7fd1c390f..53a7258e5 100644 --- a/platform/ui/src/components/WindowLevel/WindowLevel.tsx +++ b/platform/ui/src/components/WindowLevel/WindowLevel.tsx @@ -12,7 +12,6 @@ import { histogramPropType, colormapPropType, } from './types'; -import PanelSection from '../PanelSection'; const convertVOItoVOIRange = voi => { return { @@ -22,21 +21,19 @@ const convertVOItoVOIRange = voi => { }; const WindowLevel = ({ - title, - step, + step = 1, histogram, voi: voiProp, - opacity: opacityProp, - showOpacitySlider, + opacity: opacityProp = 1, + showOpacitySlider = false, colormap, - style, - fillColor, - lineColor, + style = 'polygon', + fillColor = '#3f3f3f', + lineColor = '#707070', containerClassName, onVOIChange, onOpacityChange, }: { - title: string; step: number; histogram: Histogram; voi: VOI; @@ -105,7 +102,6 @@ const WindowLevel = ({ return (
- {/* {title} */}
{range.min} @@ -161,17 +157,7 @@ const WindowLevel = ({ ); }; -WindowLevel.defaultProps = { - step: 1, - opacity: 1, - showOpacitySlider: false, - style: 'polygon', - fillColor: '#3f3f3f', - lineColor: '#707070', -}; - WindowLevel.propTypes = { - title: PropTypes.string, step: PropTypes.number, histogram: histogramPropType.isRequired, voi: voiPropType, diff --git a/platform/ui/src/components/WindowLevel/WindowLevelHistogram.tsx b/platform/ui/src/components/WindowLevel/WindowLevelHistogram.tsx index 987263a96..9e116d358 100644 --- a/platform/ui/src/components/WindowLevel/WindowLevelHistogram.tsx +++ b/platform/ui/src/components/WindowLevel/WindowLevelHistogram.tsx @@ -154,10 +154,10 @@ const WindowLevelHistogram = ({ range, voiRange, histogram, - colormap, - style, - fillColor, - lineColor, + colormap = DEFAULT_COLORMAP, + style = 'polygon', + fillColor = '#3f3f3f', + lineColor = '#707070', }: { range: Range; voiRange: VOIRange; @@ -216,13 +216,6 @@ const WindowLevelHistogram = ({ ); }; -WindowLevelHistogram.defaultProps = { - colormap: DEFAULT_COLORMAP, - style: 'polygon', - fillColor: '#3f3f3f', - lineColor: '#707070', -}; - WindowLevelHistogram.propTypes = { range: rangePropType.isRequired, voiRange: voiRangePropType.isRequired, diff --git a/version.txt b/version.txt index dcd32c18a..ff313b8c2 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -3.8.3 \ No newline at end of file +3.8.4