othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(action-corners): check hideWhenDisabled at both the evaluator and prop levels (#5149)

Browse Source
This commit is contained in:
Ibrahim 2025-06-20 11:26:26 -04:00 committed by GitHub
parent 3f1ea26eba
commit d6d3fa7ef4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
platform/core/src/services/ToolBarService/ToolbarService.ts
View File

@ -310,11 +310,13 @@ export default class ToolbarService extends PubSubService {
typeof props.evaluate === 'function' typeof props.evaluate === 'function'
? props.evaluate({ ...refreshProps, button }) ? props.evaluate({ ...refreshProps, button })
: undefined; : undefined;
// Check hideWhenDisabled at both evaluateProps level and props level
const hideWhenDisabled = evaluateProps?.hideWhenDisabled || props.hideWhenDisabled;
const updatedProps = { const updatedProps = {
...props, ...props,
...evaluated, ...evaluated,
disabled: evaluated?.disabled || false, disabled: evaluated?.disabled || false,
visible: evaluateProps?.hideWhenDisabled && evaluated?.disabled ? false : true, visible: hideWhenDisabled && evaluated?.disabled ? false : true,
className: evaluated?.className || '', className: evaluated?.className || '',
isActive: evaluated?.isActive, // isActive will be undefined for buttons without this prop isActive: evaluated?.isActive, // isActive will be undefined for buttons without this prop
}; };