Add hotkeys config for modes and defaults to core

This commit is contained in:
igoroctaviano 2020-06-29 11:53:46 -03:00
parent aa402183f4
commit db795f3cb0
13 changed files with 182 additions and 23 deletions

View File

@ -1,4 +1,5 @@
import toolbarButtons from './toolbarButtons.js'; import toolbarButtons from './toolbarButtons.js';
import { hotkeys } from '@ohif/core';
export default function mode({ modeConfiguration }) { export default function mode({ modeConfiguration }) {
return { return {
@ -68,6 +69,9 @@ export default function mode({ modeConfiguration }) {
], ],
extensions: ['org.ohif.default', 'org.ohif.cornerstone'], extensions: ['org.ohif.default', 'org.ohif.cornerstone'],
sopClassHandlers: ['org.ohif.default.sopClassHandlerModule.stack'], sopClassHandlers: ['org.ohif.default.sopClassHandlerModule.stack'],
hotkeys: [
...hotkeys.defaults.hotkeyBindings
]
}; };
} }

View File

@ -1,4 +1,5 @@
import toolbarButtons from './toolbarButtons.js'; import toolbarButtons from './toolbarButtons.js';
import { hotkeys } from '@ohif/core';
const ohif = { const ohif = {
layout: 'org.ohif.default.layoutTemplateModule.viewerLayout', layout: 'org.ohif.default.layoutTemplateModule.viewerLayout',
@ -94,6 +95,9 @@ export default function mode({ modeConfiguration }) {
'org.ohif.dicom-sr', 'org.ohif.dicom-sr',
], ],
sopClassHandlers: [ohif.sopClassHandler, dicomsr.sopClassHandler], sopClassHandlers: [ohif.sopClassHandler, dicomsr.sopClassHandler],
hotkeys: [
...hotkeys.defaults.hotkeyBindings
]
}; };
} }

View File

@ -0,0 +1,95 @@
export default [
// ~ Global
{
commandName: 'incrementActiveViewport',
label: 'Next Viewport',
keys: ['right'],
},
{
commandName: 'decrementActiveViewport',
label: 'Previous Viewport',
keys: ['left'],
},
// Supported Keys: https://craig.is/killing/mice
// ~ Cornerstone Extension
{ commandName: 'rotateViewportCW', label: 'Rotate Right', keys: ['r'] },
{ commandName: 'rotateViewportCCW', label: 'Rotate Left', keys: ['l'] },
{ commandName: 'invertViewport', label: 'Invert', keys: ['i'] },
{
commandName: 'flipViewportVertical',
label: 'Flip Horizontally',
keys: ['h'],
},
{
commandName: 'flipViewportHorizontal',
label: 'Flip Vertically',
keys: ['v'],
},
{ commandName: 'scaleUpViewport', label: 'Zoom In', keys: ['+'] },
{ commandName: 'scaleDownViewport', label: 'Zoom Out', keys: ['-'] },
{ commandName: 'fitViewportToWindow', label: 'Zoom to Fit', keys: ['='] },
{ commandName: 'resetViewport', label: 'Reset', keys: ['space'] },
// clearAnnotations
{ commandName: 'nextImage', label: 'Next Image', keys: ['down'] },
{ commandName: 'previousImage', label: 'Previous Image', keys: ['up'] },
// firstImage
// lastImage
{
commandName: 'previousViewportDisplaySet',
label: 'Previous Series',
keys: ['pagedown'],
},
{
commandName: 'nextViewportDisplaySet',
label: 'Next Series',
keys: ['pageup'],
},
// ~ Cornerstone Tools
{ commandName: 'setZoomTool', label: 'Zoom', keys: ['z'] },
// ~ Window level presets
{
commandName: 'windowLevelPreset1',
label: 'W/L Preset 1',
keys: ['1'],
},
{
commandName: 'windowLevelPreset2',
label: 'W/L Preset 2',
keys: ['2'],
},
{
commandName: 'windowLevelPreset3',
label: 'W/L Preset 3',
keys: ['3'],
},
{
commandName: 'windowLevelPreset4',
label: 'W/L Preset 4',
keys: ['4'],
},
{
commandName: 'windowLevelPreset5',
label: 'W/L Preset 5',
keys: ['5'],
},
{
commandName: 'windowLevelPreset6',
label: 'W/L Preset 6',
keys: ['6'],
},
{
commandName: 'windowLevelPreset7',
label: 'W/L Preset 7',
keys: ['7'],
},
{
commandName: 'windowLevelPreset8',
label: 'W/L Preset 8',
keys: ['8'],
},
{
commandName: 'windowLevelPreset9',
label: 'W/L Preset 9',
keys: ['9'],
},
];

View File

@ -0,0 +1,2 @@
import hotkeyBindings from './hotkeyBindings';
export { hotkeyBindings };

View File

@ -20,7 +20,8 @@ import studies from './studies/';
import ui from './ui'; import ui from './ui';
import user from './user.js'; import user from './user.js';
import { ViewModelProvider, useViewModel } from './ViewModelContext'; import { ViewModelProvider, useViewModel } from './ViewModelContext';
import utils, { hotkeys } from './utils/'; import utils from './utils/';
import { hotkeyBindings } from './defaults';
import { import {
UIDialogService, UIDialogService,
@ -37,6 +38,11 @@ import {
import IWebApiDataSource from './DataSources/IWebApiDataSource'; import IWebApiDataSource from './DataSources/IWebApiDataSource';
const hotkeys = {
...utils.hotkeys,
defaults: { hotkeyBindings }
};
const OHIF = { const OHIF = {
MODULE_TYPES, MODULE_TYPES,
// //

View File

@ -30,7 +30,7 @@ const Router = JSON.parse(process.env.USE_HASH_ROUTER)
? HashRouter ? HashRouter
: BrowserRouter; : BrowserRouter;
let commandsManager, extensionManager, servicesManager; let commandsManager, extensionManager, servicesManager, hotkeysManager;
function App({ config, defaultExtensions }) { function App({ config, defaultExtensions }) {
const init = appInit(config, defaultExtensions); const init = appInit(config, defaultExtensions);
@ -39,17 +39,19 @@ function App({ config, defaultExtensions }) {
commandsManager = init.commandsManager; commandsManager = init.commandsManager;
extensionManager = init.extensionManager; extensionManager = init.extensionManager;
servicesManager = init.servicesManager; servicesManager = init.servicesManager;
hotkeysManager = init.hotkeysManager;
// Set appConfig // Set appConfig
const appConfigState = init.appConfig; const appConfigState = init.appConfig;
const { routerBasename, modes, dataSources } = appConfigState; const { routerBasename, modes, dataSources } = appConfigState;
// Use config to create routes // Use config to create routes
const appRoutes = createRoutes( const appRoutes = createRoutes({
modes, modes,
dataSources, dataSources,
extensionManager, extensionManager,
servicesManager servicesManager,
); hotkeysManager
});
const { const {
UIDialogService, UIDialogService,
UIModalService, UIModalService,

View File

@ -2,7 +2,7 @@ import {
CommandsManager, CommandsManager,
ExtensionManager, ExtensionManager,
ServicesManager, ServicesManager,
// HotkeysManager, HotkeysManager,
UINotificationService, UINotificationService,
UIModalService, UIModalService,
UIDialogService, UIDialogService,
@ -31,13 +31,14 @@ function appInit(appConfigOrFunc, defaultExtensions) {
// TODO: Wire this up to Rodrigo's basic Context "ContextService" // TODO: Wire this up to Rodrigo's basic Context "ContextService"
const commandsManagerConfig = { const commandsManagerConfig = {
/** Used by commands to inject `viewports` from "redux" */ /** Used by commands to inject `viewports` from "redux" */
getAppState: () => {}, getAppState: () => { },
/** Used by commands to determine active context */ /** Used by commands to determine active context */
getActiveContexts: () => ['VIEWER', 'ACTIVE_VIEWPORT::CORNERSTONE'], getActiveContexts: () => ['VIEWER', 'ACTIVE_VIEWPORT::CORNERSTONE'],
}; };
const commandsManager = new CommandsManager(commandsManagerConfig);
const servicesManager = new ServicesManager(); const servicesManager = new ServicesManager();
// const hotkeysManager = new HotkeysManager(commandsManager, servicesManager); const commandsManager = new CommandsManager(commandsManagerConfig);
const hotkeysManager = new HotkeysManager(commandsManager, servicesManager);
const extensionManager = new ExtensionManager({ const extensionManager = new ExtensionManager({
commandsManager, commandsManager,
servicesManager, servicesManager,
@ -64,7 +65,6 @@ function appInit(appConfigOrFunc, defaultExtensions) {
appConfig.dataSources appConfig.dataSources
); );
// TODO: Init global hotkeys, or the hotkeys manager?
// TODO: We no longer use `utils.addServer` // TODO: We no longer use `utils.addServer`
// TODO: We no longer init webWorkers at app level // TODO: We no longer init webWorkers at app level
// TODO: We no longer init the user Manager // TODO: We no longer init the user Manager
@ -80,6 +80,7 @@ function appInit(appConfigOrFunc, defaultExtensions) {
commandsManager, commandsManager,
extensionManager, extensionManager,
servicesManager, servicesManager,
hotkeysManager
}; };
} }

View File

@ -6,6 +6,6 @@ import { useLocation } from 'react-router-dom';
* *
* @name useQuery * @name useQuery
*/ */
export default function() { export default function () {
return new URLSearchParams(useLocation().search); return new URLSearchParams(useLocation().search);
} }

View File

@ -1,4 +1,5 @@
import useDebounce from './useDebounce.js'; import useDebounce from './useDebounce.js';
import useQuery from './useQuery.js'; import useQuery from './useQuery.js';
import useHotkeys from './useHotkeys.js';
export { useDebounce, useQuery }; export { useDebounce, useQuery, useHotkeys };

View File

@ -0,0 +1,31 @@
import { useEffect, useState } from 'react';
/**
* @param {Object} manager HotkeysManager instance
* @param {Object} hotkeys hotkey bindings
* @param {Object} defaultHotkeys default hotkey bindings
*/
const useHotkeys = (manager, hotkeys, defaultHotkeys) => {
const [isLoaded, setIsLoaded] = useState(false);
useEffect(() => {
if (!hotkeys) {
console.warn('[hotkeys] No bindings defined for hotkeys hook!');
return;
}
console.debug('[hotkeys] Setting up hotkeys...');
manager.setDefaultHotKeys(defaultHotkeys || hotkeys);
manager.setHotkeys(hotkeys);
setIsLoaded(true);
return () => {
console.debug('[hotkeys] Removing hotkeys...');
manager.destroy();
};
}, [manager, hotkeys, defaultHotkeys]);
return isLoaded;
}
export default useHotkeys;

View File

@ -5,7 +5,7 @@ import PropTypes from 'prop-types';
import { DicomMetadataStore } from '@ohif/core'; import { DicomMetadataStore } from '@ohif/core';
import { DragAndDropProvider, ImageViewerProvider } from '@ohif/ui'; import { DragAndDropProvider, ImageViewerProvider } from '@ohif/ui';
// //
import { useQuery } from '@hooks'; import { useQuery, useHotkeys } from '@hooks';
import ViewportGrid from '@components/ViewportGrid'; import ViewportGrid from '@components/ViewportGrid';
import Compose from './Compose'; import Compose from './Compose';
@ -15,7 +15,9 @@ export default function ModeRoute({
dataSourceName, dataSourceName,
extensionManager, extensionManager,
servicesManager, servicesManager,
hotkeysManager
}) { }) {
const isHotkeysLoaded = useHotkeys(hotkeysManager, mode.hotkeys);
// Parse route params/querystring // Parse route params/querystring
const query = useQuery(); const query = useQuery();
const queryStudyInstanceUIDs = query.get('StudyInstanceUIDs'); const queryStudyInstanceUIDs = query.get('StudyInstanceUIDs');
@ -83,6 +85,8 @@ export default function ModeRoute({
route, route,
servicesManager, servicesManager,
extensionManager, extensionManager,
hotkeysManager,
isHotkeysLoaded
]); ]);
// This queries for series, but... What does it do with them? // This queries for series, but... What does it do with them?

View File

@ -22,12 +22,13 @@ import { ViewModelProvider } from '@ohif/core';
/:modeId/:modeRoute/?queryParameters=example /:modeId/:modeRoute/?queryParameters=example
*/ */
export default function buildModeRoutes( export default function buildModeRoutes({
modes, modes,
dataSources, dataSources,
extensionManager, extensionManager,
servicesManager servicesManager,
) { hotkeysManager
}) {
const routes = []; const routes = [];
// const dataSources = Object.keys(extensionManager.dataSourceMap).map(a => // const dataSources = Object.keys(extensionManager.dataSourceMap).map(a =>
@ -58,6 +59,7 @@ export default function buildModeRoutes(
dataSourceName={dataSourceName} dataSourceName={dataSourceName}
extensionManager={extensionManager} extensionManager={extensionManager}
servicesManager={servicesManager} servicesManager={servicesManager}
hotkeysManager={hotkeysManager}
/> />
</ViewModelProvider> </ViewModelProvider>
); );
@ -83,6 +85,7 @@ export default function buildModeRoutes(
dataSourceName={defaultDataSourceName} dataSourceName={defaultDataSourceName}
extensionManager={extensionManager} extensionManager={extensionManager}
servicesManager={servicesManager} servicesManager={servicesManager}
hotkeysManager={hotkeysManager}
/> />
</ViewModelProvider> </ViewModelProvider>
); );

View File

@ -21,19 +21,25 @@ const bakedInRoutes = [
{ component: NotFound }, { component: NotFound },
]; ];
const createRoutes = ( const createRoutes = ({
modes, modes,
dataSources, dataSources,
extensionManager, extensionManager,
servicesManager servicesManager,
) => { hotkeysManager
const routes = }) => {
buildModeRoutes(modes, dataSources, extensionManager, servicesManager) || const routes = buildModeRoutes({
[]; modes,
dataSources,
extensionManager,
servicesManager,
hotkeysManager
}) || [];
const allRoutes = [...routes, ...bakedInRoutes]; const allRoutes = [...routes, ...bakedInRoutes];
console.log( console.log(
'Creating Routes: ', 'Creating Routes:',
modes, modes,
dataSources, dataSources,
routes, routes,