fix(local): should use dicomlocal for localbasic (#3397)
* fix(local): should use dicomlocal for localbasic * chore(github): styling for issues forms * try to fix netlify * apply review comments * apply review comments
This commit is contained in:
parent
dab6db3244
commit
e055f25ea6
1
.github/FUNDING.yml
vendored
Normal file
1
.github/FUNDING.yml
vendored
Normal file
@ -0,0 +1 @@
|
|||||||
|
custom: https://giving.massgeneral.org/ohif
|
||||||
33
.github/ISSUE_TEMPLATE/---bug-report.md
vendored
33
.github/ISSUE_TEMPLATE/---bug-report.md
vendored
@ -1,33 +0,0 @@
|
|||||||
---
|
|
||||||
name: "\U0001F41B Bug report"
|
|
||||||
about: Create a report to help us improve
|
|
||||||
title: ''
|
|
||||||
labels: 'Community: Report :bug:, Awaiting Reproduction, Triage :white_flag:'
|
|
||||||
assignees: ''
|
|
||||||
---
|
|
||||||
|
|
||||||
> **Before Creating an issue**
|
|
||||||
>
|
|
||||||
> - Are you running the latest version?
|
|
||||||
> - Are you reporting to the correct repository?
|
|
||||||
> - Did you search existing issues?
|
|
||||||
|
|
||||||
## Bug Report
|
|
||||||
|
|
||||||
### Describe the Bug
|
|
||||||
|
|
||||||
_A clear and concise description of what the bug is._
|
|
||||||
|
|
||||||
### What steps can we follow to reproduce the bug?
|
|
||||||
|
|
||||||
1. First step
|
|
||||||
2. Second step
|
|
||||||
3. ...
|
|
||||||
|
|
||||||
```js
|
|
||||||
Please use code blocks to show formatted errors or code snippets
|
|
||||||
```
|
|
||||||
|
|
||||||
> :warning: Reports we cannot reproduce are at risk of being marked stale and
|
|
||||||
> closed. The more information you can provide, the more likely we are to look
|
|
||||||
> into and address your issue.
|
|
||||||
25
.github/ISSUE_TEMPLATE/---feature-request.md
vendored
25
.github/ISSUE_TEMPLATE/---feature-request.md
vendored
@ -1,25 +0,0 @@
|
|||||||
---
|
|
||||||
name: "\U0001F680 Feature request"
|
|
||||||
about: Suggest an idea for this project
|
|
||||||
title: ''
|
|
||||||
labels: 'Community: Request :hand:, Triage :white_flag:'
|
|
||||||
assignees: ''
|
|
||||||
---
|
|
||||||
|
|
||||||
> :hand: Many people requests features. Tell us why yours is important to the
|
|
||||||
> community. How does it add value? Why _this feature_?
|
|
||||||
>
|
|
||||||
> Is your request very specific to your needs? Consider
|
|
||||||
> [contributing it](https://docs.ohif.org/contributing.html) yourself! Or reach
|
|
||||||
> out to a community member that offers
|
|
||||||
> [consulting services](https://docs.ohif.org/help.html#paid--commercial).
|
|
||||||
|
|
||||||
## Request
|
|
||||||
|
|
||||||
**What feature or change would you like to see made?**
|
|
||||||
|
|
||||||
...
|
|
||||||
|
|
||||||
**Why should we prioritize this feature?**
|
|
||||||
|
|
||||||
...
|
|
||||||
18
.github/ISSUE_TEMPLATE/---support-question.md
vendored
18
.github/ISSUE_TEMPLATE/---support-question.md
vendored
@ -1,18 +0,0 @@
|
|||||||
---
|
|
||||||
name: "\U0001F917 Support Question"
|
|
||||||
about: "I have a question \U0001F4AC"
|
|
||||||
title: ''
|
|
||||||
labels: 'Community: Question :question:, Triage :white_flag:'
|
|
||||||
assignees: ''
|
|
||||||
---
|
|
||||||
|
|
||||||
> :hand: We are a small team with limited resources. Your question is much more
|
|
||||||
> likely to be answered if it is
|
|
||||||
> [a good question](https://stackoverflow.com/help/how-to-ask)
|
|
||||||
|
|
||||||
**Description**
|
|
||||||
|
|
||||||
Questions can often be answered by our documentation. Unable to find an answer
|
|
||||||
in our docs? We'll try to help. In the meantime, if you answer your own
|
|
||||||
question, please respond with the answer here so that others may benefit as
|
|
||||||
well. Better yet, open a PR to expand our docs ^\_^
|
|
||||||
86
.github/ISSUE_TEMPLATE/bug-report.yml
vendored
Normal file
86
.github/ISSUE_TEMPLATE/bug-report.yml
vendored
Normal file
@ -0,0 +1,86 @@
|
|||||||
|
name: 'Bug report'
|
||||||
|
description: Create a report to help us improve
|
||||||
|
title: '[Bug] '
|
||||||
|
labels: ['Community: Report :bug:', 'Awaiting Reproduction']
|
||||||
|
|
||||||
|
body:
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: |
|
||||||
|
👋 Hello, and thank you for contributing to our project! Your support is greatly appreciated.
|
||||||
|
|
||||||
|
🔍 Before proceeding, please make sure to read our [Rules of Conduct](https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md) and familiarize yourself with our [development process](https://v3-docs.ohif.org/development/our-process).
|
||||||
|
|
||||||
|
❓ If you're here to seek general support or ask a question, we encourage you to visit our [community discussion board](https://community.ohif.org/)
|
||||||
|
|
||||||
|
🐞 For bug reports, please complete the following template in as much detail as possible. This will help us reproduce and address the issue efficiently.
|
||||||
|
|
||||||
|
🧪 Finally, ensure that you're using the latest version of the software and check if your issue has already been reported to avoid duplicates.
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
id: bug_description
|
||||||
|
attributes:
|
||||||
|
label: Describe the Bug
|
||||||
|
description: 'A clear and concise description of what the bug is.'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
id: reproduction_steps
|
||||||
|
attributes:
|
||||||
|
label: Steps to Reproduce
|
||||||
|
description: 'Please describe the steps to reproduce the issue.'
|
||||||
|
placeholder: "1. First step\n2. Second step\n3. ..."
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
id: current_behavior
|
||||||
|
attributes:
|
||||||
|
label: The current behavior
|
||||||
|
description:
|
||||||
|
'A clear and concise description of what happens instead of the expected
|
||||||
|
behavior.'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
id: expected_behavior
|
||||||
|
attributes:
|
||||||
|
label: The expected behavior
|
||||||
|
description:
|
||||||
|
'A clear and concise description of what you expected to happen.'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: input
|
||||||
|
id: os
|
||||||
|
attributes:
|
||||||
|
label: 'OS'
|
||||||
|
description: 'Your operating system.'
|
||||||
|
placeholder: 'e.g., Windows 10, macOS 10.15.4'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
- type: input
|
||||||
|
id: node-version
|
||||||
|
attributes:
|
||||||
|
label: 'Node version'
|
||||||
|
description: 'Your Node.js version.'
|
||||||
|
placeholder: 'e.g., 16.14.0'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
- type: input
|
||||||
|
id: browser
|
||||||
|
attributes:
|
||||||
|
label: 'Browser'
|
||||||
|
description: 'Your browser.'
|
||||||
|
placeholder: 'e.g., Chrome 83.0.4103.116, Firefox 77.0.1, Safari 13.1.1'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: >
|
||||||
|
> :warning: Reports we cannot reproduce are at risk of being marked
|
||||||
|
stale and > closed. The more information you can provide, the more
|
||||||
|
likely we are to look > into and address your issue.
|
||||||
5
.github/ISSUE_TEMPLATE/config.yml
vendored
Normal file
5
.github/ISSUE_TEMPLATE/config.yml
vendored
Normal file
@ -0,0 +1,5 @@
|
|||||||
|
blank_issues_enabled: false
|
||||||
|
contact_links:
|
||||||
|
- name: 🤗 Support Question
|
||||||
|
url: https://community.ohif.org/
|
||||||
|
about: Please use our forum if you have questions or need help.
|
||||||
36
.github/ISSUE_TEMPLATE/feature-request.yml
vendored
Normal file
36
.github/ISSUE_TEMPLATE/feature-request.yml
vendored
Normal file
@ -0,0 +1,36 @@
|
|||||||
|
name: Feature request
|
||||||
|
description: Create a feature request
|
||||||
|
labels: ['Community: Request :hand:']
|
||||||
|
title: '[Feature Request] '
|
||||||
|
body:
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: |
|
||||||
|
👋 Hello and thank you for your interest in our project!
|
||||||
|
|
||||||
|
🔍 Before you proceed, please read our [Rules of Conduct](https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md).
|
||||||
|
|
||||||
|
🚀 If your request is specific to your needs, consider contributing it yourself! Read our [contributing guides](https://v3-docs.ohif.org/development/contributing) to get started.
|
||||||
|
|
||||||
|
🖊️ Please provide as much detail as possible for your feature request. Mock-up screenshots, workflow or logic flow diagrams are very helpful. Discuss how your requested feature would interact with existing features.
|
||||||
|
|
||||||
|
⏱️ Lastly, tell us why we should prioritize your feature. What impact would it have?
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: 'What feature or change would you like to see made?'
|
||||||
|
description:
|
||||||
|
'Please include as much detail as possible including possibly mock up
|
||||||
|
screen shots, workflow or logic flow diagrams etc.'
|
||||||
|
placeholder: '...'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: 'Why should we prioritize this feature?'
|
||||||
|
description:
|
||||||
|
'Discuss if and how the requested feature interacts with existing
|
||||||
|
features.'
|
||||||
|
placeholder: '...'
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
95
.github/pull_request_template.md
vendored
95
.github/pull_request_template.md
vendored
@ -1,14 +1,91 @@
|
|||||||
### PR Checklist
|
<!-- Do Not Delete This! pr_template -->
|
||||||
|
<!-- Please read our Rules of Conduct: https://github.com/OHIF/Viewers/blob/master/CODE_OF_CONDUCT.md -->
|
||||||
- [ ] Brief description of changes
|
<!-- 🕮 Read our guide about our Contributing Guide here https://v3-docs.ohif.org/development/contributing -->
|
||||||
- [ ] Links to any relevant issues
|
<!-- :hand: Thank you for starting this amazing contribution! -->
|
||||||
- [ ] Required status checks are passing
|
|
||||||
- [ ] User cases if changes impact the user's experience
|
|
||||||
- [ ] `@mention` a maintainer to request a review
|
|
||||||
|
|
||||||
<!--
|
<!--
|
||||||
Links
|
⚠️⚠️ Please make sure the checklist section below is complete before submitting your PR.
|
||||||
-->
|
To complete the checklist, add an 'x' to each item: [] -> [x]
|
||||||
|
(PRs that do not have all the checkboxes marked will not be approved)
|
||||||
|
-->
|
||||||
|
|
||||||
|
### Context
|
||||||
|
|
||||||
|
<!--
|
||||||
|
Provide a clear explanation of the reasoning behind this change, such as:
|
||||||
|
- A link to the issue being addressed, using the format "Fixes #ISSUE_NUMBER"
|
||||||
|
- An image showing the issue or problem being addressed (if not already in the issue)
|
||||||
|
- Error logs or callStacks to help with the understanding of the problem (if not already in the issue)
|
||||||
|
-->
|
||||||
|
|
||||||
|
### Changes & Results
|
||||||
|
|
||||||
|
<!--
|
||||||
|
List all the changes that have been done, such as:
|
||||||
|
- Add new components
|
||||||
|
- Remove old components
|
||||||
|
- Update dependencies
|
||||||
|
|
||||||
|
What are the effects of this change?
|
||||||
|
- Before vs After
|
||||||
|
- Screenshots / GIFs / Videos
|
||||||
|
-->
|
||||||
|
|
||||||
|
### Testing
|
||||||
|
|
||||||
|
<!--
|
||||||
|
Describe how we can test your changes.
|
||||||
|
- open a URL
|
||||||
|
- visit a page
|
||||||
|
- click on a button
|
||||||
|
- etc.
|
||||||
|
-->
|
||||||
|
|
||||||
|
### Checklist
|
||||||
|
|
||||||
|
#### PR
|
||||||
|
|
||||||
|
<!--
|
||||||
|
https://semantic-release.gitbook.io/semantic-release/#how-does-it-work
|
||||||
|
|
||||||
|
Examples:
|
||||||
|
Please note the letter casing in the provided examples (upper or lower).
|
||||||
|
|
||||||
|
- feat(MeasurementService): add ...
|
||||||
|
- fix(Toolbar): fix ...
|
||||||
|
- docs(Readme): update ...
|
||||||
|
- style(Whitespace): fix ...
|
||||||
|
- refactor(ExtensionManager): ...
|
||||||
|
- test(HangingProtocol): Add test ...
|
||||||
|
- chore(git): update ...
|
||||||
|
- perf(VolumeLoader): ...
|
||||||
|
|
||||||
|
You don't need to have each commit within the Pull Request follow the rule,
|
||||||
|
but the PR title must comply with it, as it will be used as the commit message
|
||||||
|
after the commits are squashed.
|
||||||
|
-->
|
||||||
|
|
||||||
|
- [] My Pull Request title is descriptive, accurate and follows the
|
||||||
|
semantic-release format and guidelines.
|
||||||
|
|
||||||
|
#### Code
|
||||||
|
|
||||||
|
- [] My code has been well-documented (function documentation, inline comments,
|
||||||
|
etc.)
|
||||||
|
|
||||||
|
#### Public Documentation Updates
|
||||||
|
|
||||||
|
<!-- https://v3-docs.ohif.org/ -->
|
||||||
|
|
||||||
|
- [] The documentation page has been updated as necessary for any public API
|
||||||
|
additions or removals.
|
||||||
|
|
||||||
|
#### Tested Environment
|
||||||
|
|
||||||
|
- [] OS: <!--[e.g. Windows 10, macOS 10.15.4]-->
|
||||||
|
- [] Node version: <!--[e.g. 16.14.0]-->
|
||||||
|
- [] Browser:
|
||||||
|
<!--[e.g. Chrome 83.0.4103.116, Firefox 77.0.1, Safari 13.1.1]-->
|
||||||
|
|
||||||
<!-- prettier-ignore-start -->
|
<!-- prettier-ignore-start -->
|
||||||
[blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/
|
[blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/
|
||||||
|
|||||||
14
.github/stale.yml
vendored
14
.github/stale.yml
vendored
@ -2,25 +2,19 @@
|
|||||||
# https://github.com/apps/stale
|
# https://github.com/apps/stale
|
||||||
#
|
#
|
||||||
# Number of days of inactivity before an issue becomes stale
|
# Number of days of inactivity before an issue becomes stale
|
||||||
daysUntilStale: 21
|
daysUntilStale: 180
|
||||||
# Number of days of inactivity before a stale issue is closed
|
# Number of days of inactivity before a stale issue is closed
|
||||||
daysUntilClose: 7
|
daysUntilClose: 60
|
||||||
# Issues with these labels will never be considered stale
|
# Issues with these labels will never be considered stale
|
||||||
exemptLabels:
|
exemptLabels:
|
||||||
- 'Story :raised_hands:'
|
|
||||||
- 'Bug: Verified :bug:'
|
- 'Bug: Verified :bug:'
|
||||||
- 'Task: CI/Tooling :robot:'
|
|
||||||
- 'Task: Docs 📖'
|
|
||||||
- 'Task: Docs :book:'
|
|
||||||
- 'Task: Refactor :hammer_and_wrench:'
|
|
||||||
- 'Task: Tests :microscope:'
|
|
||||||
- 'PR: Awaiting Review 👀'
|
- 'PR: Awaiting Review 👀'
|
||||||
- 'Triage :white_flag:'
|
|
||||||
- 'Extension: Discussion'
|
|
||||||
- 'Announcement 🎉'
|
- 'Announcement 🎉'
|
||||||
- 'IDC:priority'
|
- 'IDC:priority'
|
||||||
- 'IDC:candidate'
|
- 'IDC:candidate'
|
||||||
- 'IDC:collaboration'
|
- 'IDC:collaboration'
|
||||||
|
- 'Community: Request :hand:'
|
||||||
|
- 'Community: Report :bug:'
|
||||||
# Label to use when marking an issue as stale
|
# Label to use when marking an issue as stale
|
||||||
staleLabel: 'Stale :baguette_bread:'
|
staleLabel: 'Stale :baguette_bread:'
|
||||||
# Comment to post when marking an issue as stale. Set to `false` to disable
|
# Comment to post when marking an issue as stale. Set to `false` to disable
|
||||||
|
|||||||
@ -194,7 +194,7 @@ function modeFactory() {
|
|||||||
return {
|
return {
|
||||||
id: ohif.layout,
|
id: ohif.layout,
|
||||||
props: {
|
props: {
|
||||||
leftPanels: [tracked.thumbnailList],
|
// leftPanels: [tracked.thumbnailList],
|
||||||
rightPanels: [dicomSeg.panel, tracked.measurements],
|
rightPanels: [dicomSeg.panel, tracked.measurements],
|
||||||
rightPanelDefaultClosed: true,
|
rightPanelDefaultClosed: true,
|
||||||
viewports: [
|
viewports: [
|
||||||
|
|||||||
@ -8,7 +8,7 @@
|
|||||||
# managed by CircleCI and deployed to our Google Hosting
|
# managed by CircleCI and deployed to our Google Hosting
|
||||||
#
|
#
|
||||||
|
|
||||||
#[build]
|
[build]
|
||||||
ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../ui/ ../core/ ../i18n/"
|
ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../ui/ ../core/ ../i18n/"
|
||||||
|
|
||||||
# NODE_VERSION in root `.nvmrc` takes priority
|
# NODE_VERSION in root `.nvmrc` takes priority
|
||||||
|
|||||||
@ -23,7 +23,7 @@ const bakedInRoutes = [
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
path: '/localbasic',
|
path: '/localbasic',
|
||||||
children: Local.bind(null, { modePath: 'viewer' }),
|
children: Local.bind(null, { modePath: 'viewer/dicomlocal' }),
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
|
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user