diff --git a/extensions/default/src/DicomWebDataSource/index.js b/extensions/default/src/DicomWebDataSource/index.js
index 93a7b1b2f..e1b1a5f3a 100644
--- a/extensions/default/src/DicomWebDataSource/index.js
+++ b/extensions/default/src/DicomWebDataSource/index.js
@@ -10,7 +10,10 @@ import { DicomMetadataStore, IWebApiDataSource, utils } from '@ohif/core';
import getImageId from './utils/getImageId';
import * as dcmjs from 'dcmjs';
-import { retrieveStudyMetadata } from './retrieveStudyMetadata.js';
+import {
+ retrieveStudyMetadata,
+ deleteStudyMetadataPromise,
+} from './retrieveStudyMetadata.js';
const { DicomMetaDictionary, DicomDict } = dcmjs.data;
@@ -187,6 +190,7 @@ function createDicomWebApi(dicomWebConfig) {
storeInstances(instances);
});
},
+ deleteStudyMetadataPromise,
getImageIdsForDisplaySet(displaySet) {
const images = displaySet.images;
const imageIds = [];
diff --git a/extensions/measurement-tracking/src/panels/PanelMeasurementTableTracking/index.js b/extensions/measurement-tracking/src/panels/PanelMeasurementTableTracking/index.js
index 10184832a..b7cf5ae8f 100644
--- a/extensions/measurement-tracking/src/panels/PanelMeasurementTableTracking/index.js
+++ b/extensions/measurement-tracking/src/panels/PanelMeasurementTableTracking/index.js
@@ -24,7 +24,7 @@ function PanelMeasurementTableTracking({ servicesManager, extensionManager }) {
measurementChangeTimestamp,
200
);
- const { MeasurementService } = servicesManager.services;
+ const { MeasurementService, DisplaySetService } = servicesManager.services;
const [
trackedMeasurements,
sendTrackedMeasurementsEvent,
@@ -105,7 +105,7 @@ function PanelMeasurementTableTracking({ servicesManager, extensionManager }) {
const activeMeasurementItem = 0;
- const onExportClick = () => {
+ const exportReport = () => {
const measurements = MeasurementService.getMeasurements();
const trackedMeasurements = measurements.filter(
m =>
@@ -117,7 +117,7 @@ function PanelMeasurementTableTracking({ servicesManager, extensionManager }) {
DICOMSR.downloadReport(trackedMeasurements, dataSource);
};
- const onCreateReportClick = () => {
+ const createReport = () => {
const measurements = MeasurementService.getMeasurements();
const trackedMeasurements = measurements.filter(
m =>
@@ -125,13 +125,18 @@ function PanelMeasurementTableTracking({ servicesManager, extensionManager }) {
trackedSeries.includes(m.referenceSeriesUID)
);
-
const dataSources = extensionManager.getDataSources();
// TODO -> Eventually deal with multiple dataSources.
// Would need some way of saying which one is the "push" dataSource
const dataSource = dataSources[0];
- DICOMSR.storeMeasurements(trackedMeasurements, dataSource);
+ DICOMSR.storeMeasurements(
+ trackedMeasurements,
+ dataSource,
+ naturalizedReport => {
+ DisplaySetService.makeDisplaySets([naturalizedReport]);
+ }
+ );
};
return (
@@ -154,8 +159,8 @@ function PanelMeasurementTableTracking({ servicesManager, extensionManager }) {
>
diff --git a/platform/core/src/DICOMSR/dataExchange.js b/platform/core/src/DICOMSR/dataExchange.js
index 2b3cfe172..8f86f743c 100644
--- a/platform/core/src/DICOMSR/dataExchange.js
+++ b/platform/core/src/DICOMSR/dataExchange.js
@@ -43,45 +43,6 @@ const retrieveMeasurements = server => {
return retrieveMeasurementFromSR(latestSeries, studies, serverUrl);
};
-/**
- * Function to be registered into MeasurementAPI to store measurements into DICOM Structured Reports
- *
- * @param {Object} measurementData - OHIF measurementData object
- * @param {Object} filter
- * @param {serverType} server
- * @returns {Object} With message to be displayed on success
- */
-const storeMeasurementsOld = async (measurementData, filter, server) => {
- log.info('[DICOMSR] storeMeasurements');
-
- if (!server || server.type !== 'dicomWeb') {
- log.error('[DICOMSR] DicomWeb server is required!');
- return Promise.reject({});
- }
-
- const serverUrl = server.wadoRoot;
- const firstMeasurementKey = Object.keys(measurementData)[0];
- const firstMeasurement = measurementData[firstMeasurementKey][0];
- const StudyInstanceUID =
- firstMeasurement && firstMeasurement.StudyInstanceUID;
-
- try {
- await stowSRFromMeasurements(measurementData, serverUrl);
- if (StudyInstanceUID) {
- studies.deleteStudyMetadataPromise(StudyInstanceUID);
- }
-
- return {
- message: 'Measurements saved successfully',
- };
- } catch (error) {
- log.error(
- `[DICOMSR] Error while saving the measurements: ${error.message}`
- );
- throw new Error('Error while saving the measurements.');
- }
-};
-
/**
*
* @param {object[]} measurementData An array of measurements from the measurements service
@@ -119,7 +80,7 @@ const generateReport = measurementData => {
* that you wish to serialize.
* @param {object} dataSource The dataSource that you wish to use to persist the data.
*/
-const storeMeasurements = async (measurementData, dataSource) => {
+const storeMeasurements = async (measurementData, dataSource, onSuccess) => {
// TODO -> Eventually use the measurements directly and not the dcmjs adapter,
// But it is good enough for now whilst we only have cornerstone as a datasource.
log.info('[DICOMSR] storeMeasurements');
@@ -136,7 +97,11 @@ const storeMeasurements = async (measurementData, dataSource) => {
await dataSource.store.dicom(naturalizedReport);
if (StudyInstanceUID) {
- studies.deleteStudyMetadataPromise(StudyInstanceUID);
+ dataSource.deleteStudyMetadataPromise(StudyInstanceUID);
+ }
+
+ if (onSuccess) {
+ onSuccess(naturalizedReport);
}
return {
diff --git a/platform/core/src/DataSources/IWebApiDataSource.js b/platform/core/src/DataSources/IWebApiDataSource.js
index 10285d364..2ba208ea5 100644
--- a/platform/core/src/DataSources/IWebApiDataSource.js
+++ b/platform/core/src/DataSources/IWebApiDataSource.js
@@ -17,6 +17,7 @@ function create({
retrieve,
store,
retrieveSeriesMetadata,
+ deleteStudyMetadataPromise,
getImageIdsForDisplaySet,
}) {
const defaultQuery = {
@@ -59,6 +60,7 @@ function create({
store: store || defaultStore,
getImageIdsForDisplaySet,
retrieveSeriesMetadata,
+ deleteStudyMetadataPromise,
};
}
diff --git a/platform/core/src/services/DicomMetadataStore/DicomMetadataStore.js b/platform/core/src/services/DicomMetadataStore/DicomMetadataStore.js
index 8fb176959..7768905fa 100644
--- a/platform/core/src/services/DicomMetadataStore/DicomMetadataStore.js
+++ b/platform/core/src/services/DicomMetadataStore/DicomMetadataStore.js
@@ -72,16 +72,16 @@ const BaseImplementation = {
study = _model.studies[_model.studies.length - 1];
}
- // TODO: Worth identifying why this is being called many times with series
- // that are already "added"?
- const didAddSeries = study.addSeries(instances);
+ study.addSeries(instances);
- if (didAddSeries) {
- this._broadcastEvent(EVENTS.INSTANCES_ADDED, {
- StudyInstanceUID,
- SeriesInstanceUID,
- });
- }
+ // Broadcast an event even if we used cached data.
+ // This is because the mode needs to listen to instances that are added to build up its active displaySets.
+ // It will see there are cached displaySets and end early if this Series has already been fired in this
+ // Mode session for some reason.
+ this._broadcastEvent(EVENTS.INSTANCES_ADDED, {
+ StudyInstanceUID,
+ SeriesInstanceUID,
+ });
},
addStudy(study) {
const { StudyInstanceUID } = study;