* WindowLevel preset code changes
* Remove localStorage code as its already being saved and some small refactor on reducer/action
* Creating unit tests for preferences reducer
* Fix cypress after class naming change
* Make hidden false as default for tab components
* Remove addUserPreferences
* Small refactor to use commandsManager from getCommandsModule instead of getting it from App.js
* fix: Combined Hotkeys for special characters
* add record method to hotkey manager
* fix record plugin
* remove unused component
* add record to modal props
* rename record method
* replace handlers to use hotkeyRecord
* fix combined keys
* change expected result count from 18 to 17
* autoformat
* Remove duplicate test, that was testing the wrong things; fix label; update configs
* Revert "Remove duplicate test, that was testing the wrong things; fix label; update configs"
This reverts commit 4292f4fe67351962d61cae623b920dcbd87dd71d.
* Fix the record plugin's registration
* fix exposed record method usage
* adding logging for info level items
* Hotkey definitions don't need to be globally reactive; use localstorage/appconfig as sources of truth; not redux
* Tidy up test
* Remove unused code from UserPreferencesForm
* Log info when we run a command
* fix hotkey preference restore
* use application configured hotkeys if there are no user preferred
* Avoid logging circular ref
* Fix callouts
* Fix small issue with array
* Fix langua issue after refactor and merge
* Refactor on recordCurrentCombo as Rodrigo did before
* Separating components in 2 files
* WIP Refactor to simplify the user preferences and move into each form the save and controll functionalities
* Remove context
* Remove unused import
* Initial work on Field treatment
* Refactor General preferences
* Small refactor removing type from HotkeyField
* small update on style
* Refactor and layout fixed
* Make hotkeys preferences working with old hotkeys row
* Move error handling out of hotkey row/input component
* WIP custom form
* Moving validation function to component
* Exposing hotkeyRecord as it does not depend on HotkeyManager Class
* Making hotkeyField as much detached possible from parent component
* Small refactors
* Refactor on user preferences
* Clean up into the changes
* Small fix to let save working
* Style finish
* move about docs into about folder
* Fix double tap on single keys
* Style refactor
* Remove log
* Fix log issues on unit tests
* Fix unit test breaking on ohif/core index
* Fixing hotkeys unpause unit test issue
* Rename file to adopt lowercase
* Rename file to adopt lowercase
* Fixing callouts
* Big refactor miving some of the components into viewer and creating small components into ohif/ui
* Typo on folder name
* Updating ohif ui docs
* Remove comments
* Fix binding of combo keys
* Fix some cypress tests failures
* Fixing onCancel button
* Fixing e2e tests
* Small style update
* Fixing unit tests failing after fix issue
* Remove some not used code
* Remove left over after debug
* Adding prevent default on hotkeys events
* Fixinf existing hotkeys validator with 3 keys pressed
* Exposing hotkeys as root level on ohif-core
* Clean up
* Exposing all availableLanguages with labels and fixing an issue on language switcher
* Fixing e2e cypress tests
* Preveinting some simple errors
* Treating error once we try to set hotkey definitions
* Adding ui notification on setHotkeys errors
* Implementing a service queue request to hold until functions are implemented
* Making sure toFixed is only called on Numbers
Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
Co-authored-by: Gustavo André Lelis <galelis@gmail.com>
* fix: download tool fixes & improvements
* fix filename error
* Create variable to track erros
* Fix small console error
* Fix all conflicts and merge changes from latest master with this PR's improvements
* Small improvement on select and textinput labels
* Add new icon for unlink
* Refactor on download image modal
* Adding loading screen
* Fix translation issue
* Fixing aspect Ratio and E2E tests
* Allow empty value without setting to 0
* Remove eslint comments
* Fixing typos
Co-authored-by: Gustavo André Lelis <galelis@gmail.com>
Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
* 1316 - E2E tests for /local
* fix test title
* update yarn.lock
* Increased timeout for thumbnails
* Removing PDF file test from script-tag server
Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
* Tests for routes: PT/CT json, studies, series, frames, metadatas
* Fix based on reviews and JSON file for PT/CT Study added
* chore: revert to remote JSON file
* chore: delete PTCTStudy.json file
We can circle back to this approach when/if we have issues. No need to hold-up this PR. My fault on this one.
* E2E Tests: Download Image File Modal
* CI fix
* Fixes for PR comments
* Small change just to check CI behavior
* Fix for CI failure: comparing classes instead of image src
* Fixed Download button test and blocked Download Dialog event
* Deleting file ConnectedViewportDownloadForm.js
This file was not supposed to be created by this PR. It was already deleted by another user on Master branch.
* Removing wrong import line
* Fixes based on PR comments
* Fixes based on PR comments
* test: remove assignment to window
* fix: study list translations
* Don't render until translations are ready
* Try to wait for translations to load
* Use null to render "nothing"
* Try toggling useSuspense off up a layer
* logging
* Remove useSuspense false flags
* DO NOT OPEN A PR WITH IT.
Experimental changes only.
Try to solve issues with useTranslation hooks
#Please enter the commit message for your changes. Lines starting
* Remove unecessary changes
* feat: 🎸 useMedia hook to not use one more prop for upd state vl
* docs: Add license scan report and status (#1161)
Signed-off-by: fossabot <badges@fossa.io>
* fix: 🐛 Fix for JS breaking on header (#1164)
* feat: 🎸 Code review and refact
Revised code based on PRs(variable alias,...). Changed hook for
useMedia. Now, it provides two hooks: one to get displayMediaSize and
other to get Entity(component, objects...) based on displayMediaSize.
Implemented a similar solution for state manager to store
mediaQueryList(s) and displaySize for app.
* feat: 🎸 Fine tunning on mediaQuery value, fixed issue about it
* fix: 🐛 Fixed issue and refactoring
Fixed js exception and also refactoring userPreferences components to
functional component
* fix: 🐛 Code review. Localstorage fix minor bugs
* fix: 🐛 Ensure hotkey lower case always
* fix: translation switcher
* chore(release): publish [skip ci]
- @ohif/extension-vtk@0.53.6
- @ohif/ui@0.62.1
- @ohif/viewer@2.8.2
* Add new modal service
* Change serviceManager prop to servicesManager
* CR Update: fix casing and add required proptypes to providers
* CR Update: Improve ohifmodal proptypes
* CR Update: Fix typo in extensionmanager
* CR Update: add default props to service and check service in provider
* Refactor modal provider to better use its own state
* ci: don't build our master branch (#1177)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* Use modal instead of modal context
* Ci/promotable builds (#1179)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Change modal children order
* Ci/promotable builds (#1180)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* Ci/promotable builds (#1181)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* ci: make sure netlify command is available
* Ci/promotable builds (#1182)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* ci: make sure netlify command is available
* ci: use sudo for global command
* Fix OHIFModal proptypes
* Ci/promotable builds (#1183)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* ci: make sure netlify command is available
* ci: use sudo for global command
* Inline personal access token w/ env var
* Ci/promotable builds (#1184)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* ci: make sure netlify command is available
* ci: use sudo for global command
* Inline personal access token w/ env var
* ci: workaround for sudo limitations
* ci: restore release workflow (#1185)
* ci: don't build our master branch
* Add netlify-cli as a dev dependency
* ci: trying a sheltered merge flow for promotions
* ci: try building with QUICK_BUILD flag
* Try using ~/repo prefix in command
* ci: make sure netlify command is available
* ci: use sudo for global command
* Inline personal access token w/ env var
* ci: workaround for sudo limitations
* ci: restore release workflow
* Pass services to each module, improve tests
* Add servicesManager test and registerServices method
* Fix key warning of snackbar elements
* Remove netlify-cli; we';ll install this on CI server
* Update staging and prod netlify site IDs
* Clean up NPM_PUBLISH step
* Clean up DOCS_PUBLISH step
* Clean up Deploy workflow
* Custom executor to override cypress config
* Spacing
* Use an existing docker hub image
* Switch to npx instead of digging into npm bin location
* Remove e2e test before prod deploy
* Add workflow images
* docs: continous integrationn
* Add default props to modal
* chore(release): publish [skip ci]
- @ohif/extension-cornerstone@1.5.1
- @ohif/extension-vtk@0.53.7
- @ohif/core@1.9.1
- @ohif/ui@0.62.2
- @ohif/viewer@2.8.3
* chore(release): publish [skip ci]
- @ohif/extension-vtk@0.53.8
- @ohif/core@1.10.0
- @ohif/ui@0.62.3
- @ohif/viewer@2.8.4
* ci: Redirect site traffic to index.html if file is not resolved
* ci: fix typo
* fix: 🐛 Code review. Remove 'global state' for displaySize
* fix: 🐛 Code review. Ref back to useMedia and pass value down
Code review. Ref back to useMedia and pass value down (components)
instead of creating a specialized hook to tied any component on it
* fix: translation switcher
* fix
* cleanup
* add missed translation
* fix: 🐛 Code review
* fix: 🐛 Fix unit tests
* fix: 🐛 Fix unit test
* fix: 🐛 Code merge solve conflicts. Missing files changes
* Merge from master. Missing files changes
* feat: 🎸 Code review. Fix issues with DatePicker
Fixed at least the minimum issue with datePicker and update some content
on every translation changed
* fix: 🐛 Code review. Style fix on modal
* fixes in general preferences after merge
* fix
* export default i18n language
* translation fixes
* increase snackbar zindex
* initialize language
* WIP propagate props<>state fixes
* fix state propagation
* remove hotkey error when reset default
* fix datePicker
* i18n updates
* fix i18n strings
* fix reset default -- set right input value
* fix default language
* fix e2e for user preferences
* small fix datePicker props
* remove i18n from window -- debugging purposes only
* lint fixes
* Test Cases for User Preferences
* CI fix
* Fix for CI
* Fix based on PR review comments
* Fix for script-tag issue on CI
* Fix for new selectors on Preferences Modal and CI failure
* feat: 🎸 Filter by url query param for seriesInstnaceUID
* fix: Set SR viewport as active by interaction (#1118)
* fix: Set SR viewport as active by interaction
* quick fix
* (eslint) add "before" as global variables
* add data-cy
* add data-cy
* create E2E test
* (E2E) create custom command to set layout size
* remove .only e2e
* remove throttle for onScroll
* feat: 🎸 Code review in progress
Code review. Move retrieveMEtadata load to separate folders. Some minor
code clean up
* feat: 🎸 Code review. Missing changes from previous commit
* feat: 🎸 Code review missing changes from previous commit
When sorting, Criteria for instance must use instanceNumber and not
instancesNumber
* feat: 🎸 Code review. Add more jsdoc info
* feat: 🎸 Code review. Prettify changed code
* feat: 🎸 Instead of filtering do promote. WIP
* feat: 🎸 Fix minor issue. Allow promote or filter
* feat: 🎸 Changing component to functional component
* Merge from master Part1/2
Conflicts solved:
both added: core/src/studies/services/wado/retrieveMetadataLoader.js
both added: core/src/studies/services/wado/retrieveMetadataLoaderAsync.js
both added: core/src/studies/services/wado/retrieveMetadataLoaderSync.js
both modified: viewer/src/connectedComponents/ViewerRetrieveStudyData.js
both modified: viewer/src/routes/ViewerRouting.js
* Merge process from master Part 1/2
Missing files from previous commit
* feat: 🎸 Add cancelable promises to cut async methods
* feat: 🎸 Missing changes from previous merge process
* feat: 🎸 Missing changes from previous merge process
* Visual testing for Cornerstone and VTK
* Fix for CI
* Review fix: Removed cornerstone function and added snapshot description
* Added snapshot description
* Fix for CI
* feat: 🎸 Update hotkeys and user preferences modal
This feature fix incompatibility with existent hotkeys component and
adds user preferences modal back
Closes: #923
* Update preferences structure in store
* Hide window level section of user preferences
* Update modal to reflect current hotkey value
* Clone object with hotkeys before passing to manager
* CR Update: Extract hotkeys manager format code to manager
* Fix broken cypress test
* Use new modal provider
* Rename hotkeyDefinitions in hotkeyspreferences and use array as representation
* Update study test and remove unused styles
* Study list tests: Patient Name, MRN, Modality, Description
* Fixed field selector
* Desktop tests
* Fix for study list
* Added tablet tests and small refactor on aliases
* Fix based on reviews
* fix: 🐛 Fix ghost shadow on thumb
Updated react-dnd package for the lates. Refactored thumbnail component
Closes: 1087
* feat: 🎸 Code review
Set flex instead of float. Add cypress tag to thumb container
* feat: 🎸 Code review. Revised style when no description
* feat: 🎸 Load spinner when selecting gcloud store. Add key on td
* feat: 🎸 Code review. Translate loading study status
* feat: 🎸 Code review. Minor code refactoring
* fix: add missing study and index declerations
* Newer version of react-dates (calendar input component)
* Add useMedia hook
* Add useDebounce hook
* Export hooks for consumption
* Pull search filter into own component
* StudyListWithData to StudyListRoute
* Rename pagination component
* Rename Toolbar
* CustomeDateRangePicker to plain ol' css
* Remove unused styles
* Misc
* Magic to make our "OR" filters work
* Play w/ Mobile styles
* Fix pagination pushing out max width for viewport
* Tidy up small and medium templates
* Remove unecessary nesting
* Better mobile header and logo styles
* Fix studyList font size
* Remove unused code
* hookup on click
* Fix table search selectors
* Cypress uses medium width
* Remove irrelevant test
* Fix primary sort
* Fix sort for our smaller displays
* fix study list sometimes longer than specified rowsPerPage
* Simplify date picker styles
* restore study date filters
* Fix about table styling
* fix take value for search
* Fix header sizing for viewer and list route
* Remove dead code
* Restore isLoading
* Update platform/ui/src/components/studyList/StudyList.styl
Co-Authored-By: Rodrigo Antinarelli <rodrigoantinarelli@gmail.com>
* Attempt first usage of translations w/ hooks
* Pull from react-i18n library
* Fit presets on to a single line
* add no results message
* Show error message in studyList table
* Update input selectors for e2e tests
* Make sure messages span all columns
* fix test selector for table results
* Skip hover for result rows
* fix imports
* Date filtering w/ config
* Default export
* Pushed to PageComponent
* Remove DropZone
This previously only worked for null/undefined studies. I'm unable to trigger the state by testing the data. This "might" have happened when using a fresh/empty PACS; but even an empty array of studies would not show
* E2E tests: Stack Scroll, Right-click to zoom, Middle-click to Pan
* About modal tests and added some cypress selectors
* Checking app version number
* Removed accidental import
* Review fixes
* feat: 🎸 Load spinner when selecting gcloud store. Add key on td
* feat: 🎸 Code review. Translate loading study status
* feat: 🎸 Code review. Minor code refactoring
* fix: add missing study and index declerations
* test: Improviment on VTK beforeEach hook (#1057)
* feat: 🎸 Some improvements on table cell and react lifecycle
* feat: 🎸 Prevent component update on a not searchData changing
* feat: 🎸 Some cypress improv to pass ci
* feat: 🎸 Code reviewe and also fixing list for gcloud
* feat: 🎸 Code review. Add spinner on first load of store
* feat: 🎸 Code review. Centering loading list spinner icon
* Adding Percy Snapshot on VTK, PDF and Microscopy tests
* Small improvement to always click on first search result
* Wait for search result
* Added timouts all over the code to avoid intermitted failures in CI
* Increasing Default Timeout and other configs
* Cleaning up the code
* try force enabling gpu
* Try custom executor with newer version of chrome
* Fix based on review comments
* Increased minimum thumbnails expected on VTK test
* Fix config validation
* Make sure we're using the chrome browser
* Test cases for extensions: VTK, HTML and PDF
* Test Cases: Delete measurement, Relabel and Description through Contextmenu
* Fix: PDF, HTML and VTK extensions
* CI: running into different folders for PWA and Script-tag tests
* CI: running into different folders for PWA and Script-tag tests
* CI: running into different folders for PWA and Script-tag tests
* Fix for VTK tests and Cornerstone Eraser tool
* Removed VTK alias from Cornerstone aliases initialization
* Temporary fix for Eraser tool
* Test workaround
* Use juno for vtk
* Shift VTK tests to PWA folder
* feat: 🎸 Only allow reconstruction of datasets that make sense
Only allow reconstruction of datasets which are imaging data, that have
frames in the same orientation, with the same size and make sense to be
reconstructed in 3D.
Closes: #561
* Fix for test scripts that were failing in CI
* Test cases for tools: Length and Angle
* Test cases implemented: Scroll series, Levels, Pan, Reset, Zoom
* Added test cases for tools: Cine, More, Layout, Invert, Rotate, FlipH, FlipV
* Fixes made according to comments on PR review
* Fixes for failing scenarios: Layout and Cine
* Test cases implemented: Cornerstone tools Clear and Eraser; Measurement panel Relabel and Description
* Fix for CI failure
* Fix for test scripts that were failing in CI
* Test cases for tools: Length and Angle
* Test cases implemented: Scroll series, Levels, Pan, Reset, Zoom
* Added test cases for tools: Cine, More, Layout, Invert, Rotate, FlipH, FlipV
* Fixes made according to comments on PR review
* Fixes for failing scenarios: Layout and Cine
* TEST E2E: Drag and drop thumbnail into viewport
* TEST E2E: Drag and drop thumbnail into viewport
* fix: add pollyfill to script-tag template
* Add wait's to command
* Try to store artifacts
* ci: updated artifact location
* Changing Patient to MisterMR
* Refactors based on PR comments
* Adding new sub-folders to separate the testing scripts according to context/features
* Adding test cases for Side Panels Measurements and Series
* Removing duplicated file OHIFStudyViewer.spec.js
