othmane/ohif-viewer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

0 Releases 2,327 Tags

RSS Feed
  • v0.19.3 e73d009c21
    Compare

    fix(package.json): Resolve react/react-dom dependency conflict for embedded users (#734)

    Ghost released this 2019-07-30 08:30:23 +02:00 | 4504 commits to master since this release

    • fix(package.json): Resolve react/react-dom dependency conflict for embedded users

    Some of the recent changes around the script-tag support for ohif/Viewers included moving react and
    react-dom from peerDependencies to dependencies. This caused an error for embedded consumers of the
    viewer because there could be multiple versions of react included. The error in the console points
    to this link: https://reactjs.org/warnings/invalid-hook-call-warning.html. These changes are
    necessary to resolve the issue for embedded users and don't seem to break the standalone version
    either.

    • fix(script-tag/index.html): Add react and react-dom as external scripts for cypress tests

    The cyrpress tests won't pass unless we add the react and react-dom dependencies as external
    scripts since they're no longer first order depdencies.

    Downloads