* Add customization URL parameter
* fix: Preserve should be customizeable
* Update customizations docs
* fix: Overlay items on patient name
* Add customization test
* Fix resolve to absolute path
* fix: Warn on no data in load
* Remove unused customization stuff
* fix: PR comments
* Update stored parameters to only use an array for mulitples
* Remove requires ohif.* special call out
* Remove strict mode
* PR comments
* Document segmentation examples
* Add three examples as requested
* PR comments
* lock
* Remove old customizatoin export
* fix: Ordering issues on customization loads
* fix: Use correct default for dev builds app config
* Fixes for conflicts
* chore: restore pnpm-lock.yaml to match master
The lockfile diff was incidental peer-descriptor churn and carried no
functional dependency change. It tripped the CircleCI security-audit gate
(which only runs when pnpm-lock.yaml is in the PR diff), surfacing a
pre-existing critical `decompress` transitive vuln that also exists on
master. Restoring master's lockfile removes the audit trigger.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(ci): restore json5 lockfile entry; ignore unfixable decompress GHSA
The previous commit restored pnpm-lock.yaml from master, which dropped the
json5@2.2.3 entry that platform/core legitimately depends on (JSONC parsing
for the customization feature). That broke `--frozen-lockfile` install
(ERR_PNPM_OUTDATED_LOCKFILE). This restores the correct lockfile.
Because the lockfile must change (json5), the CircleCI security-audit gate
runs and previously failed on a critical `decompress` <=4.2.1 zip-slip
advisory. This is a pre-existing transitive vuln (present on master too) with
no published patch — decompress's latest release is 4.2.1, so no version
bump/override can resolve it. It reaches the tree only via @itk-wasm/dam, a
build/data-asset extraction tool under @cornerstonejs/labelmap-interpolation.
Add GHSA-mp2f-45pm-3cg9 to the existing pnpm-workspace.yaml auditConfig
ignoreGhsas accepted-risk list, matching how the repo already exempts other
build-tooling advisories. `pnpm audit --audit-level high` now passes locally
(1 critical ignored, 0 high).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(e2e): fix visitStudy URL encoding that broke mpr2 study load
The visitStudy rewrite (added for the ?customization= option) built the URL
with new URLSearchParams({ StudyInstanceUIDs: studyInstanceUID }), which
percent-encodes the value. mpr2.spec.ts embeds an extra param in the UID
string ('<uid>&hangingprotocolid=mpr'), so the & and = were encoded and the
whole thing collapsed into one invalid StudyInstanceUIDs value -> the study
could not be found ('studies are not available'), the viewer never rendered,
and the side-panel-header-right click timed out.
Restore master's raw concatenation for StudyInstanceUIDs (so embedded params
survive as separate query params) while still appending the customization
option separately. Only mpr2 embeds & in the UID, matching the single failure.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* PR comments
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
109 lines
4.7 KiB
JavaScript
109 lines
4.7 KiB
JavaScript
/** @type {AppTypes.Config} */
|
|
|
|
// Secure, minimal default configuration.
|
|
//
|
|
// This is what a plain production build with no APP_CONFIG produces, so it is
|
|
// deliberately locked down:
|
|
// - The local file data source (`dicomlocal`) and the runtime `?url=` sources
|
|
// (`dicomjson`, `dicomwebproxy`) are NOT enabled — they widen the attack
|
|
// surface of a default deployment.
|
|
// - `?customization=` URL loading is OFF: no `customizationUrlPrefixes` are
|
|
// configured, so any `?customization=` value is rejected (and aborts boot
|
|
// rather than silently loading).
|
|
// - `dangerouslyUseDynamicConfig` (the `configUrl` query parameter) is off.
|
|
//
|
|
// It does not need to "just work" untouched — point the data source below at
|
|
// your own DICOMweb server. For a fully-featured setup with every data source
|
|
// and customization loading enabled, see config/dev.js (local development) and
|
|
// config/netlify.js (the public demo deploy).
|
|
window.config = {
|
|
name: 'config/default.js',
|
|
routerBasename: null,
|
|
// whiteLabeling: {},
|
|
extensions: [],
|
|
modes: [],
|
|
customizationService: {},
|
|
|
|
// --- URL-driven customizations (?customization=) ----------------------------
|
|
// OFF by default. To allow loading customization data files from the URL, set
|
|
// `customizationUrlPrefixes` to a map of allowed prefixes. The `default` prefix
|
|
// (no slashes) is used for values with no leading slash; every other prefix
|
|
// must start AND end with a slash and is matched against the leading
|
|
// `/segment/` of the value. Files are fetched and parsed as JSONC data — they
|
|
// are never executed. Example (left disabled here on purpose):
|
|
//
|
|
// customizationUrlPrefixes: {
|
|
// default: './customizations/', // ?customization=ctPresets
|
|
// '/remote/': 'https://cdn.example.com/ohif-custom/', // ?customization=/remote/siteA
|
|
// },
|
|
// ----------------------------------------------------------------------------
|
|
|
|
showStudyList: true,
|
|
// some windows systems have issues with more than 3 web workers
|
|
maxNumberOfWebWorkers: 3,
|
|
// below flag is for performance reasons, but it might not work for all servers
|
|
showWarningMessageForCrossOrigin: true,
|
|
showCPUFallbackMessage: true,
|
|
showLoadingIndicator: true,
|
|
experimentalStudyBrowserSort: false,
|
|
strictZSpacingForVolumeViewport: true,
|
|
groupEnabledModesFirst: true,
|
|
allowMultiSelectExport: false,
|
|
maxNumRequests: {
|
|
interaction: 100,
|
|
thumbnail: 5,
|
|
// Prefetch number is dependent on the http protocol. For http 2 or
|
|
// above, the number of requests can be go a lot higher.
|
|
prefetch: 25,
|
|
},
|
|
showErrorDetails: 'always', // 'always', 'dev', 'production'
|
|
// `dangerouslyUseDynamicConfig` (load configuration from a `configUrl` query
|
|
// parameter) is intentionally left OFF in the secure default build. See
|
|
// config/dev.js for the documented shape.
|
|
defaultDataSourceName: 'ohif',
|
|
dataSources: [
|
|
{
|
|
// Read-only public demo server. Replace with your own DICOMweb server.
|
|
namespace: '@ohif/extension-default.dataSourcesModule.dicomweb',
|
|
sourceName: 'ohif',
|
|
configuration: {
|
|
friendlyName: 'AWS S3 Static wado server',
|
|
name: 'aws',
|
|
wadoUriRoot: 'https://d14fa38qiwhyfd.cloudfront.net/dicomweb',
|
|
qidoRoot: 'https://d14fa38qiwhyfd.cloudfront.net/dicomweb',
|
|
wadoRoot: 'https://d14fa38qiwhyfd.cloudfront.net/dicomweb',
|
|
qidoSupportsIncludeField: false,
|
|
imageRendering: 'wadors',
|
|
thumbnailRendering: 'thumbnail',
|
|
thumbnailRequestStrategy: 'fetch',
|
|
enableStudyLazyLoad: true,
|
|
supportsFuzzyMatching: true,
|
|
supportsWildcard: true,
|
|
staticWado: true,
|
|
singlepart: 'bulkdata,video',
|
|
bulkDataURI: {
|
|
enabled: true,
|
|
relativeResolution: 'studies',
|
|
transform: url => url.replace('/pixeldata.mp4', '/rendered'),
|
|
},
|
|
omitQuotationForMultipartRequest: true,
|
|
},
|
|
},
|
|
|
|
// The following data sources are intentionally NOT enabled in the secure
|
|
// default because they broaden the attack surface of a default deployment.
|
|
// Enable them only in a deployment you control (see config/dev.js):
|
|
// - dicomlocal: loads DICOM files from the user's machine.
|
|
// - dicomjson: loads metadata from an arbitrary `?url=` (gate with
|
|
// `dangerouslyAllowedOriginsForAuthenticatedEnvironments`).
|
|
// - dicomwebproxy: delegating proxy driven by `?url=`.
|
|
],
|
|
httpErrorHandler: error => {
|
|
// This is 429 when rejected from the public idc sandbox too often.
|
|
console.warn(error.status);
|
|
|
|
// Could use services manager here to bring up a dialog/modal if needed.
|
|
console.warn('test, navigate to https://ohif.org/');
|
|
},
|
|
};
|