ohif-viewer/tests/SegmentationPanel.spec.ts
Bill Wallace f1cc2ee13a
feat: Update to use pnpm (#6031)
* Initial pnpm change

* Install/update in pnpm sort of works

* Attempt to fix install

* fix pnpm

* Refactor build process to use RSPack instead of Webpack across multiple extensions and modes. Update package.json scripts for development and production builds, and adjust webpack configuration files to accommodate new plugin imports and settings.

* Update RSPack dependencies to version 2.0.0 across the project, enhancing compatibility and performance. Refactor webpack configuration in multiple extensions and modes to utilize the new library structure for UMD output. Adjust package.json scripts and settings for improved build processes.

* Implement migration guide for OHIF 3.13, detailing the transition from Webpack to Rspack v2, the shift to pnpm workspaces, and the increase in minimum Node.js version to 24. Include new build commands, plugin replacements, and updates to package configurations across the monorepo.

* Fix some dev:fast bugs

* Move netlify to top level and remove webpack builds

* Update version script to deal with lerna missing

* chore(tests): Update multiple screenshot test images for various specs

* feat(screenshot-reviewer): Add screenshot review tool and update package.json scripts

* fix(DICOMSRDisplayTool): Improve actor presence check in viewport

* chore(tests): Update multiple screenshot assets for various specs

* chore(tests): Integrate waitForPaintToSettle and waitForViewportsRendered in multiple specs for improved rendering stability

* chore(tests): Update screenshot assets for SEGHydration and SEGNoHydration specs

* test: update progressive loading screenshots

* jest 30 test fixes for compatibility with pnpm cs3d

* Use correct setDisplaySets instead of setDataId

* fix: Naming change for LegacyVolumeViewport3D

* Update to allow tolerance for contour tests

* update

* fix

* refactor: Replace instanceof checks with utility functions for viewport type validation

* fix: Update createSegmentationForViewport to handle undefined displaySetInstanceUID gracefully

* bun lock

* chore(pnpm): align workspace setup to cornerstone3D and address PR review

- .npmrc / pnpm-workspace.yaml: mirror cs3d (node-linker hoisted,
  strict-peer-dependencies=false, link/prefer workspace packages,
  minimumReleaseAge, frozenLockfile); sync axios 1.17.0 + tmp override
- root: packageManager pnpm@11.4.0, engines pnpm >=11, wire preinstall.js
- restore preinstall.js (token/private-repo + CLAUDE->AGENTS symlink)
- playwright.yml: keep base CS3D-integration workflow, switch only the
  package manager (bun/yarn -> pnpm) and node 20 -> 24
- webpack.base.js: revert prod devtool to source-map (drop hidden-source-map)
- remove @percy/cypress; .netlify + cli templates engines pnpm >=11
- Dockerfile pin pnpm@11; document tests/globalSetup.ts warmup
- drop dicom-sr -> measurement-tracking edge (breaks pnpm cyclic dep)

* chore(pnpm): regenerate lockfile and restore cs3d:* dev scripts

- Regenerate pnpm-lock.yaml against the resolved workspace (cycle removed,
  cs3d 4.22.10, workspace:* internal deps).
- Restore cs3d:checkout/check/build/watch/install/link/unlink helper scripts
  (dropped when taking the PR's root scripts), converted yarn -> pnpm since
  the local cornerstone3D checkout is now pnpm too.

* Merge base branch issues

* Link ohif app

* ci: pin pnpm to 11.4.0 in action-setup (was version: latest)

version: latest floats across runs and breaks reproducibility. Pin to the repo's packageManager version (pnpm@11.4.0) in both playwright and build-docs workflows.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix: Accidental commit of .npmrc config

* Fix build issues

* build fix

* Dependency fixes

* fix: Dependency bug in app on extensions/modes

* Fix output configuration

* Replace percy screenshots with native cypress

* Remove percy screenshot entirely

* fix: Build issues

* force click to prevent canvas cover issues

* Enable swiftshader

* Update launch of electron

* fix: Broken size calculation

* Empty change to force a re-build

* fix(cypress): generate ui-next tailwind classes; drop unsupported electron arg

Tailwind only scanned @ohif/ui-next via ../../node_modules/@ohif/ui-next, which no longer resolves under the pnpm layout, so ui-next-unique classes (e.g. toolbar split-button sizing) were never generated. Those buttons' hit-boxes collapsed, producing Cypress 'covered by element' failures on toolbar interactions. Scan ui-next by direct filesystem path like ui/extensions/modes.

Also stop pushing --enable-unsafe-swiftshader into Electron's launchOptions.args (Electron ignores it and warns); it is supplied via ELECTRON_EXTRA_LAUNCH_ARGS in CI. The arg is still pushed for non-electron chromium (local chrome).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(e2e): disable dev-server overlay during coverage runs

The rspack dev-server client overlay injects an iframe (id=rspack-dev-server-client-overlay) that intercepts pointer events, causing Playwright/Cypress clicks on toolbar buttons to time out (e.g. MicroscopyPanel). Disable the overlay when COVERAGE=true (e2e/Playwright webServer) while keeping it for normal local dev.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(microscopy): provide dicom-microscopy-viewer runtime assets

The microscopy viewer is loaded at runtime via peerImport('dicom-microscopy-viewer'), which fetches the copied asset served at /dicom-microscopy-viewer/. Two issues prevented those assets from reaching dist, so the viewer never initialized and drawing produced no measurement row:

1) dicom-microscopy-viewer was declared in no workspace package.json (only under libs/@cornerstonejs), so it was not installed at root node_modules and the pluginConfig copy source did not exist. Declare it (0.48.6, matching libs) in the microscopy extension.

2) createCopyPluginToDist appended the public/dist folder name to entries that specify an explicit directory, breaking the dicom-microscopy-viewer public entry (looked for .../dynamic-import/public). Use an explicit directory as-is; only append the folder name for package-derived entries.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Update to pnpm 11.5.2 and cs3d 5.0.2

* Lock file

* fix: Update to newer versions of actions to try to fix hang

* Remove unnecessary version

* fix: Tests that are flaky

* PR comments

* Incorrect run name

* docs: Explain pluginConfig tooling

* Updated notes on pluginConfig and PR comments

* fix: resolve plugins in rsbuild build and fix directory-based asset copy

rsbuild.config.ts: merge getPluginResolveAliases() and an @ohif/app$ alias into resolve.alias, and add resolve.modules (root, platform/app, platform/ui node_modules) so extensions resolve their shared @ohif/* imports. Brings the rsbuild (dev:fast) path to parity with webpack.pwa.js / webpack.base.js.

writePluginImportsFile.js: treat a 'directory' on an extension/mode entry as the package root and copy its public/ and dist/ subdirs instead of the whole directory; public-section entries keep copying their directory verbatim via a new literalDirectory flag.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor: share resolve alias/modules between webpack and rsbuild configs

Extract the resolve.alias (@ohif/app, @, @components, ...) and the node_modules search paths into .webpack/resolveConfig.js, the single source of truth consumed by both webpack.base.js (and every per-package webpack.prod/.dev.js that merges it) and rsbuild.config.ts. getModules(srcDir) appends the building package's own source root, preserving the previous per-package behavior. Ends the drift where the rsbuild path kept missing aliases/module paths that webpack.base.js already had.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Add a timeout on git fetch and avoid all the unnecessary mirrros

* PR comments and tests

* Remove cache to prevent corrupting the cache key/setup.

* Fix stale/corrupted pnpm installer

---------

Co-authored-by: Alireza <ar.sedghi@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 16:04:56 -04:00

211 lines
7.6 KiB
TypeScript

import { expect, test, visitStudy } from './utils';
const nonNumericError = 'Cannot type text into input[type=number]';
test.beforeEach(async ({ page }) => {
// Using same one as JumpToMeasurementMPR.spec.ts
const studyInstanceUID = '1.3.6.1.4.1.14519.5.2.1.256467663913010332776401703474716742458';
const mode = 'segmentation'; // To also test add/remove
await visitStudy(page, studyInstanceUID, mode, 2000);
});
test('checks basic add, rename, delete segments from panel', async ({ rightPanelPageObject }) => {
// Segmentation Panel should already be open
const segmentationPanel = rightPanelPageObject.labelMapSegmentationPanel.menuButton;
await expect(segmentationPanel).toBeVisible();
// Switch to labelmap tab.
await segmentationPanel.click();
// Add segmentation
await rightPanelPageObject.labelMapSegmentationPanel.addSegmentationButton.click();
// Expect new segmentation and blank segment named "Segment 1". Use a retrying
// toHaveCount assertion: the segment row renders asynchronously after the add,
// so a one-shot getSegmentCount() races the render and was intermittently 0.
const { panel } = rightPanelPageObject.labelMapSegmentationPanel;
const segment1 = panel.nthSegment(0);
await expect(panel.rows).toHaveCount(1);
await expect(segment1.locator).toContainText('Segment 1');
// Rename
await segment1.actions.rename('Segment One');
await expect(segment1.locator).toContainText('Segment One');
await expect(segment1.locator).not.toContainText('Segment 1');
// Delete
await segment1.actions.delete();
// Retrying assertion: row removal is async too.
await expect(panel.rows).toHaveCount(0);
});
test('checks saved segmentations loads and jumps to slices', async ({
page,
DOMOverlayPageObject,
leftPanelPageObject,
rightPanelPageObject,
viewportPageObject,
}) => {
const activeViewport = await viewportPageObject.active;
const viewportInfoBottomRight = activeViewport.overlayText.bottomRight.instanceNumber;
// Image loads on slice 1, confirm on slice 1
await expect(viewportInfoBottomRight).toContainText('1/', { timeout: 10000 });
// Add Segmentations
await leftPanelPageObject.loadSeriesByModality('SEG');
await page.waitForTimeout(3000);
// Confirm open segmentation
await expect(DOMOverlayPageObject.viewport.segmentationHydration.locator).toBeVisible();
await DOMOverlayPageObject.viewport.segmentationHydration.yes.click();
// Segmentation Panel should already be open
const segmentationPanel = rightPanelPageObject.labelMapSegmentationPanel.menuButton;
await expect(segmentationPanel).toBeVisible();
// Confirm spleen jumps to slice 17
// First iteration repeat to account for segmentation loading delays
await expect(async () => {
await rightPanelPageObject.labelMapSegmentationPanel.panel.segmentByText('Spleen').click();
await expect(viewportInfoBottomRight).toContainText('17/');
}).toPass({
timeout: 10000,
});
// Esophagus - 5
await rightPanelPageObject.labelMapSegmentationPanel.panel.segmentByText('Esophagus').click();
await expect(viewportInfoBottomRight).toContainText('5/');
// Pancreas - 22
await rightPanelPageObject.labelMapSegmentationPanel.panel.segmentByText('Pancreas').click();
await expect(viewportInfoBottomRight).toContainText('22/');
});
test.describe('Segmentation panel config input validation for labelmap', () => {
test.beforeEach(async ({ rightPanelPageObject }) => {
await rightPanelPageObject.labelMapSegmentationPanel.addSegmentationButton.click();
await rightPanelPageObject.labelMapSegmentationPanel.config.toggle.click();
});
test.describe('opacity', () => {
test('should accept valid values', async ({ rightPanelPageObject }) => {
const { opacity } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacity.fill('0');
await expect(opacity.input).toHaveValue('0');
await opacity.fill('0.5');
await expect(opacity.input).toHaveValue('0.5');
await opacity.fill('1');
await expect(opacity.input).toHaveValue('1');
});
test('should clamp opacity to max (1) when a value above the maximum is entered', async ({
rightPanelPageObject,
}) => {
const { opacity } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacity.fill('500');
await expect(opacity.input).toHaveValue('1');
});
test('should clamp opacity to min (0) when a value below the minimum is entered', async ({
rightPanelPageObject,
}) => {
const { opacity } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacity.fill('-1');
await expect(opacity.input).toHaveValue('0');
});
test('should reject non-numeric opacity input', async ({ rightPanelPageObject }) => {
const { opacity } = rightPanelPageObject.labelMapSegmentationPanel.config;
await expect(opacity.fill('abc')).rejects.toThrow(nonNumericError);
});
});
test.describe('border', () => {
test('should accept valid values', async ({ rightPanelPageObject }) => {
const { border } = rightPanelPageObject.labelMapSegmentationPanel.config;
await border.fill('0');
await expect(border.input).toHaveValue('0');
await border.fill('5');
await expect(border.input).toHaveValue('5');
await border.fill('10');
await expect(border.input).toHaveValue('10');
});
test('should clamp border to max (10) when a value above the maximum is entered', async ({
rightPanelPageObject,
}) => {
const { border } = rightPanelPageObject.labelMapSegmentationPanel.config;
await border.fill('500');
await expect(border.input).toHaveValue('10');
});
test('should clamp border to min (0) when a value below the minimum is entered', async ({
rightPanelPageObject,
}) => {
const { border } = rightPanelPageObject.labelMapSegmentationPanel.config;
await border.fill('-1');
await expect(border.input).toHaveValue('0');
});
test('should reject non-numeric border input', async ({ rightPanelPageObject }) => {
const { border } = rightPanelPageObject.labelMapSegmentationPanel.config;
await expect(border.fill('abc')).rejects.toThrow(nonNumericError);
});
});
test.describe('opacity inactive', () => {
test('should accept valid values', async ({ rightPanelPageObject }) => {
const { opacityInactive } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacityInactive.fill('0');
await expect(opacityInactive.input).toHaveValue('0');
await opacityInactive.fill('0.5');
await expect(opacityInactive.input).toHaveValue('0.5');
await opacityInactive.fill('1');
await expect(opacityInactive.input).toHaveValue('1');
});
test('should clamp opacity inactive to max (1) when a value above the maximum is entered', async ({
rightPanelPageObject,
}) => {
const { opacityInactive } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacityInactive.fill('500');
await expect(opacityInactive.input).toHaveValue('1');
});
test('should clamp opacity inactive to min (0) when a value below the minimum is entered', async ({
rightPanelPageObject,
}) => {
const { opacityInactive } = rightPanelPageObject.labelMapSegmentationPanel.config;
await opacityInactive.fill('-1');
await expect(opacityInactive.input).toHaveValue('0');
});
test('should reject non-numeric opacity inactive input', async ({ rightPanelPageObject }) => {
const { opacityInactive } = rightPanelPageObject.labelMapSegmentationPanel.config;
await expect(opacityInactive.fill('abc')).rejects.toThrow(nonNumericError);
});
});
});