TrizTech/ohif-viewer
15
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(segmentation scroll): and hydration bugs (#3701)

Browse Source
This commit is contained in:
Joe Boccanfuso 2023-10-05 22:13:08 -04:00 committed by GitHub
parent 748acaf9c1
commit 1fd98d9220
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 25 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/cornerstone-dicom-seg/src/panels/PanelSegmentation.tsx
View File

@ -217,7 +217,7 @@ export default function PanelSegmentation({
return (
<>
<div className="flex min-h-0 flex-auto select-none flex-col justify-between">
<div className="ohif-scrollbar flex min-h-0 flex-auto select-none flex-col justify-between overflow-auto">
<SegmentationGroupTable
title={t('Segmentations')}
segmentations={segmentations}

4
platform/ui/src/components/Notification/Notification.tsx
View File

@ -18,10 +18,14 @@ const Notification = ({ id, type, message, actions, onSubmit, onOutsideClick })
}
};
// Both a mouse down and up listeners are desired so as to avoid missing events
// from elements that have pointer-events:none (e.g. the active viewport).
document.addEventListener('mousedown', handleClick);
document.addEventListener('mouseup', handleClick);
return () => {
document.removeEventListener('mousedown', handleClick);
document.removeEventListener('mouseup', handleClick);
};
}, [onOutsideClick]);

14
platform/ui/src/components/SegmentationGroupTable/SegmentationDropDownRow.tsx
View File

@ -75,14 +75,16 @@ function SegmentationDropDownRow({
storeSegmentation(activeSegmentation.id);
},
},
{
title: 'Download',
onClick: () => {
onSegmentationDownload(activeSegmentation.id);
},
},
]
: []),
...[
{
title: 'Download',
onClick: () => {
onSegmentationDownload(activeSegmentation.id);
},
},
],
]}
>
<div className="hover:bg-secondary-dark mx-1 grid h-[28px] w-[28px] cursor-pointer place-items-center rounded-[4px]">

26
platform/ui/src/components/SegmentationGroupTable/SegmentationGroupTable.tsx
View File

@ -104,20 +104,18 @@ const SegmentationGroupTable = ({
</div>
) : (
<div className="mt-1 select-none">
{!disableEditing && (
<SegmentationDropDownRow
segmentations={segmentations}
disableEditing={disableEditing}
activeSegmentation={activeSegmentation}
onActiveSegmentationChange={onActiveSegmentationChange}
onSegmentationDelete={onSegmentationDelete}
onSegmentationEdit={onSegmentationEdit}
onSegmentationDownload={onSegmentationDownload}
storeSegmentation={storeSegmentation}
onSegmentationAdd={onSegmentationAdd}
onToggleSegmentationVisibility={onToggleSegmentationVisibility}
/>
)}
<SegmentationDropDownRow
segmentations={segmentations}
disableEditing={disableEditing}
activeSegmentation={activeSegmentation}
onActiveSegmentationChange={onActiveSegmentationChange}
onSegmentationDelete={onSegmentationDelete}
onSegmentationEdit={onSegmentationEdit}
onSegmentationDownload={onSegmentationDownload}
storeSegmentation={storeSegmentation}
onSegmentationAdd={onSegmentationAdd}
onToggleSegmentationVisibility={onToggleSegmentationVisibility}
/>
{!disableEditing && showAddSegment && (
<AddSegmentRow onClick={() => onSegmentAdd(activeSegmentationId)} />
)}