TrizTech/ohif-viewer
15
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug Fix: Undefined bestMatch exception being thrown when no match was found.

Browse Source
This commit is contained in:
Emanuel F. Oliveira 2017-02-13 12:37:55 -02:00 committed by Eloízio Salgado
parent 3917e34a74
commit 54e8a3f8f2
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Packages/ohif-hanging-protocols/client/protocolEngine.js
View File

@ -428,9 +428,6 @@ HP.ProtocolEngine = class ProtocolEngine {
// Insert the new study metadata
this.studies.push(studyMetadata);
// Re-match images
this.matchImages(viewport);
// Update the viewport to refresh layout manager with new study
this.updateViewports();
}, error => {
@ -668,9 +665,10 @@ HP.ProtocolEngine = class ProtocolEngine {
currentViewportData.imageId = currentMatch.imageId;
}
if (!currentViewportData.displaySetInstanceUid) {
throw new OHIFError('ProtocolEngine::updateViewports No matching display set found?');
}
// @TODO Why should we throw an exception when a best match is not found? This was aborting the whole process.
// if (!currentViewportData.displaySetInstanceUid) {
// throw new OHIFError('ProtocolEngine::updateViewports No matching display set found?');
// }
viewportData.push(currentViewportData);
});

2
Packages/ohif-viewerbase/client/lib/classes/metadata/Metadata.js
View File

@ -24,7 +24,7 @@ export class Metadata {
value: data
});
// Define _custom properties as an immutable property
// Define "_custom" properties as an immutable property
// IMPORTANT: This property can only be set during instance construction.
Object.defineProperty(this, '_custom', {
configurable: false,